From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BF1FC43381 for ; Tue, 5 Mar 2019 05:07:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F1DB320675 for ; Tue, 5 Mar 2019 05:07:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RRh89cwM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727170AbfCEFHf (ORCPT ); Tue, 5 Mar 2019 00:07:35 -0500 Received: from mail-qt1-f176.google.com ([209.85.160.176]:41484 "EHLO mail-qt1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725818AbfCEFHf (ORCPT ); Tue, 5 Mar 2019 00:07:35 -0500 Received: by mail-qt1-f176.google.com with SMTP id v10so7763161qtp.8 for ; Mon, 04 Mar 2019 21:07:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3zmvZAIotSLPfKONv5r146h2C9yCTEisESc0oWjYego=; b=RRh89cwMFvxdDdo5EYNDZYEb2PQgGjA6awUtqC7tR6AZU6VY15Lp4ZWvf3NeEpihHm 3u/ueRWjbRdDC2YFxILYdmV21Pfr7DQDu7xOE6PY5aPyOqrh5HBFy9jKBniVdYxPR17V 89tLxcnOqoNLccr5URn26sQazGXX9X9O3f3ELc0/hVTw28gurFzYfvv/pQ2Jq6det6RZ Sr6tXeBh3bYD1KALqu8quSgQfesIhbB1zFaeSy0NsRBEp6Q5rj3XGFRj+p81WODiMhzW /Dge9snIMzmDWaAxgzh62nv+mbkjikGgKQeyk6/1LoCNgdwCkt31a45p3YdAXuTk3AOo ONEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3zmvZAIotSLPfKONv5r146h2C9yCTEisESc0oWjYego=; b=ZfCKL9qo5uwiJ5ItNleEugZ1/D/05Q42mMf3sNYMMxFiLtupDpaR40V3ahFNp28CCt enXtRCbvdgQzyXg6VEtBJBQelvAle9KsFMW01wDFTzeM9ONrk0ovWUrd1n1nrXZLF+dY LmvLYbzegEA8/Bc4+5+uQoGKFgL86qscJ/Q3gVwL33mN8FMFz7YANPibM++MyLwx+Ype y62bUTHmn4IKSwsdroDP6Ya8MzP78ANzyP5IrovW+HeeHClsguMtkaKF9o/TQ7t0IAkY D17ofepeXedPJ3ppycCPrSX6nhqBkS6OZH2x5Yipaq1MCDLHZkZrJJX5z9ez8gy8daeT /wFg== X-Gm-Message-State: APjAAAW8Nn1XS0UMJLrXgQaprtEs2fEVl8AOMYcchIps6Df+Uf9iuIHN UwpTk2c3WAbO/IqPpsdDDS4kNOFZw00in+AV2zA= X-Google-Smtp-Source: APXvYqxielrXcJePB6MKPO4RRt1FxTN3yF6rPUuacgQp87f0bspnslhBvHVb7Z8tC1Jjwn1n9MHH3M8eVEOZGvl0dno= X-Received: by 2002:a0c:91a9:: with SMTP id n38mr689273qvn.171.1551762453907; Mon, 04 Mar 2019 21:07:33 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: ronnie sahlberg Date: Tue, 5 Mar 2019 15:07:22 +1000 Message-ID: Subject: Re: More tests added to buildbot To: Steve French Cc: CIFS Content-Type: text/plain; charset="UTF-8" Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org On Tue, Mar 5, 2019 at 3:00 PM Steve French wrote: > > I tried it to Samba a few minutes ago and it worked fine with current for-next > and also:q it looks important (data integrity etc.). Test description > > # Test that mmap read doesn't see non-zero data past EOF on truncate down. > # > # This is inspired by an XFS bug that truncate down fails to zero page cache > # beyond new EOF and causes stale data written to disk unexpectedly and a > # subsequent mmap reads and sees non-zeros post EOF. > > I have two test targets, both Samba localhost. One succeeds for all 8 of > the ones that we were worried about: > > ./check -cifs generic/013 generic/014 generic/024 generic/030 > generic/069 generic/075 generic/112 generic/125 generic/346 > generic/469 generic/469 works against samba but not against windows. So we need to change the buildbot to run it against smb3samba instead of smb3. > > The other succeeds on all but 075 and 112 which worked on the 'old' > xfstests from a month ago, but fail on the one with the newer > xfstests. > > So I think we are ok with 469 ... but we do have to figure out what to > do with what seems to be either a regression in 075 and 112 xfstests > (a bug in the tests) or something that the updated tests are now > seeing as a cifs bug. My theory is that it is due to this xfstest > commit: > > root@smf-Thinkpad-P51:~/xfstests-dev# git log tests/generic/075 > commit ec295d73ac19a42d1f022cb074d0bd506252cb3b > Author: Christoph Hellwig > Date: Fri Feb 15 13:41:40 2019 +0100 > > generic/075,112: detect preallocation support for fsx tests > > Currently generic/075 and generic/112 have two extra fsx passes each > that exercise fsx with preallocation, which are only enabled for > XFS. > > These tests can also be run with other file systems, given that the > XFS prealloc ioctls are implemented in generic code since the > addition of the fallocate system call. This also means a version of > XFS that does not support preallocation (e.g. because it always > writes out of place) can skip the prealloc tests while still > completing the normal fsx tests just fine. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Eryu Guan > Signed-off-by: Eryu Guan > > On Mon, Mar 4, 2019 at 10:10 PM ronnie sahlberg > wrote: > > > > generic/469 does it work for you? > > It fails in the tests. > > > > I have tried it locally and it always fails here. With current > > for-next as well as for-next as of a month ago. > > Same for xfs-tests, with current as well as months old master. > > > > Lets remove it. > > > > On Sun, Mar 3, 2019 at 3:05 PM Steve French wrote: > > > > > > Added four xfs subtests to the cifs-testing buildbot (and 3 of these > > > were also missing from the Azure buildbot so added them to Azure as > > > well) > > > + [ "generic/464", "smb3"], > > > + [ "generic/469", "smb3"], > > > + [ "generic/524", "smb3"], > > > + [ "generic/528", "smb3samba], > > > > > > Testing the three new tests for Azure in > > > http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/4/builds/105 > > > > > > > > > -- > > > Thanks, > > > > > > Steve > > > > -- > Thanks, > > Steve