archive mirror
 help / color / mirror / Atom feed
From: Shyam Prasad N <>
To: Paulo Alcantara <>
Cc: "Steve French" <>,
	"Aurélien Aptel" <>,
	CIFS <>,, "rohiths msft" <>
Subject: Re: Multichannel patches
Date: Fri, 4 Jun 2021 14:43:05 +0530	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Thanks for the reviews.

While rebasing older changes, I missed a single line during the
channel add code, which had caused a regression.
Fixed it and merged with the correct patch here:

I've also integrated Aurelien's comments into these patches.
Also, I've a couple of minor patches here to fix fscache warnings for
multichannel and to integrate new changes into DebugData.
@Steve French Please use these new patches.

@Paulo Alcantara That would be great if you can help testing my
changes. Please test with these new changes.
> The super is only used for providing cifs_sb_info::origin_fullpath as key to find the corresponding failover targets in referral cache.
I'm wondering what would happen if there are multiple tcons to the
same origin_fullpath (possibly in different sessions)?
Also, doesn't failover targets apply to each channel under a session?
Shouldn't we switch targets on reconnect of secondary channels too?

On Wed, Jun 2, 2021 at 10:15 PM Paulo Alcantara <> wrote:
> Shyam Prasad N <> writes:
> > P.S. There is a logic in cifs_reconnect to switch between the targets
> > for the server. I don't think these changes will break the DFS
> > scenario. The code will likely take effect only for when the primary
> > channel reconnects (as DFS server entries are cached with super block
> > as the key). Perhaps more changes will be needed there to also switch
> > between the targets for individual channels (maybe use superblock +
> > channel num as the key for caching entries?). Folks with better
> > knowledge than me with this code may want to check on this?
> I don't think your changes would break it as well.  The super is only
> used for providing cifs_sb_info::origin_fullpath as key to find the
> corresponding failover targets in referral cache.
> I can help you testing your changes with some DFS+multichannel failover
> scenarios.


  reply	other threads:[~2021-06-04  9:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02 12:43 Multichannel patches Shyam Prasad N
2021-06-02 15:57 ` Aurélien Aptel
2021-06-02 18:55   ` Steve French
2021-06-02 16:45 ` Paulo Alcantara
2021-06-04  9:13   ` Shyam Prasad N [this message]
2021-06-04 15:10     ` Steve French
2021-06-04 15:25     ` Paulo Alcantara
2021-06-05 14:08       ` Shyam Prasad N
2021-06-05 17:43         ` Steve French
2021-06-05 17:57           ` Steve French
2021-06-08  9:54             ` Shyam Prasad N

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).