linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] cifs: create sd context must be a multiple of 8
@ 2021-08-05  5:17 Shyam Prasad N
  2021-08-05  5:56 ` ronnie sahlberg
  0 siblings, 1 reply; 2+ messages in thread
From: Shyam Prasad N @ 2021-08-05  5:17 UTC (permalink / raw)
  To: Steve French, CIFS, ronnie sahlberg, rohiths msft

Hi Steve,

Please review the fix for the bug reported at:
https://bugzilla.kernel.org/show_bug.cgi?id=213927

The issue was misalignment of create context caused by one of our
earlier commit:
commit ea64370bcae126a88cd26a16f1abcc23ab2b9a55 (tag: 5.10-rc6-smb3-fixes-part2)
Author: Ronnie Sahlberg <lsahlber@redhat.com>
Date:   Mon Nov 30 11:29:20 2020 +1000

    cifs: refactor create_sd_buf() and and avoid corrupting the buffer

    When mounting with "idsfromsid" mount option, Azure
    corrupted the owner SIDs due to excessive padding
    caused by placing the owner fields at the end of the
    security descriptor on create.  Placing owners at the
    front of the security descriptor (rather than the end)
    is also safer, as the number of ACEs (that follow it)
    are variable.

    Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
    Suggested-by: Rohith Surabattula <rohiths@microsoft.com>
    CC: Stable <stable@vger.kernel.org> # v5.8
    Signed-off-by: Steve French <stfrench@microsoft.com>

The fix can be found at:
https://github.com/sprasad-microsoft/smb3-kernel-client/pull/4

I think this should be marked for stable as well, with a "fixes" tag.

-- 
Regards,
Shyam

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-05  5:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-05  5:17 [PATCH] cifs: create sd context must be a multiple of 8 Shyam Prasad N
2021-08-05  5:56 ` ronnie sahlberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).