Thanks Ronnie.

Sending out a revised patch with cifs_dbg() for dumping keys fixed.
Also rolling back my changes to the ioctl for dumping keys. For now,
it will not work for AES256. But will not break AES128.
For some reason, "smbinfo keys" fails with "syscall failed: [Errno 25]
Inappropriate ioctl for device" even without these changes. Need to
check why?

Regards,
Shyam

On Thu, Mar 25, 2021 at 6:50 PM ronnie sahlberg
<ronniesahlberg@gmail.com> wrote:
>
> Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
>
> Handling all the keys as 32byte arrays internally should be fine
> but for the cifs_dbg() output I think you should add a conditional and
> print them either as 16 or 32 bytes, not always as 32 bytes.
>
> I.e. don't print the 16 byte padding for the aes128 cases.
>
> On Thu, Mar 25, 2021 at 11:08 PM Shyam Prasad N <nspmangalore@gmail.com> wrote:
> >
> > Aargh. Here goes... :)
> >
> > On Thu, Mar 25, 2021 at 6:29 PM ronnie sahlberg
> > <ronniesahlberg@gmail.com> wrote:
> > >
> > > -ENOPATCH ?
> > >
> > > On Thu, Mar 25, 2021 at 10:53 PM Shyam Prasad N <nspmangalore@gmail.com> wrote:
> > > >
> > > > Hi Steve,
> > > >
> > > > Please include this fix for AES 256 encryption algorithm based mounts.
> > > > I've validated this by mounting and performing I/O.
> > > >
> > > > --
> > > > Regards,
> > > > Shyam
> >
> >
> >
> > --
> > Regards,
> > Shyam



-- 
Regards,
Shyam