linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] cifs: enable fscache usage even for files opened as rw
@ 2021-08-10 10:43 Shyam Prasad N
  2021-08-16  3:38 ` Steve French
  0 siblings, 1 reply; 2+ messages in thread
From: Shyam Prasad N @ 2021-08-10 10:43 UTC (permalink / raw)
  To: Steve French, David Howells, CIFS

Hi Steve,

The following patch enables fscache even for scenarios where files are
opened in rw mode. Our current implementation only enables fscache
when the file is opened O_RDONLY.

https://github.com/sprasad-microsoft/smb3-kernel-client/pull/5

Note that this patch can safely be backported. It still does not use
netfs helper library.
I'll be sending another patch with the netfs helper integration soon.

-- 
Regards,
Shyam

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] cifs: enable fscache usage even for files opened as rw
  2021-08-10 10:43 [PATCH] cifs: enable fscache usage even for files opened as rw Shyam Prasad N
@ 2021-08-16  3:38 ` Steve French
  0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2021-08-16  3:38 UTC (permalink / raw)
  To: Shyam Prasad N; +Cc: David Howells, CIFS

Thoughts about the checkpatch warnings?

$ scripts/checkpatch.pl
~/Downloads/096eaae1544b9bc2b1df48613027bd46c629d406.patch
WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code
rather than BUG() or BUG_ON()
#156: FILE: fs/cifs/fscache.c:318:
+ BUG_ON(!cifsi->fscache);

WARNING: function definition argument 'struct inode *' should also
have an identifier name
#191: FILE: fs/cifs/fscache.h:58:
+extern void cifs_fscache_update_inode_cookie(struct inode *);

WARNING: function definition argument 'struct inode *' should also
have an identifier name
#196: FILE: fs/cifs/fscache.h:63:
+extern void __cifs_fscache_wait_on_page_write(struct inode *, struct page *);

WARNING: function definition argument 'struct page *' should also have
an identifier name
#196: FILE: fs/cifs/fscache.h:63:
+extern void __cifs_fscache_wait_on_page_write(struct inode *, struct page *);

On Tue, Aug 10, 2021 at 5:44 AM Shyam Prasad N <nspmangalore@gmail.com> wrote:
>
> Hi Steve,
>
> The following patch enables fscache even for scenarios where files are
> opened in rw mode. Our current implementation only enables fscache
> when the file is opened O_RDONLY.
>
> https://github.com/sprasad-microsoft/smb3-kernel-client/pull/5
>
> Note that this patch can safely be backported. It still does not use
> netfs helper library.
> I'll be sending another patch with the netfs helper integration soon.
>
> --
> Regards,
> Shyam



-- 
Thanks,

Steve

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-16  3:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-10 10:43 [PATCH] cifs: enable fscache usage even for files opened as rw Shyam Prasad N
2021-08-16  3:38 ` Steve French

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).