linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shyam Prasad N <nspmangalore@gmail.com>
To: Rohith Surabattula <rohiths.msft@gmail.com>
Cc: Steve French <smfrench@gmail.com>, CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH][CIFS] Handle race conditions during rename
Date: Tue, 10 Aug 2021 17:16:26 +0530	[thread overview]
Message-ID: <CANT5p=rkhwZgNL_v81rMLJXZPh_bojzH6eAwkEPn4LizK2vozQ@mail.gmail.com> (raw)
In-Reply-To: <CACdtm0YKX0AK6axj+QnpG9cd1ee-3D9jreo567vK+Raf8B0MQw@mail.gmail.com>

I see a memory leak of dclose in cifs_close. I hope that's the one you
were referring to earlier?
Also, we'll need to avoid cifs_close_all_deferred_files in the future.
Maybe not for this patch.

Other than that, looks good to me.
Reviewed-by: Shyam Prasad N <sprasad@microsoft.com>

On Mon, Aug 9, 2021 at 3:54 PM Rohith Surabattula
<rohiths.msft@gmail.com> wrote:
>
> Hi Steve, All,
>
> Have updated the patch slightly with null check to avoid kernel oops.
>
> Regards,
> Rohith
>
> On Wed, Aug 4, 2021 at 11:13 PM Steve French <smfrench@gmail.com> wrote:
> >
> > Lightly updated version of Rohith's newer version of his deferred close fix (fixed minor checkpatch issue and added cc:stable #5.13
> >
> > --
> > Thanks,
> >
> > Steve



-- 
Regards,
Shyam

      reply	other threads:[~2021-08-10 11:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAH2r5ms3XvZSLbAOb7irrZpS0aFsDUW59qRDdN19H8ZaR_YX+w@mail.gmail.com>
2021-08-04 17:44 ` Fwd: " Steve French
2021-08-09  9:56 ` Rohith Surabattula
2021-08-10 11:46   ` Shyam Prasad N [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANT5p=rkhwZgNL_v81rMLJXZPh_bojzH6eAwkEPn4LizK2vozQ@mail.gmail.com' \
    --to=nspmangalore@gmail.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=rohiths.msft@gmail.com \
    --cc=smfrench@gmail.com \
    --subject='Re: [PATCH][CIFS] Handle race conditions during rename' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).