From: Shyam Prasad <Shyam.Prasad@microsoft.com>
To: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>,
"sfrench@samba.org" <sfrench@samba.org>,
"linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>,
"samba-technical@lists.samba.org"
<samba-technical@lists.samba.org>,
"yukuai3@huawei.com" <yukuai3@huawei.com>
Subject: RE: [EXTERNAL] [PATCH] cifs: Fix build error when no CONFIG_DNS_RESOLVER
Date: Fri, 9 Apr 2021 15:58:18 +0000 [thread overview]
Message-ID: <PSAP153MB04220A98B9A57BF059DF611894739@PSAP153MB0422.APCP153.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20210409074634.1809521-1-zhangxiaoxu5@huawei.com>
Hi Zhang,
Thanks for the catch.
But it looks like Steve had already made this change yesterday. Can you please pull and check now?
Regards,
Shyam
-----Original Message-----
From: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Sent: Friday, April 9, 2021 1:17 PM
To: zhangxiaoxu5@huawei.com; sfrench@samba.org; linux-cifs@vger.kernel.org; samba-technical@lists.samba.org; yukuai3@huawei.com; Shyam Prasad <Shyam.Prasad@microsoft.com>
Subject: [EXTERNAL] [PATCH] cifs: Fix build error when no CONFIG_DNS_RESOLVER
hulk robot following build error:
ld: fs/cifs/dns_resolve.o: in function `dns_resolve_server_name_to_ip':
dns_resolve.c:(.text+0x154): undefined reference to `dns_query'
make: *** [Makefile:1251: vmlinux] Error 1
Fixes: e488292a31fa ("cifs: On cifs_reconnect, resolve the hostname again.")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
---
fs/cifs/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig index fe03cbdae959..0d8199765045 100644
--- a/fs/cifs/Kconfig
+++ b/fs/cifs/Kconfig
@@ -18,6 +18,7 @@ config CIFS
select CRYPTO_AES
select CRYPTO_LIB_DES
select KEYS
+ select DNS_RESOLVER
help
This is the client VFS module for the SMB3 family of NAS protocols,
(including support for the most recent, most secure dialect SMB3.1.1) @@ -179,7 +180,6 @@ config CIFS_DEBUG_DUMP_KEYS config CIFS_DFS_UPCALL
bool "DFS feature support"
depends on CIFS
- select DNS_RESOLVER
help
Distributed File System (DFS) support is used to access shares
transparently in an enterprise name space, even if the share
--
2.25.4
prev parent reply other threads:[~2021-04-09 15:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 7:46 [PATCH] cifs: Fix build error when no CONFIG_DNS_RESOLVER Zhang Xiaoxu
2021-04-09 15:58 ` Shyam Prasad [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PSAP153MB04220A98B9A57BF059DF611894739@PSAP153MB0422.APCP153.PROD.OUTLOOK.COM \
--to=shyam.prasad@microsoft.com \
--cc=linux-cifs@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=yukuai3@huawei.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).