From: Steven French <Steven.French@microsoft.com>
To: Sasha Levin <sashal@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Cc: Ronnie Sahlberg <lsahlber@redhat.com>,
"Eric W . Biederman" <ebiederm@xmission.com>,
"linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>,
"samba-technical@lists.samba.org"
<samba-technical@lists.samba.org>
Subject: RE: [EXTERNAL] [PATCH AUTOSEL 4.9 177/251] cifs: fix rmmod regression in cifs.ko caused by force_sig changes
Date: Thu, 16 Jan 2020 19:11:11 +0000 [thread overview]
Message-ID: <SN6PR2101MB1325121720B1E3645F2CF369E4360@SN6PR2101MB1325.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20200116173641.22137-137-sashal@kernel.org>
I didn't think the patch that this fixes (72abe3bcf091) was in 4.9 (it was May 2019)? Did Eric's patch to switch from force_sig to send_sig get backported as well?
-----Original Message-----
From: Sasha Levin <sashal@kernel.org>
Sent: Thursday, January 16, 2020 9:35 AM
To: linux-kernel@vger.kernel.org; stable@vger.kernel.org
Cc: Steven French <Steven.French@microsoft.com>; Ronnie Sahlberg <lsahlber@redhat.com>; Eric W . Biederman <ebiederm@xmission.com>; Sasha Levin <sashal@kernel.org>; linux-cifs@vger.kernel.org; samba-technical@lists.samba.org
Subject: [EXTERNAL] [PATCH AUTOSEL 4.9 177/251] cifs: fix rmmod regression in cifs.ko caused by force_sig changes
From: Steve French <stfrench@microsoft.com>
[ Upstream commit 247bc9470b1eeefc7b58cdf2c39f2866ba651509 ]
Fixes: 72abe3bcf091 ("signal/cifs: Fix cifs_put_tcp_session to call send_sig instead of force_sig")
The global change from force_sig caused module unloading of cifs.ko to fail (since the cifsd process could not be killed, "rmmod cifs"
now would always fail)
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
CC: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
fs/cifs/connect.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 110febd69737..7d46025d5e89 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -885,6 +885,7 @@ cifs_demultiplex_thread(void *p)
mempool_resize(cifs_req_poolp, length + cifs_min_rcv);
set_freezable();
+ allow_signal(SIGKILL);
while (server->tcpStatus != CifsExiting) {
if (try_to_freeze())
continue;
--
2.20.1
next prev parent reply other threads:[~2020-01-16 19:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200116173641.22137-1-sashal@kernel.org>
2020-01-16 17:34 ` [PATCH AUTOSEL 4.9 149/251] signal/cifs: Fix cifs_put_tcp_session to call send_sig instead of force_sig Sasha Levin
2020-01-16 17:35 ` [PATCH AUTOSEL 4.9 177/251] cifs: fix rmmod regression in cifs.ko caused by force_sig changes Sasha Levin
2020-01-16 19:11 ` Steven French [this message]
2020-01-16 17:35 ` [PATCH AUTOSEL 4.9 183/251] signal: Allow cifs and drbd to receive their terminating signals Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR2101MB1325121720B1E3645F2CF369E4360@SN6PR2101MB1325.namprd21.prod.outlook.com \
--to=steven.french@microsoft.com \
--cc=ebiederm@xmission.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=samba-technical@lists.samba.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).