linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Jeffrey Altman <jaltman@auristor.com>,
	linux-afs@lists.infradead.org, Jeff Layton <jlayton@kernel.org>,
	Ilya Dryomov <idryomov@gmail.com>,
	linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com,
	linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
	ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net,
	devel@lists.orangefs.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] afs: Fix afs_launder_page() to set correct start file position
Date: Tue, 24 Aug 2021 15:18:07 +0100	[thread overview]
Message-ID: <YST/n+gcppuwWCJx@infradead.org> (raw)
In-Reply-To: <162981148752.1901565.3663780601682206026.stgit@warthog.procyon.org.uk>

On Tue, Aug 24, 2021 at 02:24:47PM +0100, David Howells wrote:
> +		ret = afs_store_data(vnode, &iter,
> +				     (loff_t)page->index * PAGE_SIZE + f, true);

You probably want to use page_offset() here:

		ret = afs_store_data(vnode, &iter, page_offset(page) + f, true);


  reply	other threads:[~2021-08-24 14:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24 13:24 [PATCH 0/6] netfs, afs, ceph: Support folios, at least partially David Howells
2021-08-24 13:24 ` [PATCH 1/6] afs: Fix afs_launder_page() to set correct start file position David Howells
2021-08-24 14:18   ` Christoph Hellwig [this message]
2021-08-24 14:18   ` Matthew Wilcox
2021-08-24 14:38   ` David Howells
2021-08-24 13:24 ` [PATCH 2/6] folio: Add a function to change the private data attached to a folio David Howells
2021-08-24 13:25 ` [PATCH 3/6] folio: Add a function to get the host inode for " David Howells
2021-08-24 14:03   ` Matthew Wilcox
2021-08-24 14:11   ` David Howells
2021-08-24 13:25 ` [PATCH 4/6] afs: Sort out symlink reading David Howells
2021-08-24 13:25 ` [PATCH 5/6] netfs, afs, ceph: Use folios David Howells
2021-08-24 13:25 ` [PATCH 6/6] afs: Use folios in directory handling David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YST/n+gcppuwWCJx@infradead.org \
    --to=hch@infradead.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=devel@lists.orangefs.org \
    --cc=dhowells@redhat.com \
    --cc=idryomov@gmail.com \
    --cc=jaltman@auristor.com \
    --cc=jlayton@kernel.org \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-cachefs@redhat.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=v9fs-developer@lists.sourceforge.net \
    --cc=willy@infradead.org \
    --subject='Re: [PATCH 1/6] afs: Fix afs_launder_page() to set correct start file position' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).