From: Ralph Boehme <slow@samba.org>
To: Namjae Jeon <linkinjeon@kernel.org>, linux-cifs@vger.kernel.org
Cc: Tom Talpey <tom@talpey.com>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Steve French <smfrench@gmail.com>,
Hyunchul Lee <hyc.lee@gmail.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [PATCH v3 0/5] ksmbd: a bunch of patches
Date: Mon, 27 Sep 2021 17:42:10 +0200 [thread overview]
Message-ID: <a15a1d99-1a2f-0f41-773e-def5b83f2304@samba.org> (raw)
In-Reply-To: <20210926135543.119127-1-linkinjeon@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 1252 bytes --]
Hi Namjae
Am 26.09.21 um 15:55 schrieb Namjae Jeon:
> Cc: Tom Talpey <tom@talpey.com>
> Cc: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> Cc: Ralph Böhme <slow@samba.org>
> Cc: Steve French <smfrench@gmail.com>
> Cc: Hyunchul Lee <hyc.lee@gmail.com>
> Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
>
> v2:
> - update comments of smb2_get_data_area_len().
> - fix wrong buffer size check in fsctl_query_iface_info_ioctl().
> - fix 32bit overflow in smb2_set_info.
>
> v3:
> - add buffer check for ByteCount of smb negotiate request.
> - Moved buffer check of to the top of loop to avoid unneeded behavior when
> out_buf_len is smaller than network_interface_info_ioctl_rsp.
> - get correct out_buf_len which doesn't exceed max stream protocol length.
> - subtract single smb2_lock_element for correct buffer size check in
> ksmbd_smb2_check_message().
I think there are a few issues with this patchset. I'm working on fixes
and improvements and will push my branch to my github clone once I'm
ready. I guess it's going to take a few days.
Cheers!
-slow
--
Ralph Boehme, Samba Team https://samba.org/
SerNet Samba Team Lead https://sernet.de/en/team-samba
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2021-09-27 15:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 13:55 [PATCH v3 0/5] ksmbd: a bunch of patches Namjae Jeon
2021-09-26 13:55 ` [PATCH v3 1/5] ksmbd: add the check to vaildate if stream protocol length exceeds maximum value Namjae Jeon
2021-09-26 13:55 ` [PATCH v3 2/5] ksmbd: add validation in smb2_ioctl Namjae Jeon
2021-09-26 13:55 ` [PATCH v3 3/5] ksmbd: add request buffer validation in smb2_set_info Namjae Jeon
2021-09-26 13:55 ` [PATCH v3 4/5] ksmbd: check strictly data area in ksmbd_smb2_check_message() Namjae Jeon
2021-09-26 13:55 ` [PATCH v3 5/5] ksmbd: add validation in smb2 negotiate Namjae Jeon
2021-09-26 14:27 ` [PATCH v3 0/5] ksmbd: a bunch of patches Ralph Boehme
2021-09-26 15:32 ` Namjae Jeon
2021-09-27 15:42 ` Ralph Boehme [this message]
2021-09-27 23:57 ` Namjae Jeon
2021-09-28 3:26 ` Ralph Boehme
2021-09-28 13:43 ` Ralph Boehme
2021-09-28 14:23 ` Namjae Jeon
2021-09-28 16:33 ` Ralph Boehme
2021-09-28 17:33 ` Jeremy Allison
2021-09-29 15:28 ` Tom Talpey
2021-09-29 15:42 ` Jeremy Allison
2021-09-29 16:38 ` Ralph Boehme
2021-09-29 16:45 ` Tom Talpey
2021-09-29 17:08 ` Ralph Boehme
2021-09-29 17:11 ` Steve French
2021-09-29 17:18 ` Ralph Boehme
2021-09-30 0:32 ` Namjae Jeon
2021-09-30 0:51 ` Hyunchul Lee
2021-09-30 7:57 ` Ralph Boehme
2021-09-28 23:27 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a15a1d99-1a2f-0f41-773e-def5b83f2304@samba.org \
--to=slow@samba.org \
--cc=hyc.lee@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=ronniesahlberg@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).