From: Jeff Layton <jlayton@kernel.org>
To: Joseph Qi <joseph.qi@linux.alibaba.com>,
Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>
Cc: hch@lst.de, linux-kernel@vger.kernel.org,
v9fs-developer@lists.sourceforge.net,
linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org,
ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org,
samba-technical@lists.samba.org, cluster-devel@redhat.com,
linux-nfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
devel@lists.orangefs.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] filelock: move file locking definitions to separate header file
Date: Tue, 22 Nov 2022 07:20:35 -0500 [thread overview]
Message-ID: <a731e688122d1a6fdb2f7bdbd71d403fa110e9f2.camel@kernel.org> (raw)
In-Reply-To: <0c6a44ff-409e-99b2-eaa9-fd6e87a9e104@linux.alibaba.com>
On Tue, 2022-11-22 at 09:51 +0800, Joseph Qi wrote:
> Hi,
>
> On 11/21/22 4:59 AM, Jeff Layton wrote:
> > The file locking definitions have lived in fs.h since the dawn of time,
> > but they are only used by a small subset of the source files that
> > include it.
> >
> > Move the file locking definitions to a new header file, and add the
> > appropriate #include directives to the source files that need them. By
> > doing this we trim down fs.h a bit and limit the amount of rebuilding
> > that has to be done when we make changes to the file locking APIs.
> >
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> > fs/9p/vfs_file.c | 1 +
> > fs/afs/internal.h | 1 +
> > fs/attr.c | 1 +
> > fs/ceph/locks.c | 1 +
> > fs/cifs/cifsfs.c | 1 +
> > fs/cifs/cifsglob.h | 1 +
> > fs/cifs/cifssmb.c | 1 +
> > fs/cifs/file.c | 1 +
> > fs/cifs/smb2file.c | 1 +
> > fs/dlm/plock.c | 1 +
> > fs/fcntl.c | 1 +
> > fs/file_table.c | 1 +
> > fs/fuse/file.c | 1 +
> > fs/gfs2/file.c | 1 +
> > fs/inode.c | 1 +
> > fs/ksmbd/smb2pdu.c | 1 +
> > fs/ksmbd/vfs.c | 1 +
> > fs/ksmbd/vfs_cache.c | 1 +
> > fs/lockd/clntproc.c | 1 +
> > fs/lockd/netns.h | 1 +
> > fs/locks.c | 1 +
> > fs/namei.c | 1 +
> > fs/nfs/nfs4_fs.h | 1 +
> > fs/nfs_common/grace.c | 1 +
> > fs/nfsd/netns.h | 1 +
> > fs/ocfs2/locks.c | 1 +
> > fs/ocfs2/stack_user.c | 1 +
>
> Seems it misses the related changes in:
> fs/ocfs2/stackglue.c
>
I was able to build ocfs2.ko just fine without any changes to
stackglue.c. What problem do you see here?
Thanks,
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2022-11-22 12:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-20 20:59 [PATCH] filelock: move file locking definitions to separate header file Jeff Layton
2022-11-21 1:26 ` Xiubo Li
2022-11-22 3:44 ` Matthew Wilcox
2022-11-21 7:59 ` Christoph Hellwig
2022-11-21 9:19 ` Christian Brauner
2022-11-21 14:40 ` Chuck Lever III
2022-11-21 15:31 ` David Howells
2022-11-21 16:21 ` Steve French
2022-11-21 16:53 ` Darrick J. Wong
2022-11-21 17:16 ` Jeff Layton
2022-11-21 17:27 ` Darrick J. Wong
2022-11-21 19:06 ` Jeff Layton
2022-11-22 1:51 ` Joseph Qi
2022-11-22 12:20 ` Jeff Layton [this message]
2022-11-22 13:54 ` Joseph Qi
2022-11-22 3:51 ` Matthew Wilcox
2022-11-22 6:06 ` Christoph Hellwig
2022-11-22 11:13 ` Jeff Layton
2022-11-25 3:34 ` Al Viro
2022-11-25 3:48 ` Al Viro
2022-11-25 13:23 ` Jeff Layton
2022-11-25 16:44 ` Al Viro
2022-11-28 10:53 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a731e688122d1a6fdb2f7bdbd71d403fa110e9f2.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=cluster-devel@redhat.com \
--cc=devel@lists.orangefs.org \
--cc=hch@lst.de \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=samba-technical@lists.samba.org \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).