linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tom Talpey <tom@talpey.com>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: Steve French <smfrench@gmail.com>, CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH] ksmbd: add default data stream name in FILE_STREAM_INFORMATION
Date: Tue, 21 Sep 2021 14:19:02 -0400	[thread overview]
Message-ID: <a8f47375-9672-8761-55fe-d99add3a39b1@talpey.com> (raw)
In-Reply-To: <CAKYAXd9VJ52QOEdAaNC3ZVAZk3mBAZFHo=uME_ygK0Axk=yivQ@mail.gmail.com>

On 9/20/2021 12:34 PM, Namjae Jeon wrote:
> 2021-09-21 1:08 GMT+09:00, Tom Talpey <tom@talpey.com>:
<snip>
>>
>> My concern here is, what's so special about directories? A special file
>> or fifo, a symlink or reparse/junction, etc. Is it appropriate to cons
>> up a ::$DATA for these? What should the size values be, if so?
> Special files in linux(ksmbd share) is showing as regular file on
> windows client.

This brings up an interesting second question. Is that a good thing?

It seems risky, and perhaps wrong, that one can open such a special file 
and read or write it over SMB3. I can see allowing read attributes, etc, 
but certainly not full access. To me, at a minimum the read or write 
should be failed by ksmbd, if not the CREATE itself. ksmbd should not be 
representing these as ordinary files.

Tom.

  reply	other threads:[~2021-09-21 18:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-18 12:02 Namjae Jeon
2021-09-18 12:39 ` Tom Talpey
2021-09-18 21:36   ` Namjae Jeon
2021-09-20  4:47   ` Steve French
2021-09-20  4:53     ` Steve French
2021-09-20 16:08     ` Tom Talpey
2021-09-20 16:34       ` Namjae Jeon
2021-09-21 18:19         ` Tom Talpey [this message]
2021-09-21 19:17           ` Steve French
2021-09-20 16:36       ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8f47375-9672-8761-55fe-d99add3a39b1@talpey.com \
    --to=tom@talpey.com \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    --subject='Re: [PATCH] ksmbd: add default data stream name in FILE_STREAM_INFORMATION' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).