linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Metzmacher <metze@samba.org>
To: Namjae Jeon <namjae.jeon@samsung.com>,
	linux-cifsd-devel@lists.sourceforge.net,
	"linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>
Subject: Re: [Linux-cifsd-devel] [PATCH] ksmbd-tools: add support for SMB3 multichannel
Date: Fri, 16 Jul 2021 09:50:04 +0200	[thread overview]
Message-ID: <d6d4e15b-95aa-38d1-40f7-14f99fe24260@samba.org> (raw)
In-Reply-To: <20210614084135.19753-1-namjae.jeon@samsung.com>


[-- Attachment #1.1: Type: text/plain, Size: 1307 bytes --]


Hi Namjae,

> Add support for SMB3 multichannel.
> 
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> ---
>  Documentation/configuration.txt | 3 +++
>  include/linux/ksmbd_server.h    | 1 +
>  lib/config_parser.c             | 9 +++++++++
>  3 files changed, 13 insertions(+)
> 
> diff --git a/Documentation/configuration.txt b/Documentation/configuration.txt
> index f38aceb..1289cbf 100644
> --- a/Documentation/configuration.txt
> +++ b/Documentation/configuration.txt
> @@ -109,6 +109,9 @@ Define ksmbd configuration parameters list.
>  		host where ksmbd runs. the format is "cifs/<FQDN>". if this
>  		option is not given, ksmbd sets "cifs" to the service name and
>  		try to get the host FQDN using getaddrinfo(3).
> +	- server multi channel support
> +		This boolean parameter controls whether ksmbd will support
> +		SMB3 multi-channel.

Did you actually implemented all replay related features?
- Create replay
- Lock replay
- Write/IOCtl/SetInfo replay
- Lease/OplockBreak replay

Otherwise you should mark this as experimental,
as it's likely to end with potential data coruption.
That's why Samba had this flagged as experimental up to now,
Samba 4.15 will be the first release with all required features
in order to enable multi channel.

metze


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

       reply	other threads:[~2021-07-16  7:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210614085106epcas1p4143f68f380c480f5f8a504370b10a969@epcas1p4.samsung.com>
     [not found] ` <20210614084135.19753-1-namjae.jeon@samsung.com>
2021-07-16  7:50   ` Stefan Metzmacher [this message]
2021-07-16  7:56     ` Namjae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6d4e15b-95aa-38d1-40f7-14f99fe24260@samba.org \
    --to=metze@samba.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-cifsd-devel@lists.sourceforge.net \
    --cc=namjae.jeon@samsung.com \
    --subject='Re: [Linux-cifsd-devel] [PATCH] ksmbd-tools: add support for SMB3 multichannel' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).