From: Jeff Layton <jlayton@kernel.org>
To: David Howells <dhowells@redhat.com>, Steve French <smfrench@gmail.com>
Cc: Shyam Prasad N <nspmangalore@gmail.com>,
linux-cifs@vger.kernel.org, linux-cachefs@redhat.com,
Matthew Wilcox <willy@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] cifs: Use fscache I/O again after the rewrite disabled it
Date: Fri, 28 Jan 2022 05:58:20 -0500 [thread overview]
Message-ID: <e5bee4a3e8a7c860d447fe74d5cf2d1846e8600d.camel@kernel.org> (raw)
In-Reply-To: <164329930161.843658.7387773437540491743.stgit@warthog.procyon.org.uk>
On Thu, 2022-01-27 at 16:01 +0000, David Howells wrote:
> Hi Steve,
>
> Here are some patches to make cifs actually do I/O to the cache after it
> got disabled in the fscache rewrite[1] plus a warning fix that you might
> want to detach and take separately:
>
> (1) Fix a kernel doc warning.
>
> (2) Change cifs from using ->readpages() to using ->readahead().
>
> (3) Provide a netfs cache op to query for the presence of data in the
> cache.[*]
>
> (4) Make ->readahead() call
>
> The patches can be found here also:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=fscache-rewrite
>
> David
>
> [*] Ideally, we would use the netfslib read helpers, but it's probably better
> to roll iterators down into cifs's I/O layer before doing that[2].
>
> Link: https://lore.kernel.org/r/164021479106.640689.17404516570194656552.stgit@warthog.procyon.org.uk/ [1]
> Link: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=cifs-experimental [2]
>
> ---
> David Howells (4):
> Fix a warning about a malformed kernel doc comment in cifs by removing the
> cifs: Transition from ->readpages() to ->readahead()
> netfs, cachefiles: Add a method to query presence of data in the cache
> cifs: Implement cache I/O by accessing the cache directly
>
>
> Documentation/filesystems/netfs_library.rst | 16 ++
> fs/cachefiles/io.c | 59 ++++++
> fs/cifs/connect.c | 2 +-
> fs/cifs/file.c | 221 ++++++++------------
> fs/cifs/fscache.c | 126 +++++++++--
> fs/cifs/fscache.h | 79 ++++---
> include/linux/netfs.h | 7 +
> 7 files changed, 322 insertions(+), 188 deletions(-)
>
>
Acked-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2022-01-28 10:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 16:01 [PATCH 0/4] cifs: Use fscache I/O again after the rewrite disabled it David Howells
2022-01-27 16:02 ` [PATCH 1/4] Fix a warning about a malformed kernel doc comment in cifs by removing the David Howells
2022-01-27 16:02 ` [PATCH 2/4] cifs: Transition from ->readpages() to ->readahead() David Howells
2022-01-27 16:02 ` [PATCH 3/4] netfs, cachefiles: Add a method to query presence of data in the cache David Howells
2022-01-27 16:02 ` [PATCH 4/4] cifs: Implement cache I/O by accessing the cache directly David Howells
2022-01-28 0:55 ` Steve French
2022-01-28 0:58 ` Matthew Wilcox
2022-01-27 16:09 ` [PATCH 0/4] cifs: Use fscache I/O again after the rewrite disabled it David Howells
2022-01-28 10:58 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bee4a3e8a7c860d447fe74d5cf2d1846e8600d.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=dhowells@redhat.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=smfrench@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).