Re: [PATCH V4 0/4] Add camera clock controller support for SM8550

[Jagadeesh Kona <quic_jkona@quicinc.com>]

On 6/14/2023 5:47 PM, Dmitry Baryshkov wrote:
> On Wed, 14 Jun 2023 at 14:58, Jagadeesh Kona <quic_jkona@quicinc.com> wrote:
>>
>>
>>
>> On 6/9/2023 6:24 PM, Konrad Dybcio wrote:
>>>
>>>
>>> On 9.06.2023 13:50, Jagadeesh Kona wrote:
>>>> Add bindings, driver and devicetree node for camera clock controller on
>>>> SM8550.
>>>>
>>>> Jagadeesh Kona (4):
>>>>     dt-bindings: clock: qcom: Add SM8550 camera clock controller
>>>>     clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550
>>>>     clk: qcom: camcc-sm8550: Add support for qdss, sleep and xo clocks
>>>>     arm64: dts: qcom: sm8550: Add camera clock controller
>>> What's the final verdict on RINGOSC_L etc.?
>>>
>>> Konrad
>>
>> We would like to pass RINGOSC_CAL_L field directly in config->l value
>> itself and reuse existing code rather than adding a separate function
>> for lucid ole pll configure.
> 
> As I wrote in another email, it doesn't sound like a good approach.
> 

Will avoid this approach and use separate clk_lucid_ole_pll_configure() 
to configure lucid ole PLL's in next series.

Thanks,
Jagadeesh

>>
>> Thanks,
>> Jagadeesh
>>
>>>>
>>>>    .../bindings/clock/qcom,sm8450-camcc.yaml     |    8 +-
>>>>    arch/arm64/boot/dts/qcom/sm8550.dtsi          |   15 +
>>>>    drivers/clk/qcom/Kconfig                      |    7 +
>>>>    drivers/clk/qcom/Makefile                     |    1 +
>>>>    drivers/clk/qcom/camcc-sm8550.c               | 3585 +++++++++++++++++
>>>>    include/dt-bindings/clock/qcom,sm8550-camcc.h |  187 +
>>>>    6 files changed, 3801 insertions(+), 2 deletions(-)
>>>>    create mode 100644 drivers/clk/qcom/camcc-sm8550.c
>>>>    create mode 100644 include/dt-bindings/clock/qcom,sm8550-camcc.h
>>>>
> 
> 
>