From: Chanwoo Choi <cw00.choi@samsung.com>
To: Yangtao Li <tiny.windzz@gmail.com>,
afaerber@suse.de, manivannan.sadhasivam@linaro.org,
mturquette@baylibre.com, sboyd@kernel.org,
Eugeniy.Paltsev@synopsys.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, agross@kernel.org,
s.nawrocki@samsung.com, tomasz.figa@gmail.com, kgene@kernel.org,
krzk@kernel.org, palmer@sifive.com, paul.walmsley@sifive.com,
dinguyen@kernel.org, mripard@kernel.org, wens@csie.org,
emilio@elopez.com.ar, pdeschrijver@nvidia.com,
pgaikwad@nvidia.com, thierry.reding@gmail.com,
jonathanh@nvidia.com, matthias.bgg@gmail.com,
rfontana@redhat.com, gregkh@linuxfoundation.org, t-kristo@ti.com,
john@phrozen.org, tglx@linutronix.de, allison@lohutok.net,
kstewart@linuxfoundation.org, swinslow@gmail.com,
aisheng.dong@nxp.com, robh@kernel.org, daniel.baluta@nxp.com,
wangyan.wang@mediatek.com, chunhui.dai@mediatek.com,
miquel.raynal@bootlin.com, heiko@sntech.de, jcmvbkbc@gmail.com,
nsekhar@ti.com, geert+renesas@glider.be
Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-tegra@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 03/17] clk: samsung: convert to devm_platform_ioremap_resource
Date: Tue, 10 Dec 2019 11:10:39 +0900 [thread overview]
Message-ID: <02ece950-b3d2-0d1a-fd94-acb64272bc96@samsung.com> (raw)
In-Reply-To: <20191209195749.868-3-tiny.windzz@gmail.com>
Hi,
On 12/10/19 4:57 AM, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/clk/samsung/clk-exynos-audss.c | 4 +---
> drivers/clk/samsung/clk-exynos4412-isp.c | 4 +---
> drivers/clk/samsung/clk-exynos5433.c | 4 +---
> drivers/clk/samsung/clk-s5pv210-audss.c | 4 +---
> 4 files changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos-audss.c b/drivers/clk/samsung/clk-exynos-audss.c
> index 42b5d32c6cc7..9cc127a162ad 100644
> --- a/drivers/clk/samsung/clk-exynos-audss.c
> +++ b/drivers/clk/samsung/clk-exynos-audss.c
> @@ -129,7 +129,6 @@ static int exynos_audss_clk_probe(struct platform_device *pdev)
> struct clk *pll_ref, *pll_in, *cdclk, *sclk_audio, *sclk_pcm_in;
> const struct exynos_audss_clk_drvdata *variant;
> struct clk_hw **clk_table;
> - struct resource *res;
> struct device *dev = &pdev->dev;
> int i, ret = 0;
>
> @@ -137,8 +136,7 @@ static int exynos_audss_clk_probe(struct platform_device *pdev)
> if (!variant)
> return -EINVAL;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - reg_base = devm_ioremap_resource(dev, res);
> + reg_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(reg_base))
> return PTR_ERR(reg_base);
>
> diff --git a/drivers/clk/samsung/clk-exynos4412-isp.c b/drivers/clk/samsung/clk-exynos4412-isp.c
> index 4b9e73608c21..20f5129f7212 100644
> --- a/drivers/clk/samsung/clk-exynos4412-isp.c
> +++ b/drivers/clk/samsung/clk-exynos4412-isp.c
> @@ -110,11 +110,9 @@ static int __init exynos4x12_isp_clk_probe(struct platform_device *pdev)
> struct samsung_clk_provider *ctx;
> struct device *dev = &pdev->dev;
> struct device_node *np = dev->of_node;
> - struct resource *res;
> void __iomem *reg_base;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - reg_base = devm_ioremap_resource(dev, res);
> + reg_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(reg_base)) {
> dev_err(dev, "failed to map registers\n");
> return PTR_ERR(reg_base);
> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
> index 4b1aa9382ad2..b0d48cddfd6e 100644
> --- a/drivers/clk/samsung/clk-exynos5433.c
> +++ b/drivers/clk/samsung/clk-exynos5433.c
> @@ -5557,7 +5557,6 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev)
> struct exynos5433_cmu_data *data;
> struct samsung_clk_provider *ctx;
> struct device *dev = &pdev->dev;
> - struct resource *res;
> void __iomem *reg_base;
> int i;
>
> @@ -5570,8 +5569,7 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev)
> return -ENOMEM;
> ctx = &data->ctx;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - reg_base = devm_ioremap_resource(dev, res);
> + reg_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(reg_base))
> return PTR_ERR(reg_base);
>
> diff --git a/drivers/clk/samsung/clk-s5pv210-audss.c b/drivers/clk/samsung/clk-s5pv210-audss.c
> index 14985ebd043b..503bd8a10d8f 100644
> --- a/drivers/clk/samsung/clk-s5pv210-audss.c
> +++ b/drivers/clk/samsung/clk-s5pv210-audss.c
> @@ -63,15 +63,13 @@ static struct syscore_ops s5pv210_audss_clk_syscore_ops = {
> static int s5pv210_audss_clk_probe(struct platform_device *pdev)
> {
> int i, ret = 0;
> - struct resource *res;
> const char *mout_audss_p[2];
> const char *mout_i2s_p[3];
> const char *hclk_p;
> struct clk_hw **clk_table;
> struct clk *hclk, *pll_ref, *pll_in, *cdclk, *sclk_audio;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - reg_base = devm_ioremap_resource(&pdev->dev, res);
> + reg_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(reg_base)) {
> dev_err(&pdev->dev, "failed to map audss registers\n");
> return PTR_ERR(reg_base);
>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2019-12-10 2:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 19:57 [PATCH 01/17] clk: sunxi: sunxi-ng: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-09 19:57 ` [PATCH 02/17] clk: qcom: " Yangtao Li
2019-12-09 19:57 ` [PATCH 03/17] clk: samsung: " Yangtao Li
2019-12-10 2:10 ` Chanwoo Choi [this message]
2019-12-09 19:57 ` [PATCH 04/17] clk: mediatek: " Yangtao Li
2019-12-09 19:57 ` [PATCH 05/17] clk: hisilicon: " Yangtao Li
2019-12-09 19:57 ` [PATCH 06/17] clk: tegra: " Yangtao Li
2019-12-11 9:49 ` Peter De Schrijver
2019-12-09 19:57 ` [PATCH 07/17] clk: mvebu: " Yangtao Li
2019-12-09 19:57 ` [PATCH 08/17] clk: imx: " Yangtao Li
2019-12-09 19:57 ` [PATCH 09/17] clk: sifive: " Yangtao Li
2019-12-09 19:57 ` [PATCH 10/17] clk: axi-clkgen: " Yangtao Li
2019-12-09 19:57 ` [PATCH 11/17] clk: milbeaut: " Yangtao Li
2019-12-09 19:57 ` [PATCH 12/17] clk: socfpga: " Yangtao Li
2019-12-16 20:20 ` Dinh Nguyen
2019-12-09 19:57 ` [PATCH 13/17] clk: gemini: " Yangtao Li
2019-12-09 19:57 ` [PATCH 14/17] clk: axm5516: " Yangtao Li
2019-12-09 19:57 ` [PATCH 15/17] clk: bm1880: " Yangtao Li
2019-12-09 19:57 ` [PATCH 16/17] clk: actions: " Yangtao Li
2019-12-09 19:57 ` [PATCH 17/17] ARC: clk: " Yangtao Li
2020-01-31 1:06 ` [PATCH 01/17] clk: sunxi: sunxi-ng: " Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02ece950-b3d2-0d1a-fd94-acb64272bc96@samsung.com \
--to=cw00.choi@samsung.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=afaerber@suse.de \
--cc=agross@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=allison@lohutok.net \
--cc=chunhui.dai@mediatek.com \
--cc=daniel.baluta@nxp.com \
--cc=dinguyen@kernel.org \
--cc=emilio@elopez.com.ar \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=jcmvbkbc@gmail.com \
--cc=john@phrozen.org \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=nsekhar@ti.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=rfontana@redhat.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=swinslow@gmail.com \
--cc=t-kristo@ti.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=tiny.windzz@gmail.com \
--cc=tomasz.figa@gmail.com \
--cc=wangyan.wang@mediatek.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).