From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: "Stephen Boyd" <sboyd@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org,
"Karl Rudbæk Olsen" <karl@micro-technic.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] clk: at91: add sama5d3 pmc driver
Date: Fri, 3 Jul 2020 09:34:43 +0200 [thread overview]
Message-ID: <043970b9-6cc6-e5c6-b5b1-e0f1a9799ae1@pengutronix.de> (raw)
In-Reply-To: <20200622214759.GK131826@piout.net>
Hello Alexandre,
On 6/22/20 11:47 PM, Alexandre Belloni wrote:
> Hi,
>
> On 22/06/2020 23:24:45+0200, Ahmad Fatoum wrote:
>>> + regmap = syscon_node_to_regmap(np);
>>
>> Shouldn't this be device_node_to_regmap for the same reasons outlined in your
>> 6956eb33 ("clk: at91: fix possible deadlock") commit?
>>
>> Same question for at91sam9g45.c, sam9x60.c and at91sam9n12.c.
>>
>
> Agreed, I guess you can send a patch fixing all the instances.
I just sent out a patch for those 4 files. I don't know if this issue is equally
applicable to the dt-compat.c code, so I left that one as is.
Cheers,
Ahmad
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2020-07-03 7:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 22:30 [PATCH v2] clk: at91: add sama5d3 pmc driver Alexandre Belloni
2020-06-22 21:24 ` Ahmad Fatoum
2020-06-22 21:47 ` Alexandre Belloni
2020-07-03 7:34 ` Ahmad Fatoum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=043970b9-6cc6-e5c6-b5b1-e0f1a9799ae1@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=alexandre.belloni@bootlin.com \
--cc=karl@micro-technic.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).