From: Stephen Boyd <sboyd@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Mike Looijmans <mike.looijmans@topic.nl>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org
Cc: Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: clock: fixed-clock: Add nvmem support
Date: Thu, 08 Jun 2023 16:19:57 -0700 [thread overview]
Message-ID: <0447c70d63e13d239bdda839e966bd89.sboyd@kernel.org> (raw)
In-Reply-To: <96004048-0ba5-4cd6-406f-e1235c819c97@topic.nl>
Quoting Mike Looijmans (2023-06-05 07:00:16)
> On 05-06-2023 15:38, Krzysztof Kozlowski wrote:
> > On 05/06/2023 15:34, Mike Looijmans wrote:
> >> diff --git a/Documentation/devicetree/bindings/clock/fixed-clock.yaml b/Documentation/devicetree/bindings/clock/fixed-clock.yaml
> >> index b0a4fb8256e2..23e4df96d3b0 100644
> >> --- a/Documentation/devicetree/bindings/clock/fixed-clock.yaml
> >> +++ b/Documentation/devicetree/bindings/clock/fixed-clock.yaml
> >> @@ -12,7 +12,9 @@ maintainers:
> >>
> >> properties:
> >> compatible:
> >> - const: fixed-clock
> >> + enum:
> >> + - fixed-clock
> >> + - fixed-clock-nvmem
> > Do you even need new compatible? Isn't this the same clock from the
> > hardware point of view?
>
> I need a new compatible because a "fixed-clock" only loads at init time.
> It registers using CLK_OF_DECLARE, which requires the clock to register
> early. NVMEM providers are typical devices like I2C EEPROMs that won't
> be available at that point, hence I needed to create a clock that
> registers as a regular clock driver and can handle deferral and similar.
What is builtin_platform_driver(of_fixed_clk_driver)?
prev parent reply other threads:[~2023-06-08 23:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.1d0217a8-661f-4359-b77b-02222c761b01@emailsignatures365.codetwo.com>
2023-06-05 13:34 ` [PATCH v3 1/2] dt-bindings: clock: fixed-clock: Add nvmem support Mike Looijmans
[not found] ` <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.bc47089e-a980-4211-bad3-8966176cf36c@emailsignatures365.codetwo.com>
2023-06-05 13:34 ` [PATCH v3 2/2] clk: Add fixed-clock-nvmem provider Mike Looijmans
2023-06-05 13:38 ` [PATCH v3 1/2] dt-bindings: clock: fixed-clock: Add nvmem support Krzysztof Kozlowski
2023-06-05 14:00 ` Mike Looijmans
2023-06-05 14:05 ` Krzysztof Kozlowski
2023-06-08 23:19 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0447c70d63e13d239bdda839e966bd89.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).