From: Katsuhiro Suzuki <katsuhiro@katsuster.net>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: fractional-divider: check parent rate only for general approximation
Date: Sat, 26 Jan 2019 20:13:48 +0900 [thread overview]
Message-ID: <063dea80-a13e-3af2-1008-1c0c2bbe2706@katsuster.net> (raw)
In-Reply-To: <20190107132124.27788-1-katsuhiro@katsuster.net>
Ping...
On 2019/01/07 22:21, Katsuhiro Suzuki wrote:
> Custom approximation of fractional-divider may not need parent clock
> rate checking. For example Rockchip SoCs work fine using grand parent
> clock rate evne if target rate is greater than parent.
>
> This patch removes parent clock rate check from custom approximation.
>
> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
> ---
> drivers/clk/clk-fractional-divider.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/clk-fractional-divider.c b/drivers/clk/clk-fractional-divider.c
> index 545dceec0bbf..b0fc5509e0ff 100644
> --- a/drivers/clk/clk-fractional-divider.c
> +++ b/drivers/clk/clk-fractional-divider.c
> @@ -79,13 +79,17 @@ static long clk_fd_round_rate(struct clk_hw *hw, unsigned long rate,
> unsigned long m, n;
> u64 ret;
>
> - if (!rate || rate >= *parent_rate)
> + if (!rate)
> return *parent_rate;
>
> - if (fd->approximation)
> + if (fd->approximation) {
> fd->approximation(hw, rate, parent_rate, &m, &n);
> - else
> + } else {
> + if (rate >= *parent_rate)
> + return *parent_rate;
> +
> clk_fd_general_approximation(hw, rate, parent_rate, &m, &n);
> + }
>
> ret = (u64)*parent_rate * m;
> do_div(ret, n);
>
next prev parent reply other threads:[~2019-01-26 11:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 13:21 [PATCH] clk: fractional-divider: check parent rate only for general approximation Katsuhiro Suzuki
2019-01-26 11:13 ` Katsuhiro Suzuki [this message]
2019-01-29 21:55 ` Stephen Boyd
2019-01-30 23:44 ` Katsuhiro Suzuki
2019-01-30 23:50 Katsuhiro Suzuki
2019-02-06 19:40 ` Stephen Boyd
2019-02-10 15:41 ` Katsuhiro Suzuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=063dea80-a13e-3af2-1008-1c0c2bbe2706@katsuster.net \
--to=katsuhiro@katsuster.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).