From: Zhou Yanjie <zhouyanjie@wanyeetech.com>
To: Stephen Boyd <sboyd@kernel.org>, linux-clk@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
mturquette@baylibre.com, robh+dt@kernel.org,
dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com,
sernia.zhou@foxmail.com, zhenwenjin@gmail.com,
paul@crapouillou.net
Subject: Re: [PATCH v10 3/6] dt-bindings: clock: Add X1830 bindings.
Date: Thu, 28 May 2020 01:54:02 +0800 [thread overview]
Message-ID: <08fe6e46-99d3-c66c-4f60-adf87f1b8edf@wanyeetech.com> (raw)
In-Reply-To: <159056716225.88029.7227987261941853085@swboyd.mtv.corp.google.com>
Hi Stephen,
I'm very sorry, forgive my carelessness, communication with Paul
Cercueil made me realize that the modification of
"CLK_OF_DECLARE_DRIVER" mentioned in comments of [7/7] has never really
existed in the patch, v12 has fixed this problem, and split the patch
about bindings according to your requirements, it may be a good idea to
retake [4/7] and [7/7] of v12.
Thanks and best regards!
在 2020/5/27 下午4:12, Stephen Boyd 写道:
> Quoting 周琰杰 (Zhou Yanjie) (2020-05-26 07:40:41)
>> Add the clock bindings for the X1830 Soc from Ingenic.
>>
>> Signed-off-by: \u5468\u7430\u6770 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
>>
>> Notes:
>> v2->v3:
>> Adjust order from [3/5] in v2 to [4/5] in v3.
>>
>> v3->v4:
>> Adjust order from [4/5] in v3 to [3/4] in v4.
>>
>> v4->v5:
>> Rebase on top of kernel 5.6-rc1.
>>
>> v5->v6:
>> Add missing part of X1830's CGU.
>>
>> v6->v7:
>> No change.
>>
>> v7->v8:
>> Rebase on top of linux-next.
>>
>> v8->v9:
>> No change.
>>
>> v9->v10:
>> Add missing "X1830_CLK_TCU".
>>
>> .../devicetree/bindings/clock/ingenic,cgu.yaml | 2 +
>> include/dt-bindings/clock/x1830-cgu.h | 55 ++++++++++++++++++++++
>> 2 files changed, 57 insertions(+)
>> create mode 100644 include/dt-bindings/clock/x1830-cgu.h
>>
>> diff --git a/Documentation/devicetree/bindings/clock/ingenic,cgu.yaml b/Documentation/devicetree/bindings/clock/ingenic,cgu.yaml
> This file is in Rob's DT tree staged for the next release, not in the
> clk tree. Can you split this patch into two, one for the compatible
> update and another for the header file update and send again? Then Rob
> can pick up the yaml file change and I can pick up the header file
> change.
>
>> index 0281cd1d7e1b..a952d5811823 100644
>> --- a/Documentation/devicetree/bindings/clock/ingenic,cgu.yaml
>> +++ b/Documentation/devicetree/bindings/clock/ingenic,cgu.yaml
>> @@ -25,6 +25,7 @@ select:
>> - ingenic,jz4770-cgu
>> - ingenic,jz4780-cgu
>> - ingenic,x1000-cgu
>> + - ingenic,x1830-cgu
>> required:
>> - compatible
>>
>> @@ -51,6 +52,7 @@ properties:
>> - ingenic,jz4770-cgu
>> - ingenic,jz4780-cgu
>> - ingenic,x1000-cgu
>> + - ingenic,x1830-cgu
>> - const: simple-mfd
>> minItems: 1
>>
next prev parent reply other threads:[~2020-05-27 17:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 14:40 Add support for the X1830 and fix bugs for X1000 v10 周琰杰 (Zhou Yanjie)
2020-05-26 14:40 ` [PATCH v10 0/6] Add support for the X1830 and fix bugs for X1000 周琰杰 (Zhou Yanjie)
2020-05-26 14:40 ` [PATCH v10 1/6] clk: Ingenic: Remove unnecessary spinlock when reading registers 周琰杰 (Zhou Yanjie)
2020-05-26 14:40 ` [PATCH v10 2/6] clk: Ingenic: Adjust cgu code to make it compatible with X1830 周琰杰 (Zhou Yanjie)
2020-05-26 14:40 ` [PATCH v10 3/6] dt-bindings: clock: Add X1830 bindings 周琰杰 (Zhou Yanjie)
2020-05-27 0:54 ` Rob Herring
[not found] ` <159056716225.88029.7227987261941853085@swboyd.mtv.corp.google.com>
2020-05-27 8:27 ` Zhou Yanjie
2020-05-27 14:13 ` Zhou Yanjie
2020-05-27 17:54 ` Zhou Yanjie [this message]
2020-05-26 14:40 ` [PATCH v10 4/6] clk: Ingenic: Add CGU driver for X1830 周琰杰 (Zhou Yanjie)
2020-05-26 14:40 ` [PATCH v10 5/6] dt-bindings: clock: Add and reorder ABI for X1000 周琰杰 (Zhou Yanjie)
2020-05-26 14:40 ` [PATCH v10 6/6] clk: X1000: Add FIXDIV for SSI clock of X1000 周琰杰 (Zhou Yanjie)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08fe6e46-99d3-c66c-4f60-adf87f1b8edf@wanyeetech.com \
--to=zhouyanjie@wanyeetech.com \
--cc=aric.pzqi@ingenic.com \
--cc=devicetree@vger.kernel.org \
--cc=dongsheng.qiu@ingenic.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sernia.zhou@foxmail.com \
--cc=zhenwenjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).