Re: [PATCH v2 6/7] gxbb: clk: Move MESON_GATE macro to gxbb

["Alexander Müller" <serveralex@gmail.com>]

Hi Mike,=20

What about the clk name set by the macro MESON_GATE (#_name)? That would =
change too and I guess that's not desired here.

Regards,=20
Alex

> On 13 Jul 2016, at 23:32, Michael Turquette <mturquette@baylibre.com> =
wrote:
>=20
> Hi Alexander,
>=20
> Quoting Alexander M=C3=BCller (2016-07-13 10:49:40)
>> Signed-off-by: Alexander M=C3=BCller <serveralex@gmail.com>
>> ---
>> drivers/clk/meson/clkc.h |  14 ----
>> drivers/clk/meson/gxbb.c | 176 =
+++++++++++++++++++++++++----------------------
>> 2 files changed, 95 insertions(+), 95 deletions(-)
>>=20
>> diff --git a/drivers/clk/meson/clkc.h b/drivers/clk/meson/clkc.h
>> index 53326c3..061a01e 100644
>> --- a/drivers/clk/meson/clkc.h
>> +++ b/drivers/clk/meson/clkc.h
>> @@ -97,20 +97,6 @@ struct meson_clk_mpll {
>>        spinlock_t *lock;
>> };
>>=20
>> -#define MESON_GATE(_name, _reg, _bit)                                =
  \
>> -struct clk_gate gxbb_##_name =3D {                                   =
            \
>=20
> Please leave this macro in clkc.h, but change the above line to:
>=20
> 	#define MESON_GATE(_name, _reg, _bit)	\
> 	struct clk_gate _name =3D {		\
>=20
> Note that gxbb_##_name is replaced with _name. I should have done it
> like this from the beginning but it's a bit of a brain fart.
>=20
>> /* Everything Else (EE) domain gates */
>> -static MESON_GATE(ddr, HHI_GCLK_MPEG0, 0);
>=20
> Then reflow the above gxbb gate clock like so:
>=20
> 	static MESON_GATE(gxbb_ddr, HHI_GCLK_MPEG0, 0);
>=20
> Then you can re-use the same macro in your meson8b driver by prefixing
> all of your gate clocks with "meson8b_".
>=20
> Regards,
> Mike