From: Randy Dunlap <rdunlap@infradead.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
robh+dt@kernel.org, mark.rutland@arm.com, ck.hu@mediatek.com,
p.zabel@pengutronix.de, airlied@linux.ie,
mturquette@baylibre.com, sboyd@kernel.org,
ulrich.hecht+renesas@gmail.com,
laurent.pinchart@ideasonboard.com
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
dri-devel@lists.freedesktop.org, Weiyi Lu <weiyi.lu@mediatek.com>,
Seiya Wang <seiya.wang@mediatek.com>,
linux-clk@vger.kernel.org,
Collabora Kernel ML <kernel@collabora.com>,
mtk01761 <wendell.lin@mediatek.com>,
Allison Randal <allison@lohutok.net>,
Thomas Gleixner <tglx@linutronix.de>,
wens@csie.org, Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Houlong Wei <houlong.wei@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
sean.wang@mediatek.com, frank-w@public-files.de,
Minghsiu Tsai <minghsiu.tsai@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
linux-mediatek@lists.infradead.org, hsinyi@chromium.org,
Matthias Brugger <mbrugger@suse.com>,
linux-arm-kernel@lists.infradead.org,
Richard Fontana <rfontana@redhat.com>,
linux-kernel@vger.kernel.org, matthias.bgg@kernel.org,
Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v8 1/6] drm/mediatek: Use regmap for register access
Date: Thu, 20 Feb 2020 15:48:12 -0800 [thread overview]
Message-ID: <0b2046b9-90de-c894-7502-993b5df12e7a@infradead.org> (raw)
In-Reply-To: <20200220172147.919996-2-enric.balletbo@collabora.com>
On 2/20/20 9:21 AM, Enric Balletbo i Serra wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> The mmsys memory space is shared between the drm and the
> clk driver. Use regmap to access it.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
> Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> Changes in v8: None
> Changes in v7:
> - Add R-by from CK
>
> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 +-
> drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 50 +++++++++++--------------
> drivers/gpu/drm/mediatek/mtk_drm_ddp.h | 4 +-
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 13 ++-----
> drivers/gpu/drm/mediatek/mtk_drm_drv.h | 2 +-
> 5 files changed, 30 insertions(+), 43 deletions(-)
Hi. Just a quick question:
Do you need to select REGMAP or one of its derivatives to make sure
that the proper interfaces are available for this driver?
thanks.
--
~Randy
next prev parent reply other threads:[~2020-02-20 23:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 17:21 [PATCH v8 0/6] arm/arm64: mediatek: Fix mmsys device probing Enric Balletbo i Serra
2020-02-20 17:21 ` [PATCH v8 1/6] drm/mediatek: Use regmap for register access Enric Balletbo i Serra
2020-02-20 23:48 ` Randy Dunlap [this message]
2020-02-21 7:46 ` Enric Balletbo i Serra
2020-02-20 17:21 ` [PATCH v8 2/6] drm/mediatek: Omit warning on probe defers Enric Balletbo i Serra
2020-02-20 17:21 ` [PATCH v8 3/6] media: mtk-mdp: Check return value of of_clk_get Enric Balletbo i Serra
2020-02-20 17:21 ` [PATCH v8 4/6] clk: mediatek: mt8173: Switch MMSYS to platform driver Enric Balletbo i Serra
2020-02-20 17:21 ` [PATCH v8 5/6] drm/mediatek: Move MMSYS configuration to include/linux/platform_data Enric Balletbo i Serra
2020-02-20 17:21 ` [PATCH v8 6/6] clk/drm: mediatek: Fix mediatek-drm device probing Enric Balletbo i Serra
2020-02-21 5:18 ` CK Hu
2020-02-21 7:51 ` Enric Balletbo i Serra
2020-02-21 4:39 ` [PATCH v8 0/6] arm/arm64: mediatek: Fix mmsys " CK Hu
2020-02-21 8:56 ` Enric Balletbo i Serra
2020-02-21 9:27 ` CK Hu
2020-02-21 10:24 ` Matthias Brugger
2020-02-21 11:11 ` CK Hu
2020-02-21 11:37 ` Enric Balletbo i Serra
2020-02-21 11:53 ` Matthias Brugger
2020-02-21 17:10 ` Enric Balletbo i Serra
2020-02-24 5:52 ` CK Hu
2020-02-25 10:56 ` Enric Balletbo i Serra
2020-02-26 5:32 ` CK Hu
2020-02-26 9:24 ` Enric Balletbo i Serra
2020-02-21 10:20 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b2046b9-90de-c894-7502-993b5df12e7a@infradead.org \
--to=rdunlap@infradead.org \
--cc=airlied@linux.ie \
--cc=allison@lohutok.net \
--cc=andrew-ct.chen@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=frank-w@public-files.de \
--cc=gregkh@linuxfoundation.org \
--cc=houlong.wei@mediatek.com \
--cc=hsinyi@chromium.org \
--cc=kernel@collabora.com \
--cc=kstewart@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=matthias.bgg@kernel.org \
--cc=mbrugger@suse.com \
--cc=mchehab@kernel.org \
--cc=minghsiu.tsai@mediatek.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=rfontana@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=seiya.wang@mediatek.com \
--cc=tglx@linutronix.de \
--cc=ulrich.hecht+renesas@gmail.com \
--cc=weiyi.lu@mediatek.com \
--cc=wendell.lin@mediatek.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).