* Re: [PATCH v2] clk: qcom: msm8916: Don't build by default
2019-06-13 15:09 [PATCH v2] clk: qcom: msm8916: Don't build by default Marc Gonzalez
@ 2019-06-13 15:38 ` Bjorn Andersson
2019-06-14 14:08 ` Georgi Djakov
` (2 subsequent siblings)
3 siblings, 0 replies; 11+ messages in thread
From: Bjorn Andersson @ 2019-06-13 15:38 UTC (permalink / raw)
To: Marc Gonzalez
Cc: Stephen Boyd, Michael Turquette, linux-clk, MSM, Georgi Djakov,
Amit Kucheria
On Thu 13 Jun 08:09 PDT 2019, Marc Gonzalez wrote:
> QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 stand out as the only options
> built by default. Let's bring them back in line with the rest.
>
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
This looks reasonable
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> Changes from v1:
> - Drop the default altogether, instead of changing it to 'default MSM_GCC_8916'
> ---
> drivers/clk/qcom/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index e1ff83cc361e..6461a1aa7325 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -21,7 +21,6 @@ if COMMON_CLK_QCOM
>
> config QCOM_A53PLL
> tristate "MSM8916 A53 PLL"
> - default ARCH_QCOM
> help
> Support for the A53 PLL on MSM8916 devices. It provides
> the CPU with frequencies above 1GHz.
> @@ -31,7 +30,6 @@ config QCOM_A53PLL
> config QCOM_CLK_APCS_MSM8916
> tristate "MSM8916 APCS Clock Controller"
> depends on QCOM_APCS_IPC || COMPILE_TEST
> - default ARCH_QCOM
> help
> Support for the APCS Clock Controller on msm8916 devices. The
> APCS is managing the mux and divider which feeds the CPUs.
> --
> 2.17.1
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2] clk: qcom: msm8916: Don't build by default
2019-06-13 15:09 [PATCH v2] clk: qcom: msm8916: Don't build by default Marc Gonzalez
2019-06-13 15:38 ` Bjorn Andersson
@ 2019-06-14 14:08 ` Georgi Djakov
2019-06-24 12:25 ` Georgi Djakov
2019-08-08 4:30 ` [PATCH v2] clk: qcom: msm8916: Don't build by default Stephen Boyd
3 siblings, 0 replies; 11+ messages in thread
From: Georgi Djakov @ 2019-06-14 14:08 UTC (permalink / raw)
To: Marc Gonzalez, Stephen Boyd, Michael Turquette
Cc: linux-clk, MSM, Amit Kucheria, Bjorn Andersson
On 6/13/19 18:09, Marc Gonzalez wrote:
> QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 stand out as the only options
> built by default. Let's bring them back in line with the rest.
>
This change looks fine, but maybe we should enable these in defconfig?
Thanks,
Georgi
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> ---
> Changes from v1:
> - Drop the default altogether, instead of changing it to 'default MSM_GCC_8916'
> ---
> drivers/clk/qcom/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index e1ff83cc361e..6461a1aa7325 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -21,7 +21,6 @@ if COMMON_CLK_QCOM
>
> config QCOM_A53PLL
> tristate "MSM8916 A53 PLL"
> - default ARCH_QCOM
> help
> Support for the A53 PLL on MSM8916 devices. It provides
> the CPU with frequencies above 1GHz.
> @@ -31,7 +30,6 @@ config QCOM_A53PLL
> config QCOM_CLK_APCS_MSM8916
> tristate "MSM8916 APCS Clock Controller"
> depends on QCOM_APCS_IPC || COMPILE_TEST
> - default ARCH_QCOM
> help
> Support for the APCS Clock Controller on msm8916 devices. The
> APCS is managing the mux and divider which feeds the CPUs.
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] clk: qcom: msm8916: Don't build by default
2019-06-13 15:09 [PATCH v2] clk: qcom: msm8916: Don't build by default Marc Gonzalez
2019-06-13 15:38 ` Bjorn Andersson
2019-06-14 14:08 ` Georgi Djakov
@ 2019-06-24 12:25 ` Georgi Djakov
2019-06-24 13:26 ` [PATCH] clk: qcom: msm8916: Add 2 clk options in defconfig Marc Gonzalez
2019-08-08 4:30 ` [PATCH v2] clk: qcom: msm8916: Don't build by default Stephen Boyd
3 siblings, 1 reply; 11+ messages in thread
From: Georgi Djakov @ 2019-06-24 12:25 UTC (permalink / raw)
To: Marc Gonzalez, Stephen Boyd, Michael Turquette
Cc: linux-clk, MSM, Amit Kucheria, Bjorn Andersson
On 6/13/19 18:09, Marc Gonzalez wrote:
> QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 stand out as the only options
> built by default. Let's bring them back in line with the rest.
>
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
Acked-by: Georgi Djakov <georgi.djakov@linaro.org>
In order to keep it functional, a separate patch is needed to enable the same
config options in defconfig. The defconfig change should go through Andy and Bjorn.
Thanks,
Georgi
> ---
> Changes from v1:
> - Drop the default altogether, instead of changing it to 'default MSM_GCC_8916'
> ---
> drivers/clk/qcom/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index e1ff83cc361e..6461a1aa7325 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -21,7 +21,6 @@ if COMMON_CLK_QCOM
>
> config QCOM_A53PLL
> tristate "MSM8916 A53 PLL"
> - default ARCH_QCOM
> help
> Support for the A53 PLL on MSM8916 devices. It provides
> the CPU with frequencies above 1GHz.
> @@ -31,7 +30,6 @@ config QCOM_A53PLL
> config QCOM_CLK_APCS_MSM8916
> tristate "MSM8916 APCS Clock Controller"
> depends on QCOM_APCS_IPC || COMPILE_TEST
> - default ARCH_QCOM
> help
> Support for the APCS Clock Controller on msm8916 devices. The
> APCS is managing the mux and divider which feeds the CPUs.
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] clk: qcom: msm8916: Add 2 clk options in defconfig
2019-06-24 12:25 ` Georgi Djakov
@ 2019-06-24 13:26 ` Marc Gonzalez
2019-06-24 13:57 ` Amit Kucheria
0 siblings, 1 reply; 11+ messages in thread
From: Marc Gonzalez @ 2019-06-24 13:26 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross
Cc: Georgi Djakov, Stephen Boyd, linux-clk, MSM, Amit Kucheria
QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 used to be enabled by default
in drivers/clk/qcom/Kconfig. A recent patch changed that by dropping
the 'default ARCH_QCOM' directive.
Add the two options explicitly in the arm64 defconfig, to avoid
functional regressions.
Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
---
Bjorn, Andy, I believe you can take this patch through the qcom tree,
once Stephen takes the parent patch.
---
arch/arm64/configs/defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 5a8e853833cf..3277944626c2 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -658,6 +658,8 @@ CONFIG_CLK_IMX8MQ=y
CONFIG_CLK_IMX8QXP=y
CONFIG_TI_SCI_CLK=y
CONFIG_COMMON_CLK_QCOM=y
+CONFIG_QCOM_A53PLL=y
+CONFIG_QCOM_CLK_APCS_MSM8916=y
CONFIG_QCOM_CLK_SMD_RPM=y
CONFIG_QCOM_CLK_RPMH=y
CONFIG_IPQ_GCC_8074=y
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] clk: qcom: msm8916: Add 2 clk options in defconfig
2019-06-24 13:26 ` [PATCH] clk: qcom: msm8916: Add 2 clk options in defconfig Marc Gonzalez
@ 2019-06-24 13:57 ` Amit Kucheria
2019-07-03 14:00 ` Marc Gonzalez
0 siblings, 1 reply; 11+ messages in thread
From: Amit Kucheria @ 2019-06-24 13:57 UTC (permalink / raw)
To: Marc Gonzalez
Cc: Bjorn Andersson, Andy Gross, Georgi Djakov, Stephen Boyd, linux-clk, MSM
On Mon, Jun 24, 2019 at 6:56 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote:
>
> QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 used to be enabled by default
> in drivers/clk/qcom/Kconfig. A recent patch changed that by dropping
> the 'default ARCH_QCOM' directive.
>
> Add the two options explicitly in the arm64 defconfig, to avoid
> functional regressions.
>
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
Acked-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> Bjorn, Andy, I believe you can take this patch through the qcom tree,
> once Stephen takes the parent patch.
> ---
> arch/arm64/configs/defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 5a8e853833cf..3277944626c2 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -658,6 +658,8 @@ CONFIG_CLK_IMX8MQ=y
> CONFIG_CLK_IMX8QXP=y
> CONFIG_TI_SCI_CLK=y
> CONFIG_COMMON_CLK_QCOM=y
> +CONFIG_QCOM_A53PLL=y
> +CONFIG_QCOM_CLK_APCS_MSM8916=y
> CONFIG_QCOM_CLK_SMD_RPM=y
> CONFIG_QCOM_CLK_RPMH=y
> CONFIG_IPQ_GCC_8074=y
> --
> 2.17.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] clk: qcom: msm8916: Add 2 clk options in defconfig
2019-06-24 13:57 ` Amit Kucheria
@ 2019-07-03 14:00 ` Marc Gonzalez
2019-08-08 4:29 ` Stephen Boyd
0 siblings, 1 reply; 11+ messages in thread
From: Marc Gonzalez @ 2019-07-03 14:00 UTC (permalink / raw)
To: Stephen Boyd
Cc: Amit Kucheria, Bjorn Andersson, Andy Gross, Georgi Djakov,
linux-clk, MSM
On 24/06/2019 15:57, Amit Kucheria wrote:
> On Mon, Jun 24, 2019 at 6:56 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote:
>>
>> QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 used to be enabled by default
>> in drivers/clk/qcom/Kconfig. A recent patch changed that by dropping
>> the 'default ARCH_QCOM' directive.
>>
>> Add the two options explicitly in the arm64 defconfig, to avoid
>> functional regressions.
>>
>> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
>
> Acked-by: Amit Kucheria <amit.kucheria@linaro.org>
Stephen,
Can you take the following two patches through the clk tree?
[PATCH v2] clk: qcom: msm8916: Don't build by default
[PATCH] clk: qcom: msm8916: Add 2 clk options in defconfig
Regards.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] clk: qcom: msm8916: Add 2 clk options in defconfig
2019-07-03 14:00 ` Marc Gonzalez
@ 2019-08-08 4:29 ` Stephen Boyd
2019-08-27 14:48 ` Niklas Cassel
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Boyd @ 2019-08-08 4:29 UTC (permalink / raw)
To: Marc Gonzalez
Cc: Amit Kucheria, Bjorn Andersson, Andy Gross, Georgi Djakov,
linux-clk, MSM
Quoting Marc Gonzalez (2019-07-03 07:00:31)
> On 24/06/2019 15:57, Amit Kucheria wrote:
>
> > On Mon, Jun 24, 2019 at 6:56 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote:
> >>
> >> QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 used to be enabled by default
> >> in drivers/clk/qcom/Kconfig. A recent patch changed that by dropping
> >> the 'default ARCH_QCOM' directive.
> >>
> >> Add the two options explicitly in the arm64 defconfig, to avoid
> >> functional regressions.
> >>
> >> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> >
> > Acked-by: Amit Kucheria <amit.kucheria@linaro.org>
>
> Stephen,
>
> Can you take the following two patches through the clk tree?
>
> [PATCH v2] clk: qcom: msm8916: Don't build by default
> [PATCH] clk: qcom: msm8916: Add 2 clk options in defconfig
>
Did Andy pick up this defconfig change? The subject is misleading.
defconfig changes should be something like
arm64: defconfig: Add qcom clk options
I don't think I need to pick up the defconfig change. It can go through
Andy and arm-soc. So I'll just grab the first one and guess it won't
break much on the way in.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] clk: qcom: msm8916: Add 2 clk options in defconfig
2019-08-08 4:29 ` Stephen Boyd
@ 2019-08-27 14:48 ` Niklas Cassel
2019-08-27 16:52 ` Bjorn Andersson
0 siblings, 1 reply; 11+ messages in thread
From: Niklas Cassel @ 2019-08-27 14:48 UTC (permalink / raw)
To: Stephen Boyd
Cc: Marc Gonzalez, Amit Kucheria, Bjorn Andersson, Andy Gross,
Georgi Djakov, linux-clk, MSM
On Wed, Aug 07, 2019 at 09:29:24PM -0700, Stephen Boyd wrote:
> Quoting Marc Gonzalez (2019-07-03 07:00:31)
> > On 24/06/2019 15:57, Amit Kucheria wrote:
> >
> > > On Mon, Jun 24, 2019 at 6:56 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote:
> > >>
> > >> QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 used to be enabled by default
> > >> in drivers/clk/qcom/Kconfig. A recent patch changed that by dropping
> > >> the 'default ARCH_QCOM' directive.
> > >>
> > >> Add the two options explicitly in the arm64 defconfig, to avoid
> > >> functional regressions.
> > >>
> > >> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> > >
> > > Acked-by: Amit Kucheria <amit.kucheria@linaro.org>
> >
> > Stephen,
> >
> > Can you take the following two patches through the clk tree?
> >
> > [PATCH v2] clk: qcom: msm8916: Don't build by default
> > [PATCH] clk: qcom: msm8916: Add 2 clk options in defconfig
> >
>
> Did Andy pick up this defconfig change? The subject is misleading.
> defconfig changes should be something like
Neither Andy nor Bjorn has picked this.
Could you please pick it up? (possibly with subject fixed up)
>
> arm64: defconfig: Add qcom clk options
>
> I don't think I need to pick up the defconfig change. It can go through
> Andy and arm-soc. So I'll just grab the first one and guess it won't
> break much on the way in.
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] clk: qcom: msm8916: Add 2 clk options in defconfig
2019-08-27 14:48 ` Niklas Cassel
@ 2019-08-27 16:52 ` Bjorn Andersson
0 siblings, 0 replies; 11+ messages in thread
From: Bjorn Andersson @ 2019-08-27 16:52 UTC (permalink / raw)
To: Niklas Cassel
Cc: Stephen Boyd, Marc Gonzalez, Amit Kucheria, Andy Gross,
Georgi Djakov, linux-clk, MSM
On Tue 27 Aug 07:48 PDT 2019, Niklas Cassel wrote:
> On Wed, Aug 07, 2019 at 09:29:24PM -0700, Stephen Boyd wrote:
> > Quoting Marc Gonzalez (2019-07-03 07:00:31)
> > > On 24/06/2019 15:57, Amit Kucheria wrote:
> > >
> > > > On Mon, Jun 24, 2019 at 6:56 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote:
> > > >>
> > > >> QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 used to be enabled by default
> > > >> in drivers/clk/qcom/Kconfig. A recent patch changed that by dropping
> > > >> the 'default ARCH_QCOM' directive.
> > > >>
> > > >> Add the two options explicitly in the arm64 defconfig, to avoid
> > > >> functional regressions.
> > > >>
> > > >> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> > > >
> > > > Acked-by: Amit Kucheria <amit.kucheria@linaro.org>
> > >
> > > Stephen,
> > >
> > > Can you take the following two patches through the clk tree?
> > >
> > > [PATCH v2] clk: qcom: msm8916: Don't build by default
> > > [PATCH] clk: qcom: msm8916: Add 2 clk options in defconfig
> > >
> >
> > Did Andy pick up this defconfig change? The subject is misleading.
> > defconfig changes should be something like
>
> Neither Andy nor Bjorn has picked this.
>
> Could you please pick it up? (possibly with subject fixed up)
>
Picked up and updated the subject.
Thanks Marc!
Regards,
Bjorn
> >
> > arm64: defconfig: Add qcom clk options
> >
> > I don't think I need to pick up the defconfig change. It can go through
> > Andy and arm-soc. So I'll just grab the first one and guess it won't
> > break much on the way in.
> >
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] clk: qcom: msm8916: Don't build by default
2019-06-13 15:09 [PATCH v2] clk: qcom: msm8916: Don't build by default Marc Gonzalez
` (2 preceding siblings ...)
2019-06-24 12:25 ` Georgi Djakov
@ 2019-08-08 4:30 ` Stephen Boyd
3 siblings, 0 replies; 11+ messages in thread
From: Stephen Boyd @ 2019-08-08 4:30 UTC (permalink / raw)
To: Marc Gonzalez, Michael Turquette
Cc: linux-clk, MSM, Georgi Djakov, Amit Kucheria, Bjorn Andersson
Quoting Marc Gonzalez (2019-06-13 08:09:34)
> QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 stand out as the only options
> built by default. Let's bring them back in line with the rest.
>
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 11+ messages in thread