From: Michael Turquette <mturquette@baylibre.com>
To: Andi Shyti <andi.shyti@samsung.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Kukjin Kim" <kgene@kernel.org>,
"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
"Mark Brown" <broonie@kernel.org>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Tomasz Figa" <tomasz.figa@gmail.com>,
"Stephen Boyd" <sboyd@codeaurora.org>
Cc: "Chanwoo Choi" <cw00.choi@samsung.com>,
"Jaehoon Chung" <jh80.chung@samsung.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org,
"Andi Shyti" <andi.shyti@samsung.com>,
"Andi Shyti" <andi@etezian.org>
Subject: Re: [PATCH v2 5/7] spi: s3c64xx: add exynos5433 compatible for ioclk handling
Date: Fri, 08 Jul 2016 09:13:32 -0700 [thread overview]
Message-ID: <146799441227.73491.13833003558807352160@resonance> (raw)
In-Reply-To: <1467989201-14661-6-git-send-email-andi.shyti@samsung.com>
Quoting Andi Shyti (2016-07-08 07:46:39)
> @@ -1147,6 +1150,21 @@ static int s3c64xx_spi_probe(struct platform_devic=
e *pdev)
> goto err_disable_clk;
> }
> =
> + if (sdd->port_conf->clk_ioclk) {
> + sdd->ioclk =3D devm_clk_get(&pdev->dev, "spi_ioclk");
> + if (IS_ERR(sdd->ioclk)) {
> + dev_err(&pdev->dev, "Unable to acquire 'ioclk'\n"=
);
> + ret =3D PTR_ERR(sdd->ioclk);
> + goto err_disable_src_clk;
> + }
> +
> + ret =3D clk_prepare_enable(sdd->ioclk);
> + if (ret) {
> + dev_err(&pdev->dev, "Couldn't enable clock 'ioclk=
'\n");
> + goto err_disable_src_clk;
> + }
> + }
> +
> pm_runtime_set_autosuspend_delay(&pdev->dev, AUTOSUSPEND_TIMEOUT);
> pm_runtime_use_autosuspend(&pdev->dev);
> pm_runtime_set_active(&pdev->dev);
> @@ -1193,6 +1211,8 @@ err_pm_put:
> pm_runtime_disable(&pdev->dev);
> pm_runtime_set_suspended(&pdev->dev);
> =
> + clk_disable_unprepare(sdd->ioclk);
> +err_disable_src_clk:
> clk_disable_unprepare(sdd->src_clk);
> err_disable_clk:
> clk_disable_unprepare(sdd->clk);
Why aren't these clocks enabled/disabled by calls to pm_runtime_get/put?
Regards,
Mike
next prev parent reply other threads:[~2016-07-08 16:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 14:46 [PATCH v2 0/7] spi s3c64xx ioclk handling Andi Shyti
2016-07-08 14:46 ` [PATCH v2 1/7] bindings: spi-samsung: add exynos5433 spi compatible Andi Shyti
2016-07-08 20:23 ` Krzysztof Kozlowski
2016-07-11 10:49 ` Sylwester Nawrocki
2016-07-14 16:33 ` Applied "spi: s3c64xx: add exynos5433 spi compatible" to the spi tree Mark Brown
2016-07-08 14:46 ` [PATCH v2 2/7] bindings: spi-samsung: document the clocks and the clock-name property Andi Shyti
2016-07-08 20:32 ` Krzysztof Kozlowski
2016-07-11 2:36 ` [PATCH v3] " Andi Shyti
2016-07-14 16:32 ` Applied "spi: s3c64xx: document the clocks and the clock-name property" to the spi tree Mark Brown
2016-07-08 14:46 ` [PATCH v2 3/7] spi: s3c64xx: rename goto labels to meaningful names Andi Shyti
2016-07-14 16:32 ` Applied "spi: s3c64xx: rename goto labels to meaningful names" to the spi tree Mark Brown
2016-07-08 14:46 ` [PATCH v2 4/7] spi: s3c64xx: use error code from clk_prepare_enable() Andi Shyti
2016-07-08 20:33 ` Krzysztof Kozlowski
2016-07-14 16:32 ` Applied "spi: s3c64xx: use error code from clk_prepare_enable()" to the spi tree Mark Brown
2016-07-08 14:46 ` [PATCH v2 5/7] spi: s3c64xx: add exynos5433 compatible for ioclk handling Andi Shyti
2016-07-08 16:13 ` Michael Turquette [this message]
2016-07-08 16:31 ` Andi Shyti
2016-07-08 20:39 ` Krzysztof Kozlowski
2016-07-14 16:32 ` Applied "spi: s3c64xx: add Exynos5433 compatible for ioclk handling" to the spi tree Mark Brown
2016-07-08 14:46 ` [PATCH v2 6/7] spi: s3c64xx: restore removed comments Andi Shyti
2016-07-08 16:17 ` Michael Turquette
2016-07-08 16:35 ` Andi Shyti
2016-07-11 10:33 ` Sylwester Nawrocki
2016-07-11 22:17 ` Michael Turquette
2016-07-12 12:16 ` Sylwester Nawrocki
2016-07-12 6:54 ` [PATCH v3 " Andi Shyti
2016-07-12 8:22 ` Mark Brown
2016-07-12 8:25 ` Andi Shyti
2016-07-12 9:00 ` Mark Brown
2016-07-12 18:07 ` Michael Turquette
2016-07-14 16:32 ` Applied "spi: s3c64xx: restore removed comments" to the spi tree Mark Brown
2016-07-08 20:35 ` [PATCH v2 6/7] spi: s3c64xx: restore removed comments Krzysztof Kozlowski
2016-07-08 14:46 ` [PATCH v2 7/7] clk: exynos5433: remove CLK_IGNORE_UNUSED flag from SPI clocks Andi Shyti
2016-07-11 10:58 ` Sylwester Nawrocki
2016-07-08 16:21 ` [PATCH v2 0/7] spi s3c64xx ioclk handling Michael Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=146799441227.73491.13833003558807352160@resonance \
--to=mturquette@baylibre.com \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jh80.chung@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).