linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Turquette <mturquette@baylibre.com>
To: Andi Shyti <andi.shyti@samsung.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Kukjin Kim" <kgene@kernel.org>,
	"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
	"Tomasz Figa" <tomasz.figa@gmail.com>,
	"Stephen Boyd" <sboyd@codeaurora.org>
Cc: "Chanwoo Choi" <cw00.choi@samsung.com>,
	"Jaehoon Chung" <jh80.chung@samsung.com>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org,
	"Andi Shyti" <andi.shyti@samsung.com>,
	"Andi Shyti" <andi@etezian.org>
Subject: Re: [PATCH v3 6/7] spi: s3c64xx: restore removed comments
Date: Tue, 12 Jul 2016 11:07:53 -0700	[thread overview]
Message-ID: <146834687302.73491.6686338412638288829@resonance> (raw)
In-Reply-To: <1468306444-18512-1-git-send-email-andi.shyti@samsung.com>

Quoting Andi Shyti (2016-07-11 23:54:04)
> Patch a9e93e8 has erroneously removed some comments which are
> important to understand why the bus frequency is multiplied by
> two during the spi transfer.
> =

> Reword the previous comment to a more appropriate message.
> =

> Suggested-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> Reviewed-by: Michael Turquette <mturquette@baylibre.com>
> ---
> Hi,
> =

> despite Mike's comments I'm sending the patch as it was
> originally meant. I think that fixing the exact clk where to set
> the rate should anyway go in a different patch.

That sounds fair.

Regards,
Mike

> =

> V2->V3
> The comment has been reworded as Sylwester recommended.
> =

> Thanks,
> Andi
> =

>  drivers/spi/spi-s3c64xx.c | 1 +
>  1 file changed, 1 insertion(+)
> =

> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index 6da663f..5bedafc 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -639,6 +639,7 @@ static void s3c64xx_spi_config(struct s3c64xx_spi_dri=
ver_data *sdd)
>         writel(val, regs + S3C64XX_SPI_MODE_CFG);
>  =

>         if (sdd->port_conf->clk_from_cmu) {
> +               /* The src_clk clock is divided internally by 2 */
>                 clk_set_rate(sdd->src_clk, sdd->cur_speed * 2);
>         } else {
>                 /* Configure Clock */
> -- =

> 2.8.1
>=20

  parent reply	other threads:[~2016-07-12 18:07 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-08 14:46 [PATCH v2 0/7] spi s3c64xx ioclk handling Andi Shyti
2016-07-08 14:46 ` [PATCH v2 1/7] bindings: spi-samsung: add exynos5433 spi compatible Andi Shyti
2016-07-08 20:23   ` Krzysztof Kozlowski
2016-07-11 10:49   ` Sylwester Nawrocki
2016-07-14 16:33   ` Applied "spi: s3c64xx: add exynos5433 spi compatible" to the spi tree Mark Brown
2016-07-08 14:46 ` [PATCH v2 2/7] bindings: spi-samsung: document the clocks and the clock-name property Andi Shyti
2016-07-08 20:32   ` Krzysztof Kozlowski
2016-07-11  2:36     ` [PATCH v3] " Andi Shyti
2016-07-14 16:32       ` Applied "spi: s3c64xx: document the clocks and the clock-name property" to the spi tree Mark Brown
2016-07-08 14:46 ` [PATCH v2 3/7] spi: s3c64xx: rename goto labels to meaningful names Andi Shyti
2016-07-14 16:32   ` Applied "spi: s3c64xx: rename goto labels to meaningful names" to the spi tree Mark Brown
2016-07-08 14:46 ` [PATCH v2 4/7] spi: s3c64xx: use error code from clk_prepare_enable() Andi Shyti
2016-07-08 20:33   ` Krzysztof Kozlowski
2016-07-14 16:32   ` Applied "spi: s3c64xx: use error code from clk_prepare_enable()" to the spi tree Mark Brown
2016-07-08 14:46 ` [PATCH v2 5/7] spi: s3c64xx: add exynos5433 compatible for ioclk handling Andi Shyti
2016-07-08 16:13   ` Michael Turquette
2016-07-08 16:31     ` Andi Shyti
2016-07-08 20:39   ` Krzysztof Kozlowski
2016-07-14 16:32   ` Applied "spi: s3c64xx: add Exynos5433 compatible for ioclk handling" to the spi tree Mark Brown
2016-07-08 14:46 ` [PATCH v2 6/7] spi: s3c64xx: restore removed comments Andi Shyti
2016-07-08 16:17   ` Michael Turquette
2016-07-08 16:35     ` Andi Shyti
2016-07-11 10:33     ` Sylwester Nawrocki
2016-07-11 22:17       ` Michael Turquette
2016-07-12 12:16         ` Sylwester Nawrocki
2016-07-12  6:54       ` [PATCH v3 " Andi Shyti
2016-07-12  8:22         ` Mark Brown
2016-07-12  8:25           ` Andi Shyti
2016-07-12  9:00             ` Mark Brown
2016-07-12 18:07         ` Michael Turquette [this message]
2016-07-14 16:32         ` Applied "spi: s3c64xx: restore removed comments" to the spi tree Mark Brown
2016-07-08 20:35   ` [PATCH v2 6/7] spi: s3c64xx: restore removed comments Krzysztof Kozlowski
2016-07-08 14:46 ` [PATCH v2 7/7] clk: exynos5433: remove CLK_IGNORE_UNUSED flag from SPI clocks Andi Shyti
2016-07-11 10:58   ` Sylwester Nawrocki
2016-07-08 16:21 ` [PATCH v2 0/7] spi s3c64xx ioclk handling Michael Turquette
2016-07-12 10:02 [PATCH v3 " Andi Shyti
2016-07-12 10:02 ` [PATCH v3 6/7] spi: s3c64xx: restore removed comments Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=146834687302.73491.6686338412638288829@resonance \
    --to=mturquette@baylibre.com \
    --cc=andi.shyti@samsung.com \
    --cc=andi@etezian.org \
    --cc=broonie@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jh80.chung@samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@codeaurora.org \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).