From: Michael Turquette <mturquette@baylibre.com>
To: Andi Shyti <andi.shyti@samsung.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Kukjin Kim" <kgene@kernel.org>,
"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
"Mark Brown" <broonie@kernel.org>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Tomasz Figa" <tomasz.figa@gmail.com>,
"Stephen Boyd" <sboyd@codeaurora.org>
Cc: "Chanwoo Choi" <cw00.choi@samsung.com>,
"Jaehoon Chung" <jh80.chung@samsung.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org,
"Andi Shyti" <andi.shyti@samsung.com>,
"Andi Shyti" <andi@etezian.org>
Subject: Re: [PATCH v3 7/7] clk: exynos5433: remove CLK_IGNORE_UNUSED flag from SPI clocks
Date: Tue, 12 Jul 2016 15:17:27 -0700 [thread overview]
Message-ID: <146836184696.73491.9452469757415968654@resonance> (raw)
In-Reply-To: <1468317736-18841-8-git-send-email-andi.shyti@samsung.com>
Quoting Andi Shyti (2016-07-12 03:02:16)
> Because the Exynos5433 SPI driver supports the ioclk handling and
> the following patch:
> =
> http://marc.info/?l=3Dlinux-kernel&m=3D146787645626318&w=3D2
> =
> fixes a synchronus abort issue, none of the SPI clocks require
> any critical handling: remove, then, the CLK_IGNORE_UNUSED flag
> for the SPI related clocks.
> =
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reviewed-by: Michael Turquette <mturquette@baylibre.com>
> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Do you want these patches to go through same tree? If not, I can take
this patch into clk-next.
Regards,
Mike
> ---
> drivers/clk/samsung/clk-exynos5433.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
> =
> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/c=
lk-exynos5433.c
> index c3a5318..fb19525 100644
> --- a/drivers/clk/samsung/clk-exynos5433.c
> +++ b/drivers/clk/samsung/clk-exynos5433.c
> @@ -1661,8 +1661,7 @@ static struct samsung_gate_clock peric_gate_clks[] =
__initdata =3D {
> GATE(CLK_SCLK_IOCLK_SPI2, "sclk_ioclk_spi2", "ioclk_spi2_clk_in",
> ENABLE_SCLK_PERIC, 13, CLK_SET_RATE_PARENT, 0),
> GATE(CLK_SCLK_IOCLK_SPI1, "sclk_ioclk_spi1", "ioclk_spi1_clk_in",
> - ENABLE_SCLK_PERIC, 12,
> - CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT, 0),
> + ENABLE_SCLK_PERIC, 12, CLK_SET_RATE_PARENT, 0),
> GATE(CLK_SCLK_IOCLK_SPI0, "sclk_ioclk_spi0", "ioclk_spi0_clk_in",
> ENABLE_SCLK_PERIC, 11, CLK_SET_RATE_PARENT, 0),
> GATE(CLK_SCLK_IOCLK_I2S1_BCLK, "sclk_ioclk_i2s1_bclk",
> @@ -1677,7 +1676,7 @@ static struct samsung_gate_clock peric_gate_clks[] =
__initdata =3D {
> GATE(CLK_SCLK_SPI2, "sclk_spi2", "sclk_spi2_peric", ENABLE_SCLK_P=
ERIC,
> 5, CLK_SET_RATE_PARENT, 0),
> GATE(CLK_SCLK_SPI1, "sclk_spi1", "sclk_spi1_peric", ENABLE_SCLK_P=
ERIC,
> - 4, CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT, 0),
> + 4, CLK_SET_RATE_PARENT, 0),
> GATE(CLK_SCLK_SPI0, "sclk_spi0", "sclk_spi0_peric", ENABLE_SCLK_P=
ERIC,
> 3, CLK_SET_RATE_PARENT, 0),
> GATE(CLK_SCLK_UART2, "sclk_uart2", "sclk_uart2_peric",
> -- =
> 2.8.1
>=20
next prev parent reply other threads:[~2016-07-12 22:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 10:02 [PATCH v3 0/7] spi s3c64xx ioclk handling Andi Shyti
2016-07-12 10:02 ` [PATCH v3 1/7] bindings: spi-samsung: add exynos5433 spi compatible Andi Shyti
2016-07-14 16:25 ` Mark Brown
2016-07-16 20:26 ` Rob Herring
2016-07-12 10:02 ` [PATCH v3 2/7] bindings: spi-samsung: document the clocks and the clock-name property Andi Shyti
2016-07-16 20:30 ` Rob Herring
2016-07-18 10:30 ` Sylwester Nawrocki
2016-07-12 10:02 ` [PATCH v3 3/7] spi: s3c64xx: rename goto labels to meaningful names Andi Shyti
2016-07-12 10:02 ` [PATCH v3 4/7] spi: s3c64xx: use error code from clk_prepare_enable() Andi Shyti
2016-07-12 10:02 ` [PATCH v3 5/7] spi: s3c64xx: add Exynos5433 compatible for ioclk handling Andi Shyti
2016-07-12 10:02 ` [PATCH v3 6/7] spi: s3c64xx: restore removed comments Andi Shyti
2016-07-12 10:02 ` [PATCH v3 7/7] clk: exynos5433: remove CLK_IGNORE_UNUSED flag from SPI clocks Andi Shyti
2016-07-12 22:17 ` Michael Turquette [this message]
2016-07-13 2:08 ` Andi Shyti
2016-07-13 9:21 ` Sylwester Nawrocki
2016-07-13 9:54 ` Krzysztof Kozlowski
2016-07-13 12:44 ` Andi Shyti
2016-07-13 21:56 ` Michael Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=146836184696.73491.9452469757415968654@resonance \
--to=mturquette@baylibre.com \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jh80.chung@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).