linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Michael Turquette <mturquette@baylibre.com>
Cc: linux-clk@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/5] clk: no need to check return value of debugfs_create functions
Date: Fri, 01 Jun 2018 19:27:15 -0700	[thread overview]
Message-ID: <152790643550.225090.7686614109247734629@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20180529160804.1982-1-gregkh@linuxfoundation.org>

Quoting Greg Kroah-Hartman (2018-05-29 09:08:00)
> -
> -       d =3D debugfs_create_u32("clk_protect_count", 0444, core->dentry,
> -                              &core->protect_count);
> -       if (!d)
> -               goto err_out;
> -
> -       d =3D debugfs_create_u32("clk_notifier_count", 0444, core->dentry,
> -                              &core->notifier_count);
> -       if (!d)
> -               goto err_out;
> +       if (!core || !pdentry)
> +               return;
>  =

> -       if (core->num_parents > 1) {
> -               d =3D debugfs_create_file("clk_possible_parents", 0444,
> -                               core->dentry, core, &possible_parents_fop=
s);
> -               if (!d)
> -                       goto err_out;
> -       }
> +       root =3D debugfs_create_dir(core->name, pdentry);
> +       core->dentry =3D root;
>  =

> -       if (core->ops->debug_init) {
> -               ret =3D core->ops->debug_init(core->hw, core->dentry);

This returns an int. We should go fix all the ops to return void now
because nobody should care. I can pile that patch on top.

Anyway, applied to clk-next.

  parent reply	other threads:[~2018-06-02  2:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29 16:08 [PATCH 1/5] clk: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2018-05-29 16:08 ` [PATCH 2/5] clk: bcm2835: " Greg Kroah-Hartman
2018-05-30 19:39   ` Eric Anholt
2018-06-02  2:27   ` Stephen Boyd
2018-05-29 16:08 ` [PATCH 3/5] clk: davinci: " Greg Kroah-Hartman
2018-05-30 19:03   ` David Lechner
2018-06-02  2:27   ` Stephen Boyd
2018-05-29 16:08 ` [PATCH 4/5] clk: tegra: " Greg Kroah-Hartman
2018-06-02  2:27   ` Stephen Boyd
2018-05-29 16:08 ` [PATCH 5/5] clk: remove clk_debugfs_add_file() Greg Kroah-Hartman
2018-06-02  2:27   ` Stephen Boyd
2018-06-02  2:27 ` Stephen Boyd [this message]
2018-06-02  6:54   ` [PATCH 1/5] clk: no need to check return value of debugfs_create functions Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=152790643550.225090.7686614109247734629@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).