From: Stephen Boyd <sboyd@kernel.org>
To: "David S . Miller" <davem@davemloft.net>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Irina Tirdea <irina.tirdea@intel.com>,
Michael Turquette <mturquette@baylibre.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
netdev@vger.kernel.org, Johannes Stezenbach <js@sig21.net>,
Carlo Caione <carlo@endlessm.com>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 3/4] clk: x86: Stop marking clocks as CLK_IS_CRITICAL
Date: Wed, 29 Aug 2018 20:46:04 -0700 [thread overview]
Message-ID: <153560076419.129321.1550199570456759259@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20180827143200.8597-4-hdegoede@redhat.com>
Quoting Hans de Goede (2018-08-27 07:31:59)
> Commit d31fd43c0f9a ("clk: x86: Do not gate clocks enabled by the
> firmware"), which added the code to mark clocks as CLK_IS_CRITICAL, causes
> all unclaimed PMC clocks on Cherry Trail devices to be on all the time,
> resulting on the device not being able to reach S0i3 when suspended.
> =
> The reason for this commit is that on some Bay Trail / Cherry Trail devic=
es
> the r8169 ethernet controller uses pmc_plt_clk_4. Now that the clk-pmc-at=
om
> driver exports an "ether_clk" alias for pmc_plt_clk_4 and the r8169 driver
> has been modified to get and enable this clock (if present) the marking of
> the clocks as CLK_IS_CRITICAL is no longer necessary.
> =
> This commit removes the CLK_IS_CRITICAL marking, fixing Cherry Trail
> devices not being able to reach S0i3 greatly decreasing their battery
> drain when suspended.
> =
> Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=3D193891#c102
> Cc: Johannes Stezenbach <js@sig21.net>
> Cc: Carlo Caione <carlo@endlessm.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
Acked-by: Stephen Boyd <sboyd@kernel.org>
next prev parent reply other threads:[~2018-08-30 3:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 14:31 [PATCH 0/4] clk-pmc-atom + r8169: Add ether_clk handling to fix suspend issues Hans de Goede
2018-08-27 14:31 ` [PATCH 1/4] clk: x86: add "ether_clk" alias for Bay Trail / Cherry Trail Hans de Goede
2018-08-27 18:43 ` Stephen Boyd
2018-08-27 14:31 ` [PATCH 2/4] r8169: Get and enable optional ether_clk clock Hans de Goede
2018-08-27 18:47 ` Stephen Boyd
2018-08-27 18:53 ` Hans de Goede
2018-08-27 19:14 ` Stephen Boyd
2018-08-29 17:09 ` Hans de Goede
2018-08-30 16:48 ` Stephen Boyd
2018-08-27 14:31 ` [PATCH 3/4] clk: x86: Stop marking clocks as CLK_IS_CRITICAL Hans de Goede
2018-08-30 3:46 ` Stephen Boyd [this message]
2018-08-27 14:32 ` [PATCH 4/4] RFC: r8169: Disable clk during suspend / resume Hans de Goede
2018-08-29 16:31 ` [PATCH 0/4] clk-pmc-atom + r8169: Add ether_clk handling to fix suspend issues Andy Shevchenko
2018-08-29 17:06 ` Hans de Goede
2018-08-30 8:43 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153560076419.129321.1550199570456759259@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=carlo@endlessm.com \
--cc=davem@davemloft.net \
--cc=hdegoede@redhat.com \
--cc=hkallweit1@gmail.com \
--cc=irina.tirdea@intel.com \
--cc=js@sig21.net \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).