From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08BEBC6787C for ; Fri, 12 Oct 2018 19:48:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B05FF21470 for ; Fri, 12 Oct 2018 19:48:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="PewEKTVe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B05FF21470 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-clk-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726227AbeJMDWI (ORCPT ); Fri, 12 Oct 2018 23:22:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:60586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726054AbeJMDWI (ORCPT ); Fri, 12 Oct 2018 23:22:08 -0400 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AC6FF20865; Fri, 12 Oct 2018 19:48:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1539373682; bh=8sct2+61La78CxxhS0HE3Lg2G4PcPBwsWGeYJCIenAo=; h=To:From:In-Reply-To:Cc:References:Subject:Date:From; b=PewEKTVeGvneHQ/hSAVJktxd0rpBrgbZ4kejtp9kiTJaCDqWUtgpVvUcpVaPKiLgi sAkQ8UaVYY4NWRNaW5joCS4rWBDjNhRyVMkofkDZxLLbeXASJHkUmQ1utrZwacP0iN r9G1UTmVpAkKiFNa392zDHMQMbC+9ZfVKtcYsJl0= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: "kernel@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "mturquette@baylibre.com" , "s.hauer@pengutronix.de" , "shawnguo@kernel.org" , Anson Huang , Fabio Estevam , Jerome Forissier , Peng Fan , Rob Herring From: Stephen Boyd In-Reply-To: Cc: dl-linux-imx References: <1533703167-26583-1-git-send-email-Anson.Huang@nxp.com> <153567894721.93865.4092113232222931488@swboyd.mtv.corp.google.com> <153573827629.93865.6200966443862432044@swboyd.mtv.corp.google.com> <153898445180.119890.15025812558797341532@swboyd.mtv.corp.google.com> Message-ID: <153937368201.5275.2313781259297807972@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: RE: [PATCH 2/2] clk: imx: imx7d: remove clks_init_on array Date: Fri, 12 Oct 2018 12:48:02 -0700 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Anson Huang (2018-10-08 01:34:59) > > Quoting Anson Huang (2018-09-03 00:20:53) > > > > > On 08/31/2018 03:29 AM, Stephen Boyd wrote: > > > > > > Quoting Peng Fan (2018-08-12 18:15:41) > > > > > >> Hi Anson, > > > > > >> > > > > > >>>>> -----Original Message----- > > > > > >>>>> From: Anson Huang > > > > > >>>>> Sent: 2018=E5=B9=B48=E6=9C=888=E6=97=A5 12:39 > > > > > >>>>> To: shawnguo@kernel.org; s.hauer@pengutronix.de; > > > > > >>>>> kernel@pengutronix.de; Fabio Estevam > > > > > >>>>> ; mturquette@baylibre.com; > > > > > >>>>> sboyd@kernel.org; linux-arm-kernel@lists.infradead.org; > > > > > >>>>> linux-clk@vger.kernel.org; linux-kernel@vger.kernel.org > > > > > >>>>> Cc: dl-linux-imx > > > > > >>>>> Subject: [PATCH 2/2] clk: imx: imx7d: remove clks_init_on > > > > > >>>>> array > > > > > >>>>> > > > > > >>>>> Clock framework will enable those clocks registered with > > > > > >>>>> CLK_IS_CRITICAL flag, so no need to have clks_init_on array > > > > > >>>>> during clock > > > > > >>>> initialization now. > > > > > >>>> > > > > > >>>> Will it be more flexible to parse dts saying "critical-clock= s =3D " > > > > > >>>> or "init-on-arrary=3D" > > > > > >>>> and enable those clocks? > > > > > >>> > > > > > >>> Parsing the clocks arrays from dtb is another way of enabling > > > > > >>> critical clocks, but for current i.MX6/7 platforms, we > > > > > >>> implement it in same way as most of other SoCs, currently I > > > > > >>> did NOT see any necessity of putting them in dtb, just adding > > > > > >>> flag during clock registering is more simple, if there is any > > > > > >>> special requirement for different clocks set to be enabled, > > > > > >>> then we can add support to enable > > > > the method of parsing critical-clocks from dtb. Just my two cents. > > > > > >> > > > > > >> Thinking about OP-TEE want to use one device, but it's clocks > > > > > >> are registered by Linux, because there is no module in Linux > > > > > >> side use it, it will shutdown the clock, which cause OP-TEE > > > > > >> could not access the > > > > device. > > > > > >> > > > > > >> Then people have to modify clk code to add CLK_IS_CRITICAL flag > > > > > >> to make sure the clocks are not shutdown by Linux. > > > > > >> > > > > > >> However adding a new property in clk node and let driver code > > > > > >> parse the dts, there is no need to modify clk driver code when > > > > > >> OP-TEE needs > > > > another device clock. > > > > > >> > > > > > > > > > > > > If OP-TEE needs linux to keep things on then why can't the > > > > > > OP-TEE driver in Linux probe, acquire clocks, and keep the clks= enabled > > forever? > > > > > > > > > > Sounds reasonable, but how could this be done without introducing > > > > > platform-specific stuff in the OP-TEE driver? > > > > > > > > > > > > > Why is that a goal? > > > > > > I do NOT think we should consider such case in this patch series, > > > whatever OP-TEE needs for its own feature, it should do necessary ope= rations > > either in its driver or somewhere else by adding new patch. > > > > > = > > Why can't we add clks to the op-tee node in DT's /firmware container? > > Then any clks in there can be turned on forever and left enabled by the= linux > > driver? > = > I did NOT run op-tee with Linux-next kernel before, can you advise more? Neither have I, so I can't advise more. > And I think if op-tee has such requirement, > can we have another patch to cover it? Yes. > I believe all other i.MX platforms also have same > requirements if considering op-tee support, so I think it should be anoth= er topic, what do you think? > = I'm going to drop these patches from my review queue. Please resend them and please include the op-tee patches too.