linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>, tdas@codeaurora.org
Cc: Andy Gross <andy.gross@linaro.org>,
	David Brown <david.brown@linaro.org>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-clk-owner@vger.kernel.org
Subject: Re: [PATCH v6] clk: qcom: Add lpass clock controller driver for SDM845
Date: Mon, 29 Oct 2018 11:44:26 -0700	[thread overview]
Message-ID: <154083866621.98144.2623382791446489204@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <360c18d625d6e4792e9ba830c6d0b6ea@codeaurora.org>

Quoting tdas@codeaurora.org (2018-10-25 03:51:01)
> On 2018-10-19 16:09, Taniya Das wrote:
> > On 10/17/2018 7:50 PM, Stephen Boyd wrote:
> >> Quoting Taniya Das (2018-10-17 05:04:10)
> >>> 
> >>> 
> >>> 
> >>> But the problem is not during the above. It is the below
> >>> static void clk_disable_unused_subtree(struct clk_core *core)
> >>> {
> >>> ....
> >>> 
> >>>           if (clk_core_is_enabled(core)) {  --> This access fails.
> >>> ....
> >>> 
> >>> }
> >>> 
> >> 
> >> You may need to add some prepare_ops to turn on clks needed to
> >> read/write lpass registers. Or you can look into using some sort of
> >> genpd to enable required clks when these clks are enabled or disabled.
> >> But I suspect it would be easier to just leave the clks in GCC for 
> >> lpass
> >> always enabled and not worry about the complicated genpd things.
> >> 
> > 
> > I need to check if keeping them enabled/marking them CRITICAL could
> > have an impact on the reset of the subsystem.
> 
> I have checked internally with the teams and the GCC LPASS clocks could 
> be left enabled.
> Would submit a patch keeping them CRITICAL.

Awesome! Thanks for checking.


      reply	other threads:[~2018-10-29 18:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 12:02 [PATCH v6] Add support for LPASS clock controller for SDM845 Taniya Das
2018-10-04 12:02 ` [PATCH v6] clk: qcom: Add lpass clock controller driver " Taniya Das
2018-10-08  2:44   ` Stephen Boyd
2018-10-09 17:26     ` Taniya Das
2018-10-09 20:52       ` Stephen Boyd
2018-10-10  6:12         ` Taniya Das
2018-10-12 17:35           ` Stephen Boyd
2018-10-17 11:37             ` Taniya Das
2018-10-17 12:04               ` Taniya Das
2018-10-17 14:20                 ` Stephen Boyd
2018-10-19 10:39                   ` Taniya Das
2018-10-25 10:51                     ` tdas
2018-10-29 18:44                       ` Stephen Boyd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=154083866621.98144.2623382791446489204@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=andy.gross@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk-owner@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=rnayak@codeaurora.org \
    --cc=tdas@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).