From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7C0FC43441 for ; Wed, 21 Nov 2018 16:46:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A83A214F1 for ; Wed, 21 Nov 2018 16:46:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="YUy60Pm1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A83A214F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-clk-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731778AbeKVDVk (ORCPT ); Wed, 21 Nov 2018 22:21:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:60196 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728028AbeKVDVj (ORCPT ); Wed, 21 Nov 2018 22:21:39 -0500 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4EC7D214DB; Wed, 21 Nov 2018 16:46:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1542818788; bh=0x9Bt0V7yYhJ0kidUQ2U93dCy54xg18GWKXO+bZDcIs=; h=To:From:In-Reply-To:Cc:References:Subject:Date:From; b=YUy60Pm1nbJkGD0bThqHP3a5NXb0kfyD2tWMmawtmfIafhVjjfg77/rlM1z3S9yEU XiuurdyBuCI+it/Xaex9RrlBSRjLJ1UStjoAL+QWj/4eTfGwepw5Wz7WtA7IVVjSTl hke/w3ikc9msALHvDNNLBtLg1wgXnoiZwhm8Uxzo= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: Matthias Brugger , Rob Herring From: Stephen Boyd In-Reply-To: Cc: matthias.bgg@kernel.org, Mark Rutland , CK Hu , Philipp Zabel , David Airlie , Michael Turquette , Stephen Boyd , Ulrich Hecht , Laurent Pinchart , Sean Wang , Sean Wang , Randy Dunlap , Chen-Yu Tsai , dri-devel , "linux-kernel@vger.kernel.org" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-mediatek@lists.infradead.org, linux-clk , devicetree@vger.kernel.org, Matthias Brugger References: <20181116125449.23581-1-matthias.bgg@kernel.org> <20181116125449.23581-9-matthias.bgg@kernel.org> <20181116231522.GA18006@bogus> <2a23e407-4cd4-2e2b-97a5-4e2bb96846e0@gmail.com> Message-ID: <154281878765.88331.10581984256202566195@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH v5 08/12] dt-bindings: mediatek: Change the binding for mmsys clocks Date: Wed, 21 Nov 2018 08:46:27 -0800 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Rob Herring (2018-11-19 11:15:16) > On Sun, Nov 18, 2018 at 11:12 AM Matthias Brugger > wrote: > > On 11/17/18 12:15 AM, Rob Herring wrote: > > > On Fri, Nov 16, 2018 at 01:54:45PM +0100, matthias.bgg@kernel.org wro= te: > > >> - #clock-cells =3D <1>; > > >> + > > >> + mmsys_clk: clock-controller@14000000 { > > >> + compatible =3D "mediatek,mt2712-mmsys-clk"; > > >> + #clock-cells =3D <1>; > > > > > > This goes against the general direction of not defining separate nodes > > > for providers with no resources. > > > > > > Why do you need this and what does it buy if you have to continue to > > > support the existing chips? > > > > > > > It would show explicitly that the mmsys block is used to probe two > > drivers, one for the gpu and one for the clocks. Otherwise that is > > hidden in the drm driver code. I think it is cleaner to describe that in > > the device tree. > = > No, that's maybe cleaner for the driver implementation in the Linux > kernel. What about other OS's or when Linux drivers and subsystems > needs change? Cleaner for DT is design bindings that reflect the h/w. > Hardware is sometimes just messy. > = I agree. I fail to see what this patch series is doing besides changing driver probe and device creation methods and making a backwards incompatible change to DT. Is there any other benefit here?