From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDB38C04EB8 for ; Fri, 30 Nov 2018 06:48:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 921F42146D for ; Fri, 30 Nov 2018 06:48:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="w8Aj0Rrs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 921F42146D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-clk-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726562AbeK3R5I (ORCPT ); Fri, 30 Nov 2018 12:57:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:45264 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726386AbeK3R5I (ORCPT ); Fri, 30 Nov 2018 12:57:08 -0500 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6066420863; Fri, 30 Nov 2018 06:48:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543560532; bh=FpU+sXY1T/Zpbt+sSPXWrQNW5KLWFluYs/jM2zIdhjM=; h=To:From:In-Reply-To:Cc:References:Subject:Date:From; b=w8Aj0RrsuijrqNJGUYuBPmCezhOECIqT98CdDUBbu2lvJDCNlwgrdhiVx/1m1rD9a pPoZFrUUl+cR+/oxDdl+S6XUGw9ZVP6kLgXa7lcepOpZW+dwp7F54rI7+PZEgUegsh PuEEPUYiLeu2wTAMwMdKwbtj8iEme0ZgXbz2/aWE= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: matthias.bgg@gmail.com, matthias.bgg@kernel.org, mturquette@baylibre.com From: Stephen Boyd In-Reply-To: <20181116180901.17737-4-matthias.bgg@kernel.org> Cc: jasu@njomotys.info, sean.wang@kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20181116180901.17737-1-matthias.bgg@kernel.org> <20181116180901.17737-4-matthias.bgg@kernel.org> Message-ID: <154356053181.88331.12262289931983027816@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH v2 3/3] clk: mediatek: Mark bus and DRAM related clocks as critical Date: Thu, 29 Nov 2018 22:48:51 -0800 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting matthias.bgg@kernel.org (2018-11-16 10:09:01) > From: Jasper Mattsson > = > This marks MUXes axi_sel and ddrphycfg_sel as well as gates > infra_dramc_f26m and infra_dramc_b_f26m as with CLK_IS_CRITICAL. > = > Fixes: 96596aa06628 ("clk: mediatek: add clk support for MT6797") > Signed-off-by: Jasper Mattsson > Signed-off-by: Matthias Brugger > --- Can you add comments in the commit text and in the code about why the CLK_IS_CRITICAL flag is added to these clks? It makes it easier to figure out why the flag is there months from now when we all forget