From: Stephen Boyd <sboyd@kernel.org>
To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com
Cc: mturquette@baylibre.com, cw00.choi@samsung.com, krzk@kernel.org,
b.zolnierkie@samsung.com, linux@armlinux.org.uk,
andy.gross@linaro.org, david.brown@linaro.org, pavel@ucw.cz,
andrew.smirnov@gmail.com, pombredanne@nexb.com,
sjhuang@iluvatar.ai, akshu.agrawal@amd.com, djkurtz@chromium.org,
rafael.j.wysocki@intel.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 03/10] clk: of-provider: look at parent if registered device has no provider info
Date: Tue, 04 Dec 2018 11:38:17 -0800 [thread overview]
Message-ID: <154395229720.88331.16585219136189943316@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <a40442ad1a2f1d13798ba535eca371845bae9248.1543922403.git.matti.vaittinen@fi.rohmeurope.com>
Quoting Matti Vaittinen (2018-12-04 03:34:53)
> It seems to be usual for MFD devices that the created 'clock sub-device'
> do not have own DT node. The clock provider information is usually in the
> main device node which is owned by the MFD device. Change the devm variant
> of clk of-provider registration to check the parent device node if given
> device has no own node or if the node does not contain the #clock-cells
> property. In such case use the parent node if it contains the #clock-cells.
>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
> drivers/clk/clk.c | 27 +++++++++++++++++++++++----
> 1 file changed, 23 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 78c90913f987..66dc7c1483d7 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -3893,6 +3893,11 @@ static void devm_of_clk_release_provider(struct device *dev, void *res)
> of_clk_del_provider(*(struct device_node **)res);
> }
>
> +static int of_is_clk_provider(struct device_node *np)
> +{
> + return !!of_find_property(np, "#clock-cells", NULL);
> +}
> +
> /**
> * devm_of_clk_add_hw_provider() - Managed clk provider node registration
> * @dev: Device acting as the clock provider. Used for DT node and lifetime.
> @@ -3901,8 +3906,11 @@ static void devm_of_clk_release_provider(struct device *dev, void *res)
> *
> * Returns 0 on success or an errno on failure.
> *
> - * Registers clock provider for given device's node. Provider is automatically
> - * released at device exit.
> + * Registers clock provider for given device's node. If the device has no DT
> + * node or if the device node lacks of clock provider information (#clock-cells)
> + * then the parent device's node is scanned for this information. If parent node
> + * has the #clock-cells then it is used in registration. Provider is
> + * automatically released at device exit.
> */
> int devm_of_clk_add_hw_provider(struct device *dev,
> struct clk_hw *(*get)(struct of_phandle_args *clkspec,
> @@ -3912,12 +3920,17 @@ int devm_of_clk_add_hw_provider(struct device *dev,
> struct device_node **ptr, *np;
> int ret;
>
> + np = dev->of_node;
> +
> + if (!of_is_clk_provider(dev->of_node))
> + if (of_is_clk_provider(dev->parent->of_node))
> + np = dev->parent->of_node;
As said on v5, let's just modify of_clk_add_provider() to do the parent
search.
next prev parent reply other threads:[~2018-12-04 19:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 11:31 [PATCH v6 00/10] clk: clkdev/of_clk - add managed lookup and provider registrations Matti Vaittinen
2018-12-04 11:33 ` [PATCH v6 01/10] clkdev: add managed clkdev lookup registration Matti Vaittinen
2018-12-04 11:33 ` [PATCH v6 02/10] clk: Add kerneldoc to managed of-provider interfaces Matti Vaittinen
2018-12-04 19:39 ` Stephen Boyd
2018-12-04 11:34 ` [PATCH v6 03/10] clk: of-provider: look at parent if registered device has no provider info Matti Vaittinen
2018-12-04 19:38 ` Stephen Boyd [this message]
2018-12-05 7:00 ` Matti Vaittinen
2018-12-05 17:19 ` Stephen Boyd
2018-12-05 18:20 ` Matti Vaittinen
2018-12-05 18:28 ` Matti Vaittinen
2018-12-05 19:35 ` Stephen Boyd
2018-12-04 11:35 ` [PATCH v6 04/10] clk: clk-max77686: Clean clkdev lookup leak and use devm Matti Vaittinen
2018-12-04 11:37 ` [PATCH v6 05/10] clk: clk-st: avoid clkdev lookup leak at remove Matti Vaittinen
2018-12-04 11:37 ` [PATCH v6 06/10] clk: clk-hi655x: Free of_provider " Matti Vaittinen
2018-12-05 17:25 ` Stephen Boyd
2018-12-04 11:38 ` [PATCH v6 07/10] clk: rk808: use managed version of of_provider registration Matti Vaittinen
2018-12-05 17:25 ` Stephen Boyd
2018-12-04 11:38 ` [PATCH v6 08/10] clk: clk-twl6040: Free of_provider at remove Matti Vaittinen
2018-12-05 17:25 ` Stephen Boyd
2018-12-04 11:39 ` [PATCH v6 09/10] clk: apcs-msm8916: simplify probe cleanup by using devm Matti Vaittinen
2018-12-05 17:25 ` Stephen Boyd
2018-12-04 11:39 ` [PATCH v6 10/10] clk: bd718x7: Initial support for ROHM bd71837/bd71847 PMIC clock Matti Vaittinen
2018-12-05 17:28 ` Stephen Boyd
2018-12-05 18:24 ` Matti Vaittinen
2018-12-05 20:17 ` Pavel Machek
2018-12-04 11:45 ` [PATCH v6 00/10] clk: clkdev/of_clk - add managed lookup and provider registrations Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154395229720.88331.16585219136189943316@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=akshu.agrawal@amd.com \
--cc=andrew.smirnov@gmail.com \
--cc=andy.gross@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=david.brown@linaro.org \
--cc=djkurtz@chromium.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mturquette@baylibre.com \
--cc=pavel@ucw.cz \
--cc=pombredanne@nexb.com \
--cc=rafael.j.wysocki@intel.com \
--cc=sjhuang@iluvatar.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).