From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EB08C43387 for ; Mon, 17 Dec 2018 18:40:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FD7A2133F for ; Mon, 17 Dec 2018 18:40:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545072054; bh=/6TLKhoYmyr9xh25j31W+MHdowTtKqPQoal8ILNWY1I=; h=In-Reply-To:Subject:To:References:From:Cc:Date:List-ID:From; b=SQPzdPPPDnKidMchwKip0/N0aeGbrfzK90HRxXgDLrSxaPM2OLNS5EChPBUZF5mHH VPEra3aL4WH4R5sYjz8NUf0ePd2eAj/lPfxFxORCG/OpmtS8HD1mWUnJkFOipIi6n8 jiBA1N/2TMxzT0Yr5KbAhshDn4zUpe2nQhniUxYo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728208AbeLQSky (ORCPT ); Mon, 17 Dec 2018 13:40:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:39268 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728155AbeLQSkx (ORCPT ); Mon, 17 Dec 2018 13:40:53 -0500 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1A71D2086C; Mon, 17 Dec 2018 18:40:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545072053; bh=/6TLKhoYmyr9xh25j31W+MHdowTtKqPQoal8ILNWY1I=; h=In-Reply-To:Subject:To:References:From:Cc:Date:From; b=CM6FSfh7U7P163eFsuMZMSLoNUcfcUc3+fCBAGWT7+zodqXvOGNwjOlwC531XnHqt ZEu3nlfB73CakgZq/2KAKOzz7xVt17p15Edf+4Ia1ijS2lOiQza824fkWIJbzmHASa /FQhJ+JFjrPQfQjQfui0P7obKfYjJ//KuA7v7Blg= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20181217113539.nfwp4knbx3luxoqn@fsr-ub1664-175> Subject: Re: [PATCH 0/3] clk: imx: Make all the parent_names arrays be const pointers To: Abel Vesa References: <1544801400-18951-1-git-send-email-abel.vesa@nxp.com> <154482171780.19322.123667425822315496@swboyd.mtv.corp.google.com> <20181217113539.nfwp4knbx3luxoqn@fsr-ub1664-175> Message-ID: <154507205230.19322.658078387500141910@swboyd.mtv.corp.google.com> From: Stephen Boyd User-Agent: alot/0.8 Cc: Aisheng Dong , Sascha Hauer , Shawn Guo , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , dl-linux-imx Date: Mon, 17 Dec 2018 10:40:52 -0800 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Abel Vesa (2018-12-17 03:35:40) > On 18-12-14 13:08:37, Stephen Boyd wrote: > > Quoting Abel Vesa (2018-12-14 07:30:08) > > > This is mainly to shut up the checkpatch.pl script warnings about the > > > "static const char *" needing to be "static const char * const". > > >=20 > > > Abel Vesa (3): > > > clk: imx: Make parent_names const pointer in composite-8m > > > clk: imx: Make parents const pointer in mux wrappers > > > clk: imx8mq: Make parent names arrays const pointers > > >=20 > >=20 > > I still see warnings though so there seems to be some more work to do. > >=20 > > drivers/clk/imx/clk-imx8mq.c:401:89: warning: passing argument 5 of 'im= x_clk_mux2' discards 'const' qualifier from pointer target type [-Wdiscarde= d-qualifiers] > > clks[IMX8MQ_CLK_GPU_SHADER_SRC] =3D imx_clk_mux2("gpu_shader_src", ba= se + 0x8200, 24, 3, imx8mq_gpu_shader_sels, ARRAY_SIZE(imx8mq_gpu_shader_s= els)); > >=20 > Hmm, I guess you applied this on top of clk-imx8mq, right ? > This change is against linux-next. The actual problem is the imx_clk_mux2 > which looks like this on branch clk-imx8mq: Yes. It would be great if you could indicate where patches are generated. In fact, I see that 'git format-patch' now has an option to do just this! git format-patch --base=3Dcommit >=20 > static inline struct clk *imx_clk_mux2(const char *name, void __iomem *re= g, =20 > u8 shift, u8 width, const char **parents, int num_parents= ) =20 >=20 > but it looks like this on linux-next (which is exactly the same on clk-ne= xt): >=20 > static inline struct clk *imx_clk_mux2(const char *name, void __iomem *re= g, =20 > u8 shift, u8 width, const char * const *parents, = =20 > int num_parents) = =20 Hrmm ok. I'll have to rejigger things and I probably won't be getting to it until early next year.