linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: imx6q: fix refcount leak in imx6q_clocks_init()
@ 2018-12-26 13:53 Yangtao Li
  2018-12-28 19:36 ` Stephen Boyd
  0 siblings, 1 reply; 2+ messages in thread
From: Yangtao Li @ 2018-12-26 13:53 UTC (permalink / raw)
  To: shawnguo, s.hauer, kernel, fabio.estevam, linux-imx, mturquette, sboyd
  Cc: linux-arm-kernel, linux-clk, linux-kernel, Yangtao Li

The of_find_compatible_node() returns a node pointer with refcount
incremented, but there is the lack of use of the of_node_put() when
done. Add the missing of_node_put() to release the refcount.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
 drivers/clk/imx/clk-imx6q.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c
index bbe0c60f4d09..53617e0632a9 100644
--- a/drivers/clk/imx/clk-imx6q.c
+++ b/drivers/clk/imx/clk-imx6q.c
@@ -424,6 +424,7 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node)
 	np = of_find_compatible_node(NULL, NULL, "fsl,imx6q-anatop");
 	anatop_base = base = of_iomap(np, 0);
 	WARN_ON(!base);
+	of_node_put(np);
 
 	/* Audio/video PLL post dividers do not work on i.MX6q revision 1.0 */
 	if (clk_on_imx6q() && imx_get_soc_revision() == IMX_CHIP_REVISION_1_0) {
-- 
2.17.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] clk: imx6q: fix refcount leak in imx6q_clocks_init()
  2018-12-26 13:53 [PATCH] clk: imx6q: fix refcount leak in imx6q_clocks_init() Yangtao Li
@ 2018-12-28 19:36 ` Stephen Boyd
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2018-12-28 19:36 UTC (permalink / raw)
  To: Yangtao Li, fabio.estevam, kernel, linux-imx, mturquette,
	s.hauer, shawnguo
  Cc: linux-arm-kernel, linux-clk, linux-kernel, Yangtao Li

Quoting Yangtao Li (2018-12-26 05:53:00)
> The of_find_compatible_node() returns a node pointer with refcount
> incremented, but there is the lack of use of the of_node_put() when
> done. Add the missing of_node_put() to release the refcount.
> 
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---

Applied to clk-next


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-28 19:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-26 13:53 [PATCH] clk: imx6q: fix refcount leak in imx6q_clocks_init() Yangtao Li
2018-12-28 19:36 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).