From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C84EC43387 for ; Fri, 4 Jan 2019 16:50:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0BCBB218D3 for ; Fri, 4 Jan 2019 16:50:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="CyhMen8O"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="iqxujgqZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726749AbfADQub (ORCPT ); Fri, 4 Jan 2019 11:50:31 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:33024 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726201AbfADQub (ORCPT ); Fri, 4 Jan 2019 11:50:31 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id AE460609BD; Fri, 4 Jan 2019 16:50:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1546620630; bh=aU6AhPWbkXW7iqE5wPfZm431P+bi3gY9/a44uQVUpfc=; h=From:To:Cc:Subject:Date:From; b=CyhMen8OqI+lF0G5/0A44XgBf3YRKAsuMrNXf5Jb4wzNodG5rsEfK7Y1brIKO3ssp jt3mCi/yjQLQIfZoXmH88Rjtr2ogq8JqH4iGk8mq6FoodH1vbB04OqAuh9GOTFbK4o jv68n/a9IrUJkJRmvhWPCcZgBpPsclX8wqBv4toc= Received: from jhugo-perf-lnx.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jhugo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id EBCEB6081B; Fri, 4 Jan 2019 16:50:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1546620624; bh=aU6AhPWbkXW7iqE5wPfZm431P+bi3gY9/a44uQVUpfc=; h=From:To:Cc:Subject:Date:From; b=iqxujgqZbJbl6Yvw7tLLLKalf814XOmlQgPkCbbO+Ft2Aiy4Y8xnJ93cg6cbOpkNU HuTk935wxJFGHeHa5DArpx0L6/REJ8N8GH3pWeQMy5F0pPbdgPrvQzmxdUEilnvfcW Y2JliwDKNdb8XzPgngaKt5TOAw4ZR8r8JJPsGP2I= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EBCEB6081B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=jhugo@codeaurora.org From: Jeffrey Hugo To: mturquette@baylibre.com, sboyd@kernel.org Cc: bjorn.andersson@linaro.org, andy.gross@linaro.org, david.brown@linaro.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, gregkh@linuxfoundation.org, balbi@kernel.org, linux-usb@vger.kernel.org, Jeffrey Hugo Subject: [PATCH v1 2/6] clk: qcom: Skip halt checks on gcc_usb3_phy_pipe_clk for 8998 Date: Fri, 4 Jan 2019 09:50:15 -0700 Message-Id: <1546620615-2389-1-git-send-email-jhugo@codeaurora.org> X-Mailer: git-send-email 1.9.1 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org The gcc_usb3_phy_pipe_clk is generated by the phy, but is also used by the phy during init. The clock needs to be enabled during the init sequence, but may not be fully active until after the init sequence is complete. This causes a catch-22 if the clock status is checked during enable. As a result, skip the checks to avoid the troubling situation. Signed-off-by: Jeffrey Hugo --- drivers/clk/qcom/gcc-msm8998.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/gcc-msm8998.c b/drivers/clk/qcom/gcc-msm8998.c index 42de947..1a1806a 100644 --- a/drivers/clk/qcom/gcc-msm8998.c +++ b/drivers/clk/qcom/gcc-msm8998.c @@ -2496,7 +2496,7 @@ enum { static struct clk_branch gcc_usb3_phy_pipe_clk = { .halt_reg = 0x50004, - .halt_check = BRANCH_HALT, + .halt_check = BRANCH_HALT_SKIP, .clkr = { .enable_reg = 0x50004, .enable_mask = BIT(0), -- Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.