Linux-Clk Archive on lore.kernel.org
 help / color / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Russell King <linux@armlinux.org.uk>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Antoine Tenart <antoine.tenart@bootlin.com>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Nadav Haklai <nadavh@marvell.com>
Subject: Re: [PATCH v3 2/4] clk: core: link consumer with clock driver
Date: Fri, 25 Jan 2019 13:28:28 -0800
Message-ID: <154845170894.136743.2408260720819956377@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20190104165406.3b52399a@xps13>

Quoting Miquel Raynal (2019-01-04 07:54:06)
> Hi Stephen,
> 
> Stephen Boyd <sboyd@kernel.org> wrote on Tue, 11 Dec 2018 09:12:55
> -0800:
> 
> > Sorry, I'm not reviewing the whole patch right now, just this one little
> > bit because I'm also working in the same area.
> > 
> > Quoting Miquel Raynal (2018-12-04 11:24:38)
> > > diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> > > index 60c51871b04b..721d6b55b2fa 100644
> > > --- a/include/linux/clk-provider.h
> > > +++ b/include/linux/clk-provider.h
> > > @@ -781,6 +781,8 @@ void devm_clk_hw_unregister(struct device *dev, struct clk_hw *hw);
> > >  const char *__clk_get_name(const struct clk *clk);
> > >  const char *clk_hw_get_name(const struct clk_hw *hw);
> > >  struct clk_hw *__clk_get_hw(struct clk *clk);
> > > +void clk_link_consumer(struct device *consumer, struct clk *clk);
> > > +void clk_unlink_consumer(struct clk *clk);  
> > 
> > We shouldn't need to add these functions as far as I can tell. That's
> > because __clk_get() has become an internal API between clkdev.c and
> > clk.c that does nothing now on implementations that aren't the CCF. We
> > can even change this API to take a clk_hw pointer instead of a clk
> > pointer.
> > 
> > I'd rather see us plumb a struct device and clk_hw structure down into
> > __clk_get() and fold it all into __clk_create_clk, possibly even
> > renaming __clk_create_clk to clk_hw_create_clk(). That way we can get
> > the calling device and clk_hw pointer in one call in the clk framework,
> > along with the device name and connection name, and then generate the
> > struct clk right there. This can simplify some code and make it easier
> > to extend this to associate calling devices with the clk consumer
> > somehow.
> > 
> > Here's the diff. With this, you should be able to add and remove device
> > links in clk_hw_create_clk() when dev != NULL.
> 
> Thanks for the help; I updated my work on top of yours, it looks ok but
> I need to run some more tests.
> 
> However I had to tweak a parameter in one of your recent changes, you
> used '-1' as index in __of_clock_get() while it is not a valid value
> (returning an error). As in the __of_clk_get_by_name() function you
> removed index was just set to 0 at the top of the function, I think the
> below fix is valid.

Thanks. Makes sense so I folded it in.


  reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04 19:24 [PATCH v3 0/4] Add device links to clocks Miquel Raynal
2018-12-04 19:24 ` [PATCH v3 1/4] clk: core: clarify the check for runtime PM Miquel Raynal
2018-12-19  0:03   ` Stephen Boyd
2018-12-19  8:03     ` Miquel Raynal
2018-12-20 21:09       ` Stephen Boyd
2019-01-02 10:55         ` Miquel Raynal
2018-12-04 19:24 ` [PATCH v3 2/4] clk: core: link consumer with clock driver Miquel Raynal
2018-12-11 17:12   ` Stephen Boyd
2018-12-17 14:24     ` Miquel Raynal
2019-01-04 15:54     ` Miquel Raynal
2019-01-25 21:28       ` Stephen Boyd [this message]
2019-01-28 10:06         ` Miquel Raynal
2018-12-04 19:24 ` [PATCH v3 3/4] clk: mvebu: armada-37xx-tbg: fill the device entry when registering the clocks Miquel Raynal
2018-12-04 19:24 ` [PATCH v3 4/4] clk: mvebu: armada-37xx-xtal: fill the device entry when registering the clock Miquel Raynal

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=154845170894.136743.2408260720819956377@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=antoine.tenart@bootlin.com \
    --cc=gregory.clement@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.chevallier@bootlin.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=mturquette@baylibre.com \
    --cc=nadavh@marvell.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Clk Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-clk/0 linux-clk/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-clk linux-clk/ https://lore.kernel.org/linux-clk \
		linux-clk@vger.kernel.org linux-clk@archiver.kernel.org
	public-inbox-index linux-clk


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-clk


AGPL code for this site: git clone https://public-inbox.org/ public-inbox