Linux-Clk Archive on lore.kernel.org
 help / Atom feed
* [PATCH] clk: ingenic: jz4740: Fix gating of UDC clock
@ 2019-01-25 15:34 Paul Cercueil
  2019-01-25 18:55 ` Stephen Boyd
  2019-02-05 21:32 ` Stephen Boyd
  0 siblings, 2 replies; 7+ messages in thread
From: Paul Cercueil @ 2019-01-25 15:34 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd; +Cc: linux-clk, linux-kernel, Paul Cercueil

The UDC clock is gated when the bit is cleared, not when it is set.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Tested-by: Artur Rojek <contact@artur-rojek.eu>
---
 drivers/clk/ingenic/jz4740-cgu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/ingenic/jz4740-cgu.c b/drivers/clk/ingenic/jz4740-cgu.c
index d8ac7f2e183a..5d0d5be1e6a7 100644
--- a/drivers/clk/ingenic/jz4740-cgu.c
+++ b/drivers/clk/ingenic/jz4740-cgu.c
@@ -165,7 +165,7 @@ static const struct ingenic_cgu_clk_info jz4740_cgu_clocks[] = {
 		.parents = { JZ4740_CLK_EXT, JZ4740_CLK_PLL_HALF, -1, -1 },
 		.mux = { CGU_REG_CPCCR, 29, 1 },
 		.div = { CGU_REG_CPCCR, 23, 1, 6, -1, -1, -1 },
-		.gate = { CGU_REG_SCR, 6 },
+		.gate = { CGU_REG_SCR, 6, true },
 	},
 
 	/* Gate-only clocks */
-- 
2.20.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] clk: ingenic: jz4740: Fix gating of UDC clock
  2019-01-25 15:34 [PATCH] clk: ingenic: jz4740: Fix gating of UDC clock Paul Cercueil
@ 2019-01-25 18:55 ` Stephen Boyd
  2019-01-25 19:24   ` Paul Cercueil
  2019-02-05 21:32 ` Stephen Boyd
  1 sibling, 1 reply; 7+ messages in thread
From: Stephen Boyd @ 2019-01-25 18:55 UTC (permalink / raw)
  To: Michael Turquette, Paul Cercueil; +Cc: linux-clk, linux-kernel, Paul Cercueil

Quoting Paul Cercueil (2019-01-25 07:34:36)
> The UDC clock is gated when the bit is cleared, not when it is set.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Tested-by: Artur Rojek <contact@artur-rojek.eu>
> ---

Any Fixes tag for this?


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] clk: ingenic: jz4740: Fix gating of UDC clock
  2019-01-25 18:55 ` Stephen Boyd
@ 2019-01-25 19:24   ` Paul Cercueil
  2019-01-29 18:13     ` Stephen Boyd
  0 siblings, 1 reply; 7+ messages in thread
From: Paul Cercueil @ 2019-01-25 19:24 UTC (permalink / raw)
  To: Stephen Boyd; +Cc: Michael Turquette, linux-clk, linux-kernel

Hi,


On Fri, Jan 25, 2019 at 3:55 PM, Stephen Boyd <sboyd@kernel.org> wrote:
> Quoting Paul Cercueil (2019-01-25 07:34:36)
>>  The UDC clock is gated when the bit is cleared, not when it is set.
>> 
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net 
>> <mailto:paul@crapouillou.net>>
>>  Tested-by: Artur Rojek <contact@artur-rojek.eu 
>> <mailto:contact@artur-rojek.eu>>
>>  ---
> 
> Any Fixes tag for this?
> 

Fixes: 2b555a4b9cae

Should I resend?



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] clk: ingenic: jz4740: Fix gating of UDC clock
  2019-01-25 19:24   ` Paul Cercueil
@ 2019-01-29 18:13     ` Stephen Boyd
  2019-01-29 19:22       ` Paul Cercueil
  0 siblings, 1 reply; 7+ messages in thread
From: Stephen Boyd @ 2019-01-29 18:13 UTC (permalink / raw)
  To: Paul Cercueil; +Cc: Michael Turquette, linux-clk, linux-kernel

Quoting Paul Cercueil (2019-01-25 11:24:58)
> Hi,
> 
> 
> On Fri, Jan 25, 2019 at 3:55 PM, Stephen Boyd <sboyd@kernel.org> wrote:
> > Quoting Paul Cercueil (2019-01-25 07:34:36)
> >>  The UDC clock is gated when the bit is cleared, not when it is set.
> >> 
> >>  Signed-off-by: Paul Cercueil <paul@crapouillou.net 
> >> <mailto:paul@crapouillou.net>>
> >>  Tested-by: Artur Rojek <contact@artur-rojek.eu 
> >> <mailto:contact@artur-rojek.eu>>
> >>  ---
> > 
> > Any Fixes tag for this?
> > 
> 
> Fixes: 2b555a4b9cae
> 
> Should I resend?
> 

No need to resend. Is this fixing something that's broken in the v5.0-rc
series? I'm trying to understand if this is a critical fix or a
non-critical fix that can bake until the next release cycle.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] clk: ingenic: jz4740: Fix gating of UDC clock
  2019-01-29 18:13     ` Stephen Boyd
@ 2019-01-29 19:22       ` Paul Cercueil
  2019-01-29 21:16         ` Stephen Boyd
  0 siblings, 1 reply; 7+ messages in thread
From: Paul Cercueil @ 2019-01-29 19:22 UTC (permalink / raw)
  To: Stephen Boyd; +Cc: Michael Turquette, linux-clk, linux-kernel

Hi,

Le mar. 29 janv. 2019 à 15:13, Stephen Boyd <sboyd@kernel.org> a 
écrit :
> Quoting Paul Cercueil (2019-01-25 11:24:58)
>>  Hi,
>> 
>> 
>>  On Fri, Jan 25, 2019 at 3:55 PM, Stephen Boyd <sboyd@kernel.org> 
>> wrote:
>>  > Quoting Paul Cercueil (2019-01-25 07:34:36)
>>  >>  The UDC clock is gated when the bit is cleared, not when it is 
>> set.
>>  >>
>>  >>  Signed-off-by: Paul Cercueil <paul@crapouillou.net
>>  >> <mailto:paul@crapouillou.net>>
>>  >>  Tested-by: Artur Rojek <contact@artur-rojek.eu
>>  >> <mailto:contact@artur-rojek.eu>>
>>  >>  ---
>>  >
>>  > Any Fixes tag for this?
>>  >
>> 
>>  Fixes: 2b555a4b9cae
>> 
>>  Should I resend?
>> 
> 
> No need to resend. Is this fixing something that's broken in the 
> v5.0-rc
> series? I'm trying to understand if this is a critical fix or a
> non-critical fix that can bake until the next release cycle.

It's been broken for one year and nobody noticed, it can wait for 5.1.

-Paul


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] clk: ingenic: jz4740: Fix gating of UDC clock
  2019-01-29 19:22       ` Paul Cercueil
@ 2019-01-29 21:16         ` Stephen Boyd
  0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2019-01-29 21:16 UTC (permalink / raw)
  To: Paul Cercueil; +Cc: Michael Turquette, linux-clk, linux-kernel

Quoting Paul Cercueil (2019-01-29 11:22:25)
> Hi,
> 
> Le mar. 29 janv. 2019 à 15:13, Stephen Boyd <sboyd@kernel.org> a 
> écrit :
> > Quoting Paul Cercueil (2019-01-25 11:24:58)
> >>  Hi,
> >> 
> >> 
> >>  On Fri, Jan 25, 2019 at 3:55 PM, Stephen Boyd <sboyd@kernel.org> 
> >> wrote:
> >>  > Quoting Paul Cercueil (2019-01-25 07:34:36)
> >>  >>  The UDC clock is gated when the bit is cleared, not when it is 
> >> set.
> >>  >>
> >>  >>  Signed-off-by: Paul Cercueil <paul@crapouillou.net
> >>  >> <mailto:paul@crapouillou.net>>
> >>  >>  Tested-by: Artur Rojek <contact@artur-rojek.eu
> >>  >> <mailto:contact@artur-rojek.eu>>
> >>  >>  ---
> >>  >
> >>  > Any Fixes tag for this?
> >>  >
> >> 
> >>  Fixes: 2b555a4b9cae
> >> 
> >>  Should I resend?
> >> 
> > 
> > No need to resend. Is this fixing something that's broken in the 
> > v5.0-rc
> > series? I'm trying to understand if this is a critical fix or a
> > non-critical fix that can bake until the next release cycle.
> 
> It's been broken for one year and nobody noticed, it can wait for 5.1.
> 

Ok, thanks!


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] clk: ingenic: jz4740: Fix gating of UDC clock
  2019-01-25 15:34 [PATCH] clk: ingenic: jz4740: Fix gating of UDC clock Paul Cercueil
  2019-01-25 18:55 ` Stephen Boyd
@ 2019-02-05 21:32 ` Stephen Boyd
  1 sibling, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2019-02-05 21:32 UTC (permalink / raw)
  To: Michael Turquette, Paul Cercueil; +Cc: linux-clk, linux-kernel, Paul Cercueil

Quoting Paul Cercueil (2019-01-25 07:34:36)
> The UDC clock is gated when the bit is cleared, not when it is set.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Tested-by: Artur Rojek <contact@artur-rojek.eu>
> ---

Applied to clk-next


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-25 15:34 [PATCH] clk: ingenic: jz4740: Fix gating of UDC clock Paul Cercueil
2019-01-25 18:55 ` Stephen Boyd
2019-01-25 19:24   ` Paul Cercueil
2019-01-29 18:13     ` Stephen Boyd
2019-01-29 19:22       ` Paul Cercueil
2019-01-29 21:16         ` Stephen Boyd
2019-02-05 21:32 ` Stephen Boyd

Linux-Clk Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-clk/0 linux-clk/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-clk linux-clk/ https://lore.kernel.org/linux-clk \
		linux-clk@vger.kernel.org linux-clk@archiver.kernel.org
	public-inbox-index linux-clk


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-clk


AGPL code for this site: git clone https://public-inbox.org/ public-inbox