* [PATCH] clk: imx8mq: Fix the CLKO2 source select list
@ 2019-01-30 19:21 Fabio Estevam
2019-02-05 22:29 ` Stephen Boyd
2019-02-21 20:44 ` Stephen Boyd
0 siblings, 2 replies; 6+ messages in thread
From: Fabio Estevam @ 2019-01-30 19:21 UTC (permalink / raw)
To: sboyd
Cc: shawnguo, kernel, linux-imx, linux-clk, linux-arm-kernel,
rogerio.silva, Fabio Estevam
The CLKO2 clock source select list is the following as per the i.MX8M
Reference Manual:
000 - 25M_REF_CLK
001 - SYSTEM_PLL2_DIV5
010 - SYSTEM_PLL1_DIV2
011 - SYSTEM_PLL2_DIV6
100 - SYSTEM_PLL3_CLK
101 - AUDIO_PLL1_CLK
110 - VIDEO_PLL1_CLK
111 - 32K_REF_CLK
However, in imx8mq_clko2_sels[] only the first four entries are correct.
Fix it by adding the missing "sys3_pll2_out" entry in order to match
the description from the manual.
Fixes: b80522040cd3f ("clk: imx: Add clock driver for i.MX8MQ CCM")
Reported-by: Rogerio Pimentel <rogerio.silva@nxp.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/clk/imx/clk-imx8mq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c
index 398ab0bcd9de..63001bc891d4 100644
--- a/drivers/clk/imx/clk-imx8mq.c
+++ b/drivers/clk/imx/clk-imx8mq.c
@@ -264,8 +264,8 @@ static const char * const imx8mq_ecspi3_sels[] = {"osc_25m", "sys2_pll_200m", "s
"sys1_pll_800m", "sys3_pll2_out", "sys2_pll_250m", "audio_pll2_out", };
static const char * const imx8mq_dram_core_sels[] = {"dram_pll_out", "dram_alt_root", };
-static const char * const imx8mq_clko2_sels[] = {"osc_25m", "sys2_pll_200m", "sys1_pll_400m", "sys2_pll_166m", "audio_pll1_out",
- "video_pll1_out", "ckil", };
+static const char * const imx8mq_clko2_sels[] = {"osc_25m", "sys2_pll_200m", "sys1_pll_400m", "sys2_pll_166m",
+ "sys3_pll2_out", "audio_pll1_out", "video_pll1_out", "ckil", };
static struct clk_onecell_data clk_data;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] clk: imx8mq: Fix the CLKO2 source select list
2019-01-30 19:21 [PATCH] clk: imx8mq: Fix the CLKO2 source select list Fabio Estevam
@ 2019-02-05 22:29 ` Stephen Boyd
2019-02-05 22:35 ` Fabio Estevam
2019-02-21 20:44 ` Stephen Boyd
1 sibling, 1 reply; 6+ messages in thread
From: Stephen Boyd @ 2019-02-05 22:29 UTC (permalink / raw)
To: Fabio Estevam
Cc: shawnguo, kernel, linux-imx, linux-clk, linux-arm-kernel,
rogerio.silva, Fabio Estevam
Quoting Fabio Estevam (2019-01-30 11:21:02)
> The CLKO2 clock source select list is the following as per the i.MX8M
> Reference Manual:
>
> 000 - 25M_REF_CLK
> 001 - SYSTEM_PLL2_DIV5
> 010 - SYSTEM_PLL1_DIV2
> 011 - SYSTEM_PLL2_DIV6
> 100 - SYSTEM_PLL3_CLK
> 101 - AUDIO_PLL1_CLK
> 110 - VIDEO_PLL1_CLK
> 111 - 32K_REF_CLK
>
> However, in imx8mq_clko2_sels[] only the first four entries are correct.
>
> Fix it by adding the missing "sys3_pll2_out" entry in order to match
> the description from the manual.
>
> Fixes: b80522040cd3f ("clk: imx: Add clock driver for i.MX8MQ CCM")
> Reported-by: Rogerio Pimentel <rogerio.silva@nxp.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
Do I need to fast track this into v5.0 final? Or this is a non-critical
fix for something that isn't used right now?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] clk: imx8mq: Fix the CLKO2 source select list
2019-02-05 22:29 ` Stephen Boyd
@ 2019-02-05 22:35 ` Fabio Estevam
2019-02-06 17:30 ` Stephen Boyd
0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2019-02-05 22:35 UTC (permalink / raw)
To: Stephen Boyd
Cc: Shawn Guo, Sascha Hauer, NXP Linux Team, linux-clk,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Rogerio Pimentel
Hi Stephen,
On Tue, Feb 5, 2019 at 8:29 PM Stephen Boyd <sboyd@kernel.org> wrote:
> Do I need to fast track this into v5.0 final? Or this is a non-critical
> fix for something that isn't used right now?
This is a non-critical fix and it can wait until v5.1.
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: imx8mq: Fix the CLKO2 source select list
2019-02-05 22:35 ` Fabio Estevam
@ 2019-02-06 17:30 ` Stephen Boyd
2019-02-21 10:34 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Boyd @ 2019-02-06 17:30 UTC (permalink / raw)
To: Fabio Estevam
Cc: Shawn Guo, Sascha Hauer, NXP Linux Team, linux-clk,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Rogerio Pimentel
Quoting Fabio Estevam (2019-02-05 14:35:49)
> Hi Stephen,
>
> On Tue, Feb 5, 2019 at 8:29 PM Stephen Boyd <sboyd@kernel.org> wrote:
>
> > Do I need to fast track this into v5.0 final? Or this is a non-critical
> > fix for something that isn't used right now?
>
> This is a non-critical fix and it can wait until v5.1.
>
Alright, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: imx8mq: Fix the CLKO2 source select list
2019-02-06 17:30 ` Stephen Boyd
@ 2019-02-21 10:34 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2019-02-21 10:34 UTC (permalink / raw)
To: Stephen Boyd
Cc: Shawn Guo, Sascha Hauer, NXP Linux Team, linux-clk,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Rogerio Pimentel
Hi Stephen,
On Wed, Feb 6, 2019 at 3:30 PM Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Fabio Estevam (2019-02-05 14:35:49)
> > Hi Stephen,
> >
> > On Tue, Feb 5, 2019 at 8:29 PM Stephen Boyd <sboyd@kernel.org> wrote:
> >
> > > Do I need to fast track this into v5.0 final? Or this is a non-critical
> > > fix for something that isn't used right now?
> >
> > This is a non-critical fix and it can wait until v5.1.
> >
>
> Alright, thanks!
Can this go to clk-next?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: imx8mq: Fix the CLKO2 source select list
2019-01-30 19:21 [PATCH] clk: imx8mq: Fix the CLKO2 source select list Fabio Estevam
2019-02-05 22:29 ` Stephen Boyd
@ 2019-02-21 20:44 ` Stephen Boyd
1 sibling, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2019-02-21 20:44 UTC (permalink / raw)
To: Fabio Estevam
Cc: shawnguo, kernel, linux-imx, linux-clk, linux-arm-kernel,
rogerio.silva, Fabio Estevam
Quoting Fabio Estevam (2019-01-30 11:21:02)
> The CLKO2 clock source select list is the following as per the i.MX8M
> Reference Manual:
>
> 000 - 25M_REF_CLK
> 001 - SYSTEM_PLL2_DIV5
> 010 - SYSTEM_PLL1_DIV2
> 011 - SYSTEM_PLL2_DIV6
> 100 - SYSTEM_PLL3_CLK
> 101 - AUDIO_PLL1_CLK
> 110 - VIDEO_PLL1_CLK
> 111 - 32K_REF_CLK
>
> However, in imx8mq_clko2_sels[] only the first four entries are correct.
>
> Fix it by adding the missing "sys3_pll2_out" entry in order to match
> the description from the manual.
>
> Fixes: b80522040cd3f ("clk: imx: Add clock driver for i.MX8MQ CCM")
> Reported-by: Rogerio Pimentel <rogerio.silva@nxp.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-21 20:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-30 19:21 [PATCH] clk: imx8mq: Fix the CLKO2 source select list Fabio Estevam
2019-02-05 22:29 ` Stephen Boyd
2019-02-05 22:35 ` Fabio Estevam
2019-02-06 17:30 ` Stephen Boyd
2019-02-21 10:34 ` Fabio Estevam
2019-02-21 20:44 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).