Linux-Clk Archive on lore.kernel.org
 help / Atom feed
* [PATCH v2 07/15] ndings: clock: milbeaut: add Milbeaut clock description
@ 2019-02-08 12:27 Sugaya Taichi
  2019-02-13 17:55 ` Stephen Boyd
  0 siblings, 1 reply; 4+ messages in thread
From: Sugaya Taichi @ 2019-02-08 12:27 UTC (permalink / raw)
  To: linux-clk, devicetree, linux-arm-kernel, linux-kernel
  Cc: Michael Turquette, Stephen Boyd, Rob Herring, Mark Rutland,
	Takao Orito, Kazuhiro Kasai, Shinji Kanematsu, Jassi Brar,
	Masami Hiramatsu, Sugaya Taichi

Add DT bindings document for Milbeaut clock.

Signed-off-by: Sugaya Taichi <sugaya.taichi@socionext.com>
---
 .../devicetree/bindings/clock/milbeaut-clock.txt   | 49 ++++++++++++++++++++++
 1 file changed, 49 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/milbeaut-clock.txt

diff --git a/Documentation/devicetree/bindings/clock/milbeaut-clock.txt b/Documentation/devicetree/bindings/clock/milbeaut-clock.txt
new file mode 100644
index 0000000..bcfc5df
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/milbeaut-clock.txt
@@ -0,0 +1,49 @@
+Milbeaut SoCs Clock Controller Binding
+----------------------------------------
+Milbeaut SoCs Clock controller is an integrated clock controller, which
+generates and supplies to all modules.
+
+This binding uses common clock bindings
+[1] Documentation/devicetree/bindings/clock/clock-bindings.txt
+
+Required properties:
+- compatible: should be one of the following:
+    "socionext,milbeaut-m10v-ccu" - for M10V SoC
+- reg: shall contain base address and length of clock registers
+- #clock-cells: shall be 1
+- clocks: shall be an external clock
+
+Example: Clock controller node:
+
+	clk: m10v-clk-ctrl@1d021000 {
+		compatible = "socionext,milbeaut-m10v-clk-ccu";
+		reg = <0x1d021000 0x4000>;
+		#clock-cells = <1>
+		clocks = <&clki40mhz>
+	};
+
+Example: Required an external clock for Clock controller node:
+
+	clocks {
+		clki40mhz: clki40mhz {
+			compatible = "fixed-clock";
+			#clock-cells = <0>;
+			clock-frequency = <40000000>;
+		};
+
+		/* other clocks */
+	};
+
+The clock consumer shall specify the desired clock-output of the clock
+controller as below by specifying output-id in its "clk" phandle cell.
+2: uart
+4: 32-bit timer
+
+Example: uart1 node:
+	uart1: serial@1e700010 {
+		compatible = "socionext,milbeaut-usio-uart";
+		reg = <0x1e700010 0x10>;
+		interrupts = <0 141 0x4>, <0 149 0x4>;
+		interrupt-names = "rx", "tx";
+		clocks = <&clk 2>;
+	};
-- 
1.9.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 07/15] ndings: clock: milbeaut: add Milbeaut clock description
  2019-02-08 12:27 [PATCH v2 07/15] ndings: clock: milbeaut: add Milbeaut clock description Sugaya Taichi
@ 2019-02-13 17:55 ` Stephen Boyd
  2019-02-13 18:07   ` Stephen Boyd
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Boyd @ 2019-02-13 17:55 UTC (permalink / raw)
  To: Sugaya Taichi, devicetree, linux-arm-kernel, linux-clk, linux-kernel
  Cc: Michael Turquette, Rob Herring, Mark Rutland, Takao Orito,
	Kazuhiro Kasai, Shinji Kanematsu, Jassi Brar, Masami Hiramatsu,
	Sugaya Taichi

The subject seems to have been cut off? "ndings"?

Quoting Sugaya Taichi (2019-02-08 04:27:03)
> diff --git a/Documentation/devicetree/bindings/clock/milbeaut-clock.txt b/Documentation/devicetree/bindings/clock/milbeaut-clock.txt
> new file mode 100644
> index 0000000..bcfc5df
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/milbeaut-clock.txt
> @@ -0,0 +1,49 @@
> +Milbeaut SoCs Clock Controller Binding
> +----------------------------------------
> +Milbeaut SoCs Clock controller is an integrated clock controller, which
> +generates and supplies to all modules.
> +
> +This binding uses common clock bindings
> +[1] Documentation/devicetree/bindings/clock/clock-bindings.txt
> +
> +Required properties:
> +- compatible: should be one of the following:
> +    "socionext,milbeaut-m10v-ccu" - for M10V SoC
> +- reg: shall contain base address and length of clock registers
> +- #clock-cells: shall be 1
> +- clocks: shall be an external clock
> +
> +Example: Clock controller node:
> +
> +       clk: m10v-clk-ctrl@1d021000 {
> +               compatible = "socionext,milbeaut-m10v-clk-ccu";

I thought there was some length limit on compatible string names. 32
bytes? Just barely under!


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 07/15] ndings: clock: milbeaut: add Milbeaut clock description
  2019-02-13 17:55 ` Stephen Boyd
@ 2019-02-13 18:07   ` Stephen Boyd
  2019-02-14  0:43     ` Sugaya, Taichi
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Boyd @ 2019-02-13 18:07 UTC (permalink / raw)
  To: Sugaya Taichi, devicetree, linux-arm-kernel, linux-clk, linux-kernel
  Cc: Mark Rutland, Shinji Kanematsu, Masami Hiramatsu, Sugaya Taichi,
	Michael Turquette, Jassi Brar, Rob Herring, Takao Orito,
	Kazuhiro Kasai

Quoting Stephen Boyd (2019-02-13 09:55:34)
> The subject seems to have been cut off? "ndings"?
> 
> Quoting Sugaya Taichi (2019-02-08 04:27:03)
> > diff --git a/Documentation/devicetree/bindings/clock/milbeaut-clock.txt b/Documentation/devicetree/bindings/clock/milbeaut-clock.txt
> > new file mode 100644
> > index 0000000..bcfc5df
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/milbeaut-clock.txt
> > @@ -0,0 +1,49 @@
> > +Milbeaut SoCs Clock Controller Binding
> > +----------------------------------------
> > +Milbeaut SoCs Clock controller is an integrated clock controller, which
> > +generates and supplies to all modules.
> > +
> > +This binding uses common clock bindings
> > +[1] Documentation/devicetree/bindings/clock/clock-bindings.txt
> > +
> > +Required properties:
> > +- compatible: should be one of the following:
> > +    "socionext,milbeaut-m10v-ccu" - for M10V SoC
> > +- reg: shall contain base address and length of clock registers
> > +- #clock-cells: shall be 1
> > +- clocks: shall be an external clock
> > +
> > +Example: Clock controller node:
> > +
> > +       clk: m10v-clk-ctrl@1d021000 {
> > +               compatible = "socionext,milbeaut-m10v-clk-ccu";
> 
> I thought there was some length limit on compatible string names. 32
> bytes? Just barely under!
> 

Ah I'm wrong. Compatible is 128. Good.

Seems I was thinking of DT property names.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 07/15] ndings: clock: milbeaut: add Milbeaut clock description
  2019-02-13 18:07   ` Stephen Boyd
@ 2019-02-14  0:43     ` Sugaya, Taichi
  0 siblings, 0 replies; 4+ messages in thread
From: Sugaya, Taichi @ 2019-02-14  0:43 UTC (permalink / raw)
  To: Stephen Boyd, devicetree, linux-arm-kernel, linux-clk, linux-kernel
  Cc: Mark Rutland, Shinji Kanematsu, Masami Hiramatsu,
	Michael Turquette, Jassi Brar, Rob Herring, Takao Orito,
	Kazuhiro Kasai

Hi,

On 2019/02/14 3:07, Stephen Boyd wrote:
> Quoting Stephen Boyd (2019-02-13 09:55:34)
>> The subject seems to have been cut off? "ndings"?
>>
>> Quoting Sugaya Taichi (2019-02-08 04:27:03)
>>> diff --git a/Documentation/devicetree/bindings/clock/milbeaut-clock.txt b/Documentation/devicetree/bindings/clock/milbeaut-clock.txt
>>> new file mode 100644
>>> index 0000000..bcfc5df
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/clock/milbeaut-clock.txt
>>> @@ -0,0 +1,49 @@
>>> +Milbeaut SoCs Clock Controller Binding
>>> +----------------------------------------
>>> +Milbeaut SoCs Clock controller is an integrated clock controller, which
>>> +generates and supplies to all modules.
>>> +
>>> +This binding uses common clock bindings
>>> +[1] Documentation/devicetree/bindings/clock/clock-bindings.txt
>>> +
>>> +Required properties:
>>> +- compatible: should be one of the following:
>>> +    "socionext,milbeaut-m10v-ccu" - for M10V SoC
>>> +- reg: shall contain base address and length of clock registers
>>> +- #clock-cells: shall be 1
>>> +- clocks: shall be an external clock
>>> +
>>> +Example: Clock controller node:
>>> +
>>> +       clk: m10v-clk-ctrl@1d021000 {
>>> +               compatible = "socionext,milbeaut-m10v-clk-ccu";
>>
>> I thought there was some length limit on compatible string names. 32
>> bytes? Just barely under!
>>
> 
> Ah I'm wrong. Compatible is 128. Good.
> 
> Seems I was thinking of DT property names.
> 

Sorry confusing you.
I accidently deleted "dt-bi" from subject when committing.
I repair the string in the next version.

Thanks,
Sugaya Taichi


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-08 12:27 [PATCH v2 07/15] ndings: clock: milbeaut: add Milbeaut clock description Sugaya Taichi
2019-02-13 17:55 ` Stephen Boyd
2019-02-13 18:07   ` Stephen Boyd
2019-02-14  0:43     ` Sugaya, Taichi

Linux-Clk Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-clk/0 linux-clk/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-clk linux-clk/ https://lore.kernel.org/linux-clk \
		linux-clk@vger.kernel.org linux-clk@archiver.kernel.org
	public-inbox-index linux-clk


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-clk


AGPL code for this site: git clone https://public-inbox.org/ public-inbox