From: Erin Lo <erin.lo@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"Ben Ho" <Ben.Ho@mediatek.com>,
Mars Cheng <mars.cheng@mediatek.com>,
"Mengqi Zhang" <Mengqi.Zhang@mediatek.com>,
linux-clk <linux-clk@vger.kernel.org>,
Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>,
Weiyi Lu <weiyi.lu@mediatek.com>,
Seiya Wang <seiya.wang@mediatek.com>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
<devicetree@vger.kernel.org>, Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
Eddie Huang <eddie.huang@mediatek.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
srv_heupstream <srv_heupstream@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stephen Boyd <sboyd@codeaurora.org>,
<linux-kernel@vger.kernel.org>,
Zhiyong Tao <Zhiyong.Tao@mediatek.com>
Subject: Re: [PATCH v6 6/6] arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile
Date: Sat, 9 Feb 2019 15:37:30 +0800 [thread overview]
Message-ID: <1549697850.26316.5.camel@mtksdaap41> (raw)
In-Reply-To: <c872f03c-714a-d99f-d555-e897f80d67be@gmail.com>
On Thu, 2019-02-07 at 16:08 +0100, Matthias Brugger wrote:
>
> On 01/02/2019 06:11, Erin Lo wrote:
> > Add back more people since mail server issue
> >
> > On Fri, 2019-02-01 at 11:33 +0800, Erin Lo wrote:
> >> On Thu, 2019-01-31 at 15:10 -0600, Rob Herring wrote:
> >>> On Wed, Jan 30, 2019 at 8:34 PM Erin Lo <erin.lo@mediatek.com> wrote:
> >>>>
> >>>> On Wed, 2019-01-30 at 10:22 -0600, Rob Herring wrote:
> >>>>> On Thu, Jan 24, 2019 at 04:07:20PM +0800, Erin Lo wrote:
> >>>>>> From: Ben Ho <Ben.Ho@mediatek.com>
> >>>>>>
> >>>>>> Add basic chip support for Mediatek 8183, include
> >>>>>> pinctrl file, uart node with correct uart clocks, pwrap device
> >>>>>>
> >>>>>> Add clock controller nodes, include topckgen, infracfg,
> >>>>>> apmixedsys and subsystem.
> >>>>>>
> >>>>>> Signed-off-by: Ben Ho <Ben.Ho@mediatek.com>
> >>>>>> Signed-off-by: Erin Lo <erin.lo@mediatek.com>
> >>>>>> Signed-off-by: Seiya Wang <seiya.wang@mediatek.com>
> >>>>>> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> >>>>>> Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com>
> >>>>>> Signed-off-by: Mengqi Zhang <Mengqi.Zhang@mediatek.com>
> >>>>>> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
> >>>>>> Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
> >>>>>> ---
> >>>>>
> >>>>>
> >>>>>> + sysirq: intpol-controller@c530a80 {
> >>>>>
> >>>>> interrupt-controller@...
> >>>>
> >>>> I will modify it in next version.
> >>>>>
> >>>>>
> >>>>> Place all the MMIO peripherals under one or more simple-bus nodes.
> >>>>>
> >>>>> Rob
> >>>>>
> >>>>
> >>>> Do you mean need to add simple-bus like this?
> >>>
> >>> Yes.
> >>
> >> We remove soc because Matthias suggested it in former MTK SoC maybe in
> >> 2015 year.
> >>
> >> We will add it back by your comment.
> >>
> >> Thank you.
> >>
> >> Best Regards,
> >> Erin
> >
> > Hi, Matthias,
> > Do you have any comment here?
>
> Although I wasn't able to find it in the documentation my understanding is, that
> all devices on-chip should be under soc "bus".
>
> I'm sorry if I created confusion with comments in the past.
>
> Regards,
> Matthias
>
OK! we will add soc "bus" back in next version.
Thank you for your comment.
Best Regards,
Erin
> > Thanks
> >
> > Best Regards,
> > Erin
> >>>
> >>>>
> >>>> + soc: soc {
> >>>> + #address-cells = <0x1>;
> >>>> + #size-cells = <0x1>;
> >>>> + ranges = <0 0 0 0xffffffff>;
> >>>> + compatible = "simple-bus";
> >>>>
> >>>> soc_data: soc_data@08000000 {
> >>>> compatible = "mediatek,mt8183-efuse",
> >>>> "mediatek,efuse";
> >>>> reg = <0 0x08000000 0 0x0010>;
> >>>> #address-cells = <1>;
> >>>> #size-cells = <1>;
> >>>> status = "disabled";
> >>>> };
> >>>>
> >>>> gic: interrupt-controller@0c000000 {
> >>>> compatible = "arm,gic-v3";
> >>>> #interrupt-cells = <4>;
> >>>>
> >>>> Best Regards,
> >>>> Erin
> >>>>
> >>>>> _______________________________________________
> >>>>> Linux-mediatek mailing list
> >>>>> Linux-mediatek@lists.infradead.org
> >>>>> http://lists.infradead.org/mailman/listinfo/linux-mediatek
> >>>>
> >>>>
> >>>>
> >>>> _______________________________________________
> >>>> linux-arm-kernel mailing list
> >>>> linux-arm-kernel@lists.infradead.org
> >>>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >>
> >
> >
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2019-02-09 7:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 8:07 [PATCH v6 0/6] Add basic and clock support for Mediatek MT8183 SoC Erin Lo
2019-01-24 8:07 ` [PATCH v6 1/6] irqchip/mtk-sysirq: support 4 interrupt parameters for sysirq Erin Lo
2019-02-07 15:20 ` Matthias Brugger
2019-02-07 15:47 ` Marc Zyngier
2019-02-07 15:52 ` Marc Zyngier
2019-02-11 6:35 ` Seiya Wang
2019-02-11 8:50 ` Marc Zyngier
2019-02-11 13:01 ` Seiya Wang
2019-01-24 8:07 ` [PATCH v6 2/6] dt-bindings: arm: Add bindings for Mediatek MT8183 SoC Platform Erin Lo
2019-02-07 15:15 ` Matthias Brugger
2019-01-24 8:07 ` [PATCH v6 3/6] dt-bindings: mtk-sysirq: Add compatible for Mediatek MT8183 Erin Lo
2019-01-24 8:07 ` [PATCH v6 4/6] dt-bindings: serial: " Erin Lo
2019-01-24 8:07 ` [PATCH v6 5/6] dt-bindings: pinctrl: mt8183: add binding document Erin Lo
2019-01-30 16:17 ` Rob Herring
2019-01-31 8:30 ` Zhiyong Tao
2019-02-07 15:28 ` Matthias Brugger
2019-02-14 3:29 ` Erin Lo
2019-01-24 8:07 ` [PATCH v6 6/6] arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile Erin Lo
2019-01-30 16:22 ` Rob Herring
2019-01-31 2:34 ` Erin Lo
2019-01-31 21:10 ` Rob Herring
2019-02-01 3:33 ` Erin Lo
2019-02-01 5:11 ` Erin Lo
2019-02-07 15:08 ` Matthias Brugger
2019-02-09 7:37 ` Erin Lo [this message]
2019-02-07 15:30 ` Matthias Brugger
2019-02-13 9:03 ` Erin Lo
2019-02-13 14:54 ` Matthias Brugger
2019-02-14 5:27 ` Erin Lo
2019-02-14 9:01 ` Matthias Brugger
2019-02-14 10:14 ` Erin Lo
2019-02-14 10:15 ` Erin Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1549697850.26316.5.camel@mtksdaap41 \
--to=erin.lo@mediatek.com \
--cc=Ben.Ho@mediatek.com \
--cc=Mengqi.Zhang@mediatek.com \
--cc=Zhiyong.Tao@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=hsin-hsiung.wang@mediatek.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mars.cheng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=seiya.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tglx@linutronix.de \
--cc=weiyi.lu@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).