linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/5] clk: imx6sl: Add missing of_node_put()
@ 2020-02-12 11:57 Anson Huang
  2020-02-12 11:57 ` [PATCH 2/5] clk: imx8mq: " Anson Huang
                   ` (5 more replies)
  0 siblings, 6 replies; 11+ messages in thread
From: Anson Huang @ 2020-02-12 11:57 UTC (permalink / raw)
  To: mturquette, sboyd, shawnguo, s.hauer, kernel, festevam, allison,
	gregkh, tglx, abel.vesa, leonard.crestez, peng.fan, ping.bai,
	linux-clk, linux-arm-kernel, linux-kernel
  Cc: Linux-imx

After finishing using device node got from of_find_compatible_node(),
of_node_put() needs to be called.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 drivers/clk/imx/clk-imx6sl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/clk-imx6sl.c b/drivers/clk/imx/clk-imx6sl.c
index 4bd44d8..0f647d1 100644
--- a/drivers/clk/imx/clk-imx6sl.c
+++ b/drivers/clk/imx/clk-imx6sl.c
@@ -208,6 +208,7 @@ static void __init imx6sl_clocks_init(struct device_node *ccm_node)
 	np = of_find_compatible_node(NULL, NULL, "fsl,imx6sl-anatop");
 	base = of_iomap(np, 0);
 	WARN_ON(!base);
+	of_node_put(np);
 	anatop_base = base;
 
 	hws[IMX6SL_PLL1_BYPASS_SRC] = imx_clk_hw_mux("pll1_bypass_src", base + 0x00, 14, 1, pll_bypass_src_sels, ARRAY_SIZE(pll_bypass_src_sels));
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 2/5] clk: imx8mq: Add missing of_node_put()
  2020-02-12 11:57 [PATCH 1/5] clk: imx6sl: Add missing of_node_put() Anson Huang
@ 2020-02-12 11:57 ` Anson Huang
  2020-02-12 20:56   ` Stephen Boyd
  2020-02-12 11:57 ` [PATCH 3/5] clk: imx8mm: " Anson Huang
                   ` (4 subsequent siblings)
  5 siblings, 1 reply; 11+ messages in thread
From: Anson Huang @ 2020-02-12 11:57 UTC (permalink / raw)
  To: mturquette, sboyd, shawnguo, s.hauer, kernel, festevam, allison,
	gregkh, tglx, abel.vesa, leonard.crestez, peng.fan, ping.bai,
	linux-clk, linux-arm-kernel, linux-kernel
  Cc: Linux-imx

After finishing using device node got from of_find_compatible_node(),
of_node_put() needs to be called.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 drivers/clk/imx/clk-imx8mq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c
index 8c82e7a..831ce71 100644
--- a/drivers/clk/imx/clk-imx8mq.c
+++ b/drivers/clk/imx/clk-imx8mq.c
@@ -305,6 +305,7 @@ static int imx8mq_clocks_probe(struct platform_device *pdev)
 
 	np = of_find_compatible_node(NULL, NULL, "fsl,imx8mq-anatop");
 	base = of_iomap(np, 0);
+	of_node_put(np);
 	if (WARN_ON(!base))
 		return -ENOMEM;
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 3/5] clk: imx8mm: Add missing of_node_put()
  2020-02-12 11:57 [PATCH 1/5] clk: imx6sl: Add missing of_node_put() Anson Huang
  2020-02-12 11:57 ` [PATCH 2/5] clk: imx8mq: " Anson Huang
@ 2020-02-12 11:57 ` Anson Huang
  2020-02-12 20:56   ` Stephen Boyd
  2020-02-12 11:57 ` [PATCH 4/5] clk: imx8mn: " Anson Huang
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 11+ messages in thread
From: Anson Huang @ 2020-02-12 11:57 UTC (permalink / raw)
  To: mturquette, sboyd, shawnguo, s.hauer, kernel, festevam, allison,
	gregkh, tglx, abel.vesa, leonard.crestez, peng.fan, ping.bai,
	linux-clk, linux-arm-kernel, linux-kernel
  Cc: Linux-imx

After finishing using device node got from of_find_compatible_node(),
of_node_put() needs to be called.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 drivers/clk/imx/clk-imx8mm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
index 3d19e87..e09c13a 100644
--- a/drivers/clk/imx/clk-imx8mm.c
+++ b/drivers/clk/imx/clk-imx8mm.c
@@ -322,6 +322,7 @@ static int imx8mm_clocks_probe(struct platform_device *pdev)
 
 	np = of_find_compatible_node(NULL, NULL, "fsl,imx8mm-anatop");
 	base = of_iomap(np, 0);
+	of_node_put(np);
 	if (WARN_ON(!base))
 		return -ENOMEM;
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 4/5] clk: imx8mn: Add missing of_node_put()
  2020-02-12 11:57 [PATCH 1/5] clk: imx6sl: Add missing of_node_put() Anson Huang
  2020-02-12 11:57 ` [PATCH 2/5] clk: imx8mq: " Anson Huang
  2020-02-12 11:57 ` [PATCH 3/5] clk: imx8mm: " Anson Huang
@ 2020-02-12 11:57 ` Anson Huang
  2020-02-12 20:57   ` Stephen Boyd
  2020-02-12 11:57 ` [PATCH 5/5] clk: imx8mp: " Anson Huang
                   ` (2 subsequent siblings)
  5 siblings, 1 reply; 11+ messages in thread
From: Anson Huang @ 2020-02-12 11:57 UTC (permalink / raw)
  To: mturquette, sboyd, shawnguo, s.hauer, kernel, festevam, allison,
	gregkh, tglx, abel.vesa, leonard.crestez, peng.fan, ping.bai,
	linux-clk, linux-arm-kernel, linux-kernel
  Cc: Linux-imx

After finishing using device node got from of_find_compatible_node(),
of_node_put() needs to be called.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 drivers/clk/imx/clk-imx8mn.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
index ad20487..9130203 100644
--- a/drivers/clk/imx/clk-imx8mn.c
+++ b/drivers/clk/imx/clk-imx8mn.c
@@ -317,6 +317,7 @@ static int imx8mn_clocks_probe(struct platform_device *pdev)
 
 	np = of_find_compatible_node(NULL, NULL, "fsl,imx8mn-anatop");
 	base = of_iomap(np, 0);
+	of_node_put(np);
 	if (WARN_ON(!base)) {
 		ret = -ENOMEM;
 		goto unregister_hws;
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 5/5] clk: imx8mp: Add missing of_node_put()
  2020-02-12 11:57 [PATCH 1/5] clk: imx6sl: Add missing of_node_put() Anson Huang
                   ` (2 preceding siblings ...)
  2020-02-12 11:57 ` [PATCH 4/5] clk: imx8mn: " Anson Huang
@ 2020-02-12 11:57 ` Anson Huang
  2020-02-12 20:57   ` Stephen Boyd
  2020-02-12 20:56 ` [PATCH 1/5] clk: imx6sl: " Stephen Boyd
  2020-02-17  6:38 ` Shawn Guo
  5 siblings, 1 reply; 11+ messages in thread
From: Anson Huang @ 2020-02-12 11:57 UTC (permalink / raw)
  To: mturquette, sboyd, shawnguo, s.hauer, kernel, festevam, allison,
	gregkh, tglx, abel.vesa, leonard.crestez, peng.fan, ping.bai,
	linux-clk, linux-arm-kernel, linux-kernel
  Cc: Linux-imx

After finishing using device node got from of_find_compatible_node(),
of_node_put() needs to be called.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 drivers/clk/imx/clk-imx8mp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c
index f6c120c..b6462c0 100644
--- a/drivers/clk/imx/clk-imx8mp.c
+++ b/drivers/clk/imx/clk-imx8mp.c
@@ -434,6 +434,7 @@ static int imx8mp_clocks_probe(struct platform_device *pdev)
 
 	np = of_find_compatible_node(NULL, NULL, "fsl,imx8mp-anatop");
 	anatop_base = of_iomap(np, 0);
+	of_node_put(np);
 	if (WARN_ON(!anatop_base))
 		return -ENOMEM;
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/5] clk: imx6sl: Add missing of_node_put()
  2020-02-12 11:57 [PATCH 1/5] clk: imx6sl: Add missing of_node_put() Anson Huang
                   ` (3 preceding siblings ...)
  2020-02-12 11:57 ` [PATCH 5/5] clk: imx8mp: " Anson Huang
@ 2020-02-12 20:56 ` Stephen Boyd
  2020-02-17  6:38 ` Shawn Guo
  5 siblings, 0 replies; 11+ messages in thread
From: Stephen Boyd @ 2020-02-12 20:56 UTC (permalink / raw)
  To: Anson Huang, abel.vesa, allison, festevam, gregkh, kernel,
	leonard.crestez, linux-arm-kernel, linux-clk, linux-kernel,
	mturquette, peng.fan, ping.bai, s.hauer, shawnguo, tglx
  Cc: Linux-imx

Quoting Anson Huang (2020-02-12 03:57:33)
> After finishing using device node got from of_find_compatible_node(),
> of_node_put() needs to be called.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/5] clk: imx8mq: Add missing of_node_put()
  2020-02-12 11:57 ` [PATCH 2/5] clk: imx8mq: " Anson Huang
@ 2020-02-12 20:56   ` Stephen Boyd
  0 siblings, 0 replies; 11+ messages in thread
From: Stephen Boyd @ 2020-02-12 20:56 UTC (permalink / raw)
  To: Anson Huang, abel.vesa, allison, festevam, gregkh, kernel,
	leonard.crestez, linux-arm-kernel, linux-clk, linux-kernel,
	mturquette, peng.fan, ping.bai, s.hauer, shawnguo, tglx
  Cc: Linux-imx

Quoting Anson Huang (2020-02-12 03:57:34)
> After finishing using device node got from of_find_compatible_node(),
> of_node_put() needs to be called.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 3/5] clk: imx8mm: Add missing of_node_put()
  2020-02-12 11:57 ` [PATCH 3/5] clk: imx8mm: " Anson Huang
@ 2020-02-12 20:56   ` Stephen Boyd
  0 siblings, 0 replies; 11+ messages in thread
From: Stephen Boyd @ 2020-02-12 20:56 UTC (permalink / raw)
  To: Anson Huang, abel.vesa, allison, festevam, gregkh, kernel,
	leonard.crestez, linux-arm-kernel, linux-clk, linux-kernel,
	mturquette, peng.fan, ping.bai, s.hauer, shawnguo, tglx
  Cc: Linux-imx

Quoting Anson Huang (2020-02-12 03:57:35)
> After finishing using device node got from of_find_compatible_node(),
> of_node_put() needs to be called.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 4/5] clk: imx8mn: Add missing of_node_put()
  2020-02-12 11:57 ` [PATCH 4/5] clk: imx8mn: " Anson Huang
@ 2020-02-12 20:57   ` Stephen Boyd
  0 siblings, 0 replies; 11+ messages in thread
From: Stephen Boyd @ 2020-02-12 20:57 UTC (permalink / raw)
  To: Anson Huang, abel.vesa, allison, festevam, gregkh, kernel,
	leonard.crestez, linux-arm-kernel, linux-clk, linux-kernel,
	mturquette, peng.fan, ping.bai, s.hauer, shawnguo, tglx
  Cc: Linux-imx

Quoting Anson Huang (2020-02-12 03:57:36)
> After finishing using device node got from of_find_compatible_node(),
> of_node_put() needs to be called.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 5/5] clk: imx8mp: Add missing of_node_put()
  2020-02-12 11:57 ` [PATCH 5/5] clk: imx8mp: " Anson Huang
@ 2020-02-12 20:57   ` Stephen Boyd
  0 siblings, 0 replies; 11+ messages in thread
From: Stephen Boyd @ 2020-02-12 20:57 UTC (permalink / raw)
  To: Anson Huang, abel.vesa, allison, festevam, gregkh, kernel,
	leonard.crestez, linux-arm-kernel, linux-clk, linux-kernel,
	mturquette, peng.fan, ping.bai, s.hauer, shawnguo, tglx
  Cc: Linux-imx

Quoting Anson Huang (2020-02-12 03:57:37)
> After finishing using device node got from of_find_compatible_node(),
> of_node_put() needs to be called.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/5] clk: imx6sl: Add missing of_node_put()
  2020-02-12 11:57 [PATCH 1/5] clk: imx6sl: Add missing of_node_put() Anson Huang
                   ` (4 preceding siblings ...)
  2020-02-12 20:56 ` [PATCH 1/5] clk: imx6sl: " Stephen Boyd
@ 2020-02-17  6:38 ` Shawn Guo
  5 siblings, 0 replies; 11+ messages in thread
From: Shawn Guo @ 2020-02-17  6:38 UTC (permalink / raw)
  To: Anson Huang
  Cc: mturquette, sboyd, s.hauer, kernel, festevam, allison, gregkh,
	tglx, abel.vesa, leonard.crestez, peng.fan, ping.bai, linux-clk,
	linux-arm-kernel, linux-kernel, Linux-imx

On Wed, Feb 12, 2020 at 07:57:33PM +0800, Anson Huang wrote:
> After finishing using device node got from of_find_compatible_node(),
> of_node_put() needs to be called.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Applied all, thanks.

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2020-02-17  6:38 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-12 11:57 [PATCH 1/5] clk: imx6sl: Add missing of_node_put() Anson Huang
2020-02-12 11:57 ` [PATCH 2/5] clk: imx8mq: " Anson Huang
2020-02-12 20:56   ` Stephen Boyd
2020-02-12 11:57 ` [PATCH 3/5] clk: imx8mm: " Anson Huang
2020-02-12 20:56   ` Stephen Boyd
2020-02-12 11:57 ` [PATCH 4/5] clk: imx8mn: " Anson Huang
2020-02-12 20:57   ` Stephen Boyd
2020-02-12 11:57 ` [PATCH 5/5] clk: imx8mp: " Anson Huang
2020-02-12 20:57   ` Stephen Boyd
2020-02-12 20:56 ` [PATCH 1/5] clk: imx6sl: " Stephen Boyd
2020-02-17  6:38 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).