Linux-Clk Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] clk: Fix continuation of of_clk_detect_critical()
@ 2019-12-06 13:34 Geert Uytterhoeven
  2019-12-09  8:14 ` Lee Jones
  2020-02-12 23:39 ` Stephen Boyd
  0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2019-12-06 13:34 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd, Lee Jones; +Cc: linux-clk, Geert Uytterhoeven

The second line of the of_clk_detect_critical() function signature is
not indented according to coding style.

Fixes: d56f8994b6fb928f ("clk: Provide OF helper to mark clocks as CRITICAL")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/clk/clk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 9c5b9419e585f845..06ea776830473c2a 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -4799,8 +4799,8 @@ static int parent_ready(struct device_node *np)
  *
  * Return: error code or zero on success
  */
-int of_clk_detect_critical(struct device_node *np,
-					  int index, unsigned long *flags)
+int of_clk_detect_critical(struct device_node *np, int index,
+			   unsigned long *flags)
 {
 	struct property *prop;
 	const __be32 *cur;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: Fix continuation of of_clk_detect_critical()
  2019-12-06 13:34 [PATCH] clk: Fix continuation of of_clk_detect_critical() Geert Uytterhoeven
@ 2019-12-09  8:14 ` Lee Jones
  2020-02-12 23:39 ` Stephen Boyd
  1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2019-12-09  8:14 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Michael Turquette, Stephen Boyd, linux-clk

On Fri, 06 Dec 2019, Geert Uytterhoeven wrote:

> The second line of the of_clk_detect_critical() function signature is
> not indented according to coding style.
> 
> Fixes: d56f8994b6fb928f ("clk: Provide OF helper to mark clocks as CRITICAL")

This is not suitable for Stable.

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/clk/clk.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 9c5b9419e585f845..06ea776830473c2a 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -4799,8 +4799,8 @@ static int parent_ready(struct device_node *np)
>   *
>   * Return: error code or zero on success
>   */
> -int of_clk_detect_critical(struct device_node *np,
> -					  int index, unsigned long *flags)

Not sure what happened here.

> +int of_clk_detect_critical(struct device_node *np, int index,
> +			   unsigned long *flags)

Acked-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: Fix continuation of of_clk_detect_critical()
  2019-12-06 13:34 [PATCH] clk: Fix continuation of of_clk_detect_critical() Geert Uytterhoeven
  2019-12-09  8:14 ` Lee Jones
@ 2020-02-12 23:39 ` Stephen Boyd
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2020-02-12 23:39 UTC (permalink / raw)
  To: Geert Uytterhoeven, Lee Jones, Michael Turquette, Stephen Boyd
  Cc: linux-clk, Geert Uytterhoeven

Quoting Geert Uytterhoeven (2019-12-06 05:34:14)
> The second line of the of_clk_detect_critical() function signature is
> not indented according to coding style.
> 
> Fixes: d56f8994b6fb928f ("clk: Provide OF helper to mark clocks as CRITICAL")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---

Applied to clk-next

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-06 13:34 [PATCH] clk: Fix continuation of of_clk_detect_critical() Geert Uytterhoeven
2019-12-09  8:14 ` Lee Jones
2020-02-12 23:39 ` Stephen Boyd

Linux-Clk Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-clk/0 linux-clk/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-clk linux-clk/ https://lore.kernel.org/linux-clk \
		linux-clk@vger.kernel.org
	public-inbox-index linux-clk

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-clk


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git