From: Stephen Boyd <sboyd@kernel.org>
To: Maxime Ripard <maxime@cerno.tech>, Rob Herring <robh@kernel.org>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Eric Anholt <eric@anholt.net>,
devicetree@vger.kernel.org, Tim Gover <tim.gover@raspberrypi.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-clk@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
Phil Elwell <phil@raspberrypi.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 06/89] dt-bindings: clock: Add a binding for the RPi Firmware clocks
Date: Thu, 12 Mar 2020 16:14:47 -0700 [thread overview]
Message-ID: <158405488765.149997.7323586314054590516@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20200225181654.GA694@bogus>
Quoting Rob Herring (2020-02-25 10:16:54)
> On Mon, Feb 24, 2020 at 10:06:08AM +0100, Maxime Ripard wrote:
> > The firmare running on the RPi VideoCore can be used to discover and
> > change the various clocks running in the BCM2711. Since devices will
> > need to use them through the DT, let's add a pretty simple binding.
> >
> > Cc: Michael Turquette <mturquette@baylibre.com>
> > Cc: Stephen Boyd <sboyd@kernel.org>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: linux-clk@vger.kernel.org
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > ---
> > Documentation/devicetree/bindings/clock/raspberrypi,firmware-clocks.yaml | 39 +++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 39 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/clock/raspberrypi,firmware-clocks.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/clock/raspberrypi,firmware-clocks.yaml b/Documentation/devicetree/bindings/clock/raspberrypi,firmware-clocks.yaml
> > new file mode 100644
> > index 000000000000..d37bc311321d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/raspberrypi,firmware-clocks.yaml
> > @@ -0,0 +1,39 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/raspberrypi,firmware-clocks.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: RaspberryPi Firmware Clocks Device Tree Bindings
> > +
> > +maintainers:
> > + - Maxime Ripard <mripard@kernel.org>
> > +
> > +properties:
> > + "#clock-cells":
> > + const: 1
> > +
> > + compatible:
> > + const: raspberrypi,firmware-clocks
> > +
> > + raspberrypi,firmware:
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > + description: >
> > + Phandle to the mailbox node to communicate with the firmware.
>
> Can't this be a child node of the phandle instead? Or just add
> '#clock-cells' to the firmware node.
Yeah, just add the clock-cells to the firmware node unless that doesn't
work for some reason?
next prev parent reply other threads:[~2020-03-12 23:14 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.6c896ace9a5a7840e9cec008b553cbb004ca1f91.1582533919.git-series.maxime@cerno.tech>
2020-02-24 9:06 ` [PATCH 05/89] clk: Return error code when of provider pointer is NULL Maxime Ripard
2020-03-12 23:13 ` Stephen Boyd
2020-02-24 9:06 ` [PATCH 06/89] dt-bindings: clock: Add a binding for the RPi Firmware clocks Maxime Ripard
2020-02-25 18:16 ` Rob Herring
2020-03-12 23:14 ` Stephen Boyd [this message]
2020-02-24 9:06 ` [PATCH 07/89] clk: bcm: rpi: Allow the driver to be probed by DT Maxime Ripard
2020-02-25 16:00 ` Nicolas Saenz Julienne
2020-02-26 15:01 ` Maxime Ripard
2020-02-28 19:57 ` Nicolas Saenz Julienne
2020-03-01 12:16 ` Stefan Wahren
2020-03-23 15:13 ` Maxime Ripard
2020-02-24 9:06 ` [PATCH 08/89] clk: bcm: rpi: Statically init clk_init_data Maxime Ripard
2020-02-25 16:05 ` Nicolas Saenz Julienne
2020-02-24 9:06 ` [PATCH 09/89] clk: bcm: rpi: Use clk_hw_register for pllb_arm Maxime Ripard
2020-02-25 16:11 ` Nicolas Saenz Julienne
2020-03-12 23:17 ` Stephen Boyd
2020-02-24 9:06 ` [PATCH 10/89] clk: bcm: rpi: Remove global pllb_arm clock pointer Maxime Ripard
2020-02-25 16:13 ` Nicolas Saenz Julienne
2020-02-26 14:26 ` Maxime Ripard
2020-02-26 14:57 ` Nicolas Saenz Julienne
2020-02-24 9:06 ` [PATCH 11/89] clk: bcm: rpi: Make sure pllb_arm is removed Maxime Ripard
2020-02-25 16:14 ` Nicolas Saenz Julienne
2020-03-12 23:20 ` Stephen Boyd
2020-02-24 9:06 ` [PATCH 12/89] clk: bcm: rpi: Remove pllb_arm_lookup global pointer Maxime Ripard
2020-02-25 16:16 ` Nicolas Saenz Julienne
2020-03-12 23:21 ` Stephen Boyd
2020-03-13 1:13 ` Stephen Boyd
2020-02-24 9:06 ` [PATCH 13/89] clk: bcm: rpi: Switch to clk_hw_register_clkdev Maxime Ripard
2020-02-25 16:17 ` Nicolas Saenz Julienne
2020-03-13 1:12 ` Stephen Boyd
2020-02-24 9:06 ` [PATCH 14/89] clk: bcm: rpi: Make sure the clkdev lookup is removed Maxime Ripard
2020-02-25 16:19 ` Nicolas Saenz Julienne
2020-03-13 1:11 ` Stephen Boyd
2020-02-24 9:06 ` [PATCH 15/89] clk: bcm: rpi: Create a data structure for the clocks Maxime Ripard
2020-02-25 16:24 ` Nicolas Saenz Julienne
2020-03-13 1:11 ` Stephen Boyd
2020-02-24 9:06 ` [PATCH 16/89] clk: bcm: rpi: Add clock id to data Maxime Ripard
2020-02-24 19:25 ` Stefan Wahren
2020-02-25 9:54 ` Maxime Ripard
2020-02-25 14:33 ` Nicolas Saenz Julienne
2020-02-25 16:24 ` Nicolas Saenz Julienne
2020-03-13 1:11 ` Stephen Boyd
2020-02-24 9:06 ` [PATCH 17/89] clk: bcm: rpi: Pass the clocks data to the firmware function Maxime Ripard
2020-02-25 16:26 ` Nicolas Saenz Julienne
2020-03-13 1:09 ` Stephen Boyd
2020-02-24 9:06 ` [PATCH 18/89] clk: bcm: rpi: Rename is_prepared function Maxime Ripard
2020-02-25 16:45 ` Nicolas Saenz Julienne
2020-03-13 1:09 ` Stephen Boyd
2020-02-24 9:06 ` [PATCH 19/89] clk: bcm: rpi: Split pllb clock hooks Maxime Ripard
2020-03-13 1:08 ` Stephen Boyd
2020-02-24 9:06 ` [PATCH 20/89] clk: bcm: rpi: Make the PLLB registration function return a clk_hw Maxime Ripard
2020-03-13 1:01 ` Stephen Boyd
2020-02-24 9:06 ` [PATCH 21/89] clk: bcm: rpi: Add DT provider for the clocks Maxime Ripard
2020-03-13 1:01 ` Stephen Boyd
2020-02-24 9:06 ` [PATCH 22/89] clk: bcm: rpi: Discover the firmware clocks Maxime Ripard
2020-02-24 16:47 ` kbuild test robot
2020-02-24 16:47 ` [PATCH] clk: bcm: rpi: fix noderef.cocci warnings kbuild test robot
2020-02-24 18:15 ` [PATCH 22/89] clk: bcm: rpi: Discover the firmware clocks Florian Fainelli
2020-02-26 14:15 ` Maxime Ripard
2020-02-24 20:24 ` kbuild test robot
2020-03-13 1:08 ` Stephen Boyd
2020-02-24 9:06 ` [PATCH 27/89] clk: bcm: Add BCM2711 DVP driver Maxime Ripard
2020-03-13 1:00 ` Stephen Boyd
2020-03-23 10:56 ` Maxime Ripard
2020-03-25 2:20 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158405488765.149997.7323586314054590516@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=maxime@cerno.tech \
--cc=mturquette@baylibre.com \
--cc=nsaenzjulienne@suse.de \
--cc=phil@raspberrypi.com \
--cc=robh@kernel.org \
--cc=tim.gover@raspberrypi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).