From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB21EC10DCE for ; Thu, 12 Mar 2020 23:17:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7651720716 for ; Thu, 12 Mar 2020 23:17:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584055074; bh=QepFjxAZCdw4rXsCdCvk71ljF1gNrapkk/Ira5TscFM=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=ogRH/NqLrVdMF0v/rR+89eQIOQpnKviD1fXfpyV8G3NDhmK0geBu36QEV4h6aLw1N biLcsMswsFF4m6Iv4H6sSkTi21821YlEuPkWMsH/DpUsTm26CtagjQTLS4TcuzREbk 2kgpUXqpWqwqrG8ykqgzaOMB2JSpMd9Pd2ttxnqc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726749AbgCLXRy (ORCPT ); Thu, 12 Mar 2020 19:17:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:60288 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726710AbgCLXRy (ORCPT ); Thu, 12 Mar 2020 19:17:54 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 85E8520637; Thu, 12 Mar 2020 23:17:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584055073; bh=QepFjxAZCdw4rXsCdCvk71ljF1gNrapkk/Ira5TscFM=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=OrSejX72s2mt+UCjcjs8je8y7xAEnQCUR0GLcQcvO9Y34/g+JnXjtwETDdF+ccoNZ N5eBxqY77EtNebU2RteYBBDHDFUkEMPC9f5cx0FD86iGsJtY95jtrzzHqttpXuh7+J kyU007r5eukTSF+SnR4t1fzcrtBOP6b98stixg10= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1c47c839fda93460994d37b4c851d805a3282d5f.1582533919.git-series.maxime@cerno.tech> References: <1c47c839fda93460994d37b4c851d805a3282d5f.1582533919.git-series.maxime@cerno.tech> Subject: Re: [PATCH 09/89] clk: bcm: rpi: Use clk_hw_register for pllb_arm From: Stephen Boyd Cc: dri-devel@lists.freedesktop.org, linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Stevenson , Tim Gover , Phil Elwell , Maxime Ripard , Michael Turquette , linux-clk@vger.kernel.org To: Eric Anholt , Maxime Ripard , Nicolas Saenz Julienne Date: Thu, 12 Mar 2020 16:17:52 -0700 Message-ID: <158405507267.149997.9253782069794352377@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Maxime Ripard (2020-02-24 01:06:11) > The pllb_arm clock is defined as a fixed factor clock with the pllb clock > as a parent. However, all its configuration is entirely static, and thus = we > don't really need to call clk_hw_register_fixed_factor but can simply call > clk_hw_register with a static clk_fixed_factor structure. Please add () to things like clk_hw_register_fixed_factor() and clk_hw_register(). >=20 > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-clk@vger.kernel.org > Signed-off-by: Maxime Ripard > --- Reviewed-by: Stephen Boyd