From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Maxime Ripard <maxime@cerno.tech>
Subject: Re: [PATCH] clk: Pass correct arguments to __clk_hw_register_gate()
Date: Tue, 24 Mar 2020 19:28:12 -0700 [thread overview]
Message-ID: <158510329289.125146.2737057581185153152@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20200325022257.148244-1-sboyd@kernel.org>
Quoting Stephen Boyd (2020-03-24 19:22:57)
> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> index 952ac035bab9..95cc8a4f6e39 100644
> --- a/include/linux/clk-provider.h
> +++ b/include/linux/clk-provider.h
> @@ -539,10 +539,10 @@ struct clk *clk_register_gate(struct device *dev, const char *name,
> * @clk_gate_flags: gate-specific flags for this clock
> * @lock: shared register lock for this clock
> */
> -#define clk_hw_register_gate_parent_data(dev, name, parent_name, flags, reg, \
> +#define clk_hw_register_gate_parent_data(dev, name, parent_data, flags, reg, \
> bit_idx, clk_gate_flags, lock) \
> - __clk_hw_register_gate((dev), NULL, (name), (parent_name), NULL, \
> - NULL, (flags), (reg), (bit_idx), \
> + __clk_hw_register_gate((dev), NULL, (name), NULL, NULL, (parent_data) \
And this needs a comma after it.
I'll apply this to clk-fixes and send to Linus in the next few days.
> + (flags), (reg), (bit_idx), \
> (clk_gate_flags), (lock))
next prev parent reply other threads:[~2020-03-25 2:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 2:22 [PATCH] clk: Pass correct arguments to __clk_hw_register_gate() Stephen Boyd
2020-03-25 2:28 ` Stephen Boyd [this message]
2020-03-25 15:32 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158510329289.125146.2737057581185153152@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).