From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE091C54FD0 for ; Wed, 22 Apr 2020 02:46:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CE5820722 for ; Wed, 22 Apr 2020 02:46:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587523572; bh=WDVNXLuDKHJmMAKTFYft3OMO/USP/AU36btJw83knso=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=LwtoxftE3d/o/LymE6CuPNGeuqUwx5Eegfk7j60Zv+B7L0i41ACt6nDdMXAbRn+a9 28DC7kBV3nOQVg4jdvALyMDpPOXVVaOU/tl8TQojFlAVL2n1maoF+/7kFa2Um2miYR vBlmIVmDbx6OvbCRFWfqdxJt6MuBos15RRQuDQ5Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726294AbgDVCqJ (ORCPT ); Tue, 21 Apr 2020 22:46:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:58806 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725912AbgDVCqJ (ORCPT ); Tue, 21 Apr 2020 22:46:09 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F0894206D5; Wed, 22 Apr 2020 02:46:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587523569; bh=WDVNXLuDKHJmMAKTFYft3OMO/USP/AU36btJw83knso=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=Of9o2uQzI9EzXzjRvHOeCuJLwn/xkYTytsQYc2MEfhFMsiacEV0sYZ7tMG2EGSqLr ASKMJcPD5HFJOisISVcF7owCxs6dJkKwm1cWeSODxwKR5kU2D4MFCBhbiBgIj8625M QimS93P99SUmrAhwd9XzhSiNYsF4pfWI9WSvXKgw= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200329124116.4185447-1-bryan.odonoghue@linaro.org> References: <20200329124116.4185447-1-bryan.odonoghue@linaro.org> Subject: Re: [PATCH] clk: qcom: msm8916: Fix the address location of pll->config_reg From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, Bryan O'Donoghue , Georgi Djakov , Andy Gross , Bjorn Andersson , Michael Turquette To: Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org Date: Tue, 21 Apr 2020 19:46:07 -0700 Message-ID: <158752356720.132238.12302452053488329235@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Bryan O'Donoghue (2020-03-29 05:41:16) > During the process of debugging a processor derived from the msm8916 which > we found the new processor was not starting one of its PLLs. >=20 > After tracing the addresses and writes that downstream was doing and > comparing to upstream it became obvious that we were writing to a differe= nt > register location than downstream when trying to configure the PLL. >=20 > This error is also present in upstream msm8916. >=20 > As an example clk-pll.c::clk_pll_recalc_rate wants to write to > pll->config_reg updating the bit-field POST_DIV_RATIO. That bit-field is > defined in PLL_USER_CTL not in PLL_CONFIG_CTL. Taking the BIMC PLL as an > example >=20 > lm80-p0436-13_c_qc_snapdragon_410_processor_hrd.pdf >=20 > 0x01823010 GCC_BIMC_PLL_USER_CTL > 0x01823014 GCC_BIMC_PLL_CONFIG_CTL >=20 > This pattern is repeated for gpll0, gpll1, gpll2 and bimc_pll. >=20 > This error is likely not apparent since the bootloader will already have > initialized these PLLs. >=20 > This patch corrects the location of config_reg from PLL_CONFIG_CTL to > PLL_USER_CTL for all relevant PLLs on msm8916. >=20 > Fixes commit 3966fab8b6ab ("clk: qcom: Add MSM8916 Global Clock Controlle= r support") >=20 > Cc: Georgi Djakov > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Michael Turquette > Cc: Stephen Boyd > Signed-off-by: Bryan O'Donoghue > --- Applied to clk-next