Re: [PATCH 3/4] dt-bindings: clk: qcom: Add bindings for CPU clock for msm8996

From: Stephen Boyd <sboyd@kernel.org>
To: Loic Poulain <loic.poulain@linaro.org>,
	bjorn.andersson@linaro.org, mturquette@baylibre.com
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	Ilia Lin <ilialin@codeaurora.org>
Subject: Re: [PATCH 3/4] dt-bindings: clk: qcom: Add bindings for CPU clock for msm8996
Date: Wed, 22 Apr 2020 02:08:06 -0700	[thread overview]
Message-ID: <158754648689.132238.18246673092201406766@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1585224008-15730-4-git-send-email-loic.poulain@linaro.org>

Quoting Loic Poulain (2020-03-26 05:00:07)
> diff --git a/Documentation/devicetree/bindings/clock/qcom,kryocc.txt b/Documentation/devicetree/bindings/clock/qcom,kryocc.txt
> new file mode 100644
> index 0000000..8458783
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,kryocc.txt
> @@ -0,0 +1,17 @@
> +Qualcomm CPUSS clock controller for Kryo CPUs
> +----------------------------------------------------
> +
> +Required properties :
> +- compatible : shall contain only one of the following:
> +
> +                       "qcom,msm8996-apcc"
> +
> +- reg : shall contain base register location and length
> +- #clock-cells : shall contain 1

Any chance this can become YAML, take parent clocks via the 'clocks' and
'clock-names' properties in DT, and have the file name reflect the
compatible string instead of qcom,kryocc?

> +
> +Example:
> +       kryocc: clock-controller@6400000 {
> +               compatible = "qcom,msm8996-apcc";
> +               reg = <0x6400000 0x90000>;
> +               #clock-cells = <1>;
> +       };