From: Stephen Boyd <sboyd@kernel.org>
To: Marc Zyngier <maz@kernel.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Guenter Roeck <linux@roeck-us.net>,
Michael Turquette <mturquette@baylibre.com>
Subject: Re: [PATCH] clk: Unlink clock if failed to prepare or enable
Date: Tue, 05 May 2020 12:12:03 -0700 [thread overview]
Message-ID: <158870592381.26370.8784478076215991539@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20200505140953.409430-1-maz@kernel.org>
Quoting Marc Zyngier (2020-05-05 07:09:53)
> On failing to prepare or enable a clock, remove the core structure
> from the list it has been inserted as it is about to be freed.
>
> This otherwise leads to random crashes when subsequent clocks get
> registered, during which parsing of the clock tree becomes adventurous.
>
> Observed with QEMU's RPi-3 emulation.
>
> Fixes: 12ead77432f2 ("clk: Don't try to enable critical clocks if prepare failed")
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Michael Turquette <mturquette@baylibre.com>
> ---
Applied to clk-fixes
prev parent reply other threads:[~2020-05-05 19:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 14:09 [PATCH] clk: Unlink clock if failed to prepare or enable Marc Zyngier
2020-05-05 19:12 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158870592381.26370.8784478076215991539@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maz@kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).