From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1E54C433E0 for ; Wed, 27 May 2020 07:06:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA8EA2078C for ; Wed, 27 May 2020 07:06:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590563174; bh=Bnwio/T0f8/rO+4l0ETfUXCahBdmz6vzX2tvqweK3c4=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=w2k3twATrlJLPA5BqN2iszoZzp5b39/smn1BWcVXyvOle0qGiZ0HlwXWOrNBoPedR tGBvQQQtRpfeefo0bwerh8pwfCIkQNKZNKscT3AqFn7hRsW/Kk5KsLihATgXrEP7u9 zsd56v+s9HuM3tH4WeOGvKbg55shJ4Nc7VqX4fR4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728111AbgE0HGO (ORCPT ); Wed, 27 May 2020 03:06:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:36246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726025AbgE0HGO (ORCPT ); Wed, 27 May 2020 03:06:14 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 85A65206F1; Wed, 27 May 2020 07:06:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590563173; bh=Bnwio/T0f8/rO+4l0ETfUXCahBdmz6vzX2tvqweK3c4=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=oF/iNegV3lDmsHA8jl2XuOdgHsm3ArbmfhqDo4tj/ixgr/8+hjuVwgK2omrt1GHqK lftYRB6EtnDGNvsW0OlYmy8Cp4c40r1rRUvQnh70Y1+AmlskJw2okPi3Ha7N8yyMaB MuI4eAKk/rPw1yzcI9NKh9tcdk+KZvcMyWAF4ovE= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: Subject: Re: [PATCH v2 25/91] clk: bcm: Add BCM2711 DVP driver From: Stephen Boyd Cc: dri-devel@lists.freedesktop.org, linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Stevenson , Tim Gover , Phil Elwell , Maxime Ripard , Michael Turquette , Rob Herring , linux-clk@vger.kernel.org, devicetree@vger.kernel.org To: Eric Anholt , Maxime Ripard , Nicolas Saenz Julienne Date: Wed, 27 May 2020 00:06:12 -0700 Message-ID: <159056317280.88029.13256292035418533462@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Maxime Ripard (2020-04-24 08:34:06) > The HDMI block has a block that controls clocks and reset signals to the > HDMI0 and HDMI1 controllers. >=20 > Let's expose that through a clock driver implementing a clock and reset > provider. >=20 > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: Rob Herring > Cc: linux-clk@vger.kernel.org > Cc: devicetree@vger.kernel.org > Signed-off-by: Maxime Ripard > --- Reviewed-by: Stephen Boyd > diff --git a/drivers/clk/bcm/clk-bcm2711-dvp.c b/drivers/clk/bcm/clk-bcm2= 711-dvp.c > new file mode 100644 > index 000000000000..c1c4b5857d32 > --- /dev/null > +++ b/drivers/clk/bcm/clk-bcm2711-dvp.c > @@ -0,0 +1,127 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +// Copyright 2020 Cerno > + > +#include > +#include [...] > + > +static int clk_dvp_probe(struct platform_device *pdev) > +{ > + struct clk_hw_onecell_data *data; > + struct resource *res; > + struct clk_dvp *dvp; > + void __iomem *base; > + int ret; > + > + dvp =3D devm_kzalloc(&pdev->dev, sizeof(*dvp), GFP_KERNEL); > + if (!dvp) > + return -ENOMEM; > + platform_set_drvdata(pdev, dvp); > + > + dvp->data =3D devm_kzalloc(&pdev->dev, > + struct_size(dvp->data, hws, NR_CLOCKS), > + GFP_KERNEL); > + if (!dvp->data) > + return -ENOMEM; > + data =3D dvp->data; > + > + res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > + base =3D devm_ioremap_resource(&pdev->dev, res); devm_platform_ioremap_resource()? > + if (IS_ERR(base)) > + return PTR_ERR(base); > +